Message ID | 20231016155547.2973853-1-robh@kernel.org |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:612c:2908:b0:403:3b70:6f57 with SMTP id ib8csp3557161vqb; Mon, 16 Oct 2023 08:56:14 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGN2Y2MqHh4eDFD0keWbjwDlmgrwyuyKDcJz2hOhpDrLhDrYtfmcI/hj9N2fOHgro/GOkUI X-Received: by 2002:a05:6a00:4783:b0:6b3:c72d:b01 with SMTP id dh3-20020a056a00478300b006b3c72d0b01mr9689209pfb.1.1697471774494; Mon, 16 Oct 2023 08:56:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697471774; cv=none; d=google.com; s=arc-20160816; b=x9VLzHMkcscsV/qk+4lMgOeBD1/Y6W7beX9fvzVgWzOJz95HqPKPsy0muenkTuORTl XnQzD/BPRqEuTk1Ics5X0DrMoR4SwOCE/AkucqfeV2TOaDYjUY8ZF68jyQvgajpjpEJ1 DnkF0yOtIjBSh1wIAwq06l7aVhgww+LZkacNrd05EwBvw0+43vv1ZiHa4g41LxMFHoyn EL3M+DOVkONGF/aStOLvMjy5WjWP5YZWqW0p/nYBbzFT/gMHMoOkNZt0rflqwoi5yW7D jzRp0SUfFCCDg4Y5pKLhusrbqxjIqSJ75hoi3ysc8nBSAT0oPWwhOPAmuMtk4dDNQIQA o3bQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=bYqTlxzJpgPZHi0SFQeGZeZ+UqJkgDA/Fe8BpwAySnI=; fh=MrxgxmELyi9v0F8YDUBZ5igAkCK8yKGT80iypZW6spY=; b=N0CVzAH1XAGWXyrlK+dUn+PVy8Y34vJQuZ2fCl4bgLxKIr7KAWe+yi+UlzcD06/wJI PnvZRx1sfYuWsSP/m8UgLHUyiG2W9roDfxvN95iCuMHCJwYp/UcQZMz2uWxhwUwo3PQp 7GD7CAArjUV0F6HDM3UmsaSx1MWf9LpxCFVDZ63u8Gwh2ZwViLek1+Kso6MNu4n+YeSr kR5uqaKJxziTGRknL4zdQe1Gmp0ogGvNpLM10A0vsAvCogJUvV5L2Llfx4HBM3x8SKxn 7S2mqK5z1Cnt602BlgAqS7s/0iHrqqHgJr8A+oZCJ4q1IQlV7oW1VuFNdEtJWvmDk2kq 644g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from groat.vger.email (groat.vger.email. [2620:137:e000::3:5]) by mx.google.com with ESMTPS id q1-20020aa79601000000b006b6cc63a79csi66723pfg.330.2023.10.16.08.56.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Oct 2023 08:56:14 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id 2305F80A0E0D; Mon, 16 Oct 2023 08:56:12 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233925AbjJPP4E (ORCPT <rfc822;hjfbswb@gmail.com> + 18 others); Mon, 16 Oct 2023 11:56:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39554 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233952AbjJPPz5 (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Mon, 16 Oct 2023 11:55:57 -0400 Received: from mail-ot1-f51.google.com (mail-ot1-f51.google.com [209.85.210.51]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 58EAA109; Mon, 16 Oct 2023 08:55:54 -0700 (PDT) Received: by mail-ot1-f51.google.com with SMTP id 46e09a7af769-6c665b2469dso3181022a34.0; Mon, 16 Oct 2023 08:55:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697471753; x=1698076553; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=bYqTlxzJpgPZHi0SFQeGZeZ+UqJkgDA/Fe8BpwAySnI=; b=LeRqlsXFavZF/pAgOwuOwgFtG2IZZ5wRQ/ZHB/78Eo/j7URCy6yy8P3YcIEomdLFkQ R0gmmScS3djnixodnRzq5eFsnbrLPHjXx6V/TXg2Lp2xidEqys5bQCN2J7oYLms3aBZn yvJGoxP4D5iSfZKvK1cXY5QuPs+gnLzT+9RtHn0d0cZkvM7qrtI+V/f7u9RHSBiqmm7k OvzKFjMRhP5/Gvbt0ctS0l/HLvKvZm/cXsT6mj7dOUa2wwGnFnmPCzZ5KSMiMafxV1Qk gpdVrMh85x0jiu6KCoVy790jSUkzjZu+/pe3MUH61oaiS656fBxb+MiJEGPGGyFPmyz0 fbtw== X-Gm-Message-State: AOJu0YxvjRTxFRh5KiNAZBp8DEZhdRQotJaPXU4WeDA3ZZgFx+u4c6Je 36S1ujtA9ouXqCuR18oydA== X-Received: by 2002:a9d:74d9:0:b0:6b8:7eef:a236 with SMTP id a25-20020a9d74d9000000b006b87eefa236mr36034676otl.30.1697471753539; Mon, 16 Oct 2023 08:55:53 -0700 (PDT) Received: from robh_at_kernel.org (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id q6-20020a9d4b06000000b006b89dafb721sm1726248otf.78.2023.10.16.08.55.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Oct 2023 08:55:52 -0700 (PDT) Received: (nullmailer pid 2973998 invoked by uid 1000); Mon, 16 Oct 2023 15:55:51 -0000 From: Rob Herring <robh@kernel.org> To: Liam Girdwood <lgirdwood@gmail.com>, Mark Brown <broonie@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, Daniel Beer <daniel.beer@igorinstitute.com> Cc: alsa-devel@alsa-project.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] ASoC: dt-bindings: tas5805m: Disallow undefined properties Date: Mon, 16 Oct 2023 10:55:47 -0500 Message-ID: <20231016155547.2973853-1-robh@kernel.org> X-Mailer: git-send-email 2.42.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.0 required=5.0 tests=MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Mon, 16 Oct 2023 08:56:12 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1779928163130818334 X-GMAIL-MSGID: 1779928163130818334 |
Series |
ASoC: dt-bindings: tas5805m: Disallow undefined properties
|
|
Commit Message
Rob Herring
Oct. 16, 2023, 3:55 p.m. UTC
Device specific bindings should not allow undefined properties. This is
accomplished in json-schema with 'additionalProperties: false'.
Examples should be last in the schema, so move additionalProperties up
while we're here.
Signed-off-by: Rob Herring <robh@kernel.org>
---
Documentation/devicetree/bindings/sound/tas5805m.yaml | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
Comments
On Mon, Oct 16, 2023 at 10:55:47AM -0500, Rob Herring wrote: > Device specific bindings should not allow undefined properties. This is > accomplished in json-schema with 'additionalProperties: false'. > > Examples should be last in the schema, so move additionalProperties up > while we're here. > > Signed-off-by: Rob Herring <robh@kernel.org> Acked-by: Conor Dooley <conor.dooley@microchip.com> Thanks, Conor. > --- > Documentation/devicetree/bindings/sound/tas5805m.yaml | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/sound/tas5805m.yaml b/Documentation/devicetree/bindings/sound/tas5805m.yaml > index 63edf52f061c..12c41974274e 100644 > --- a/Documentation/devicetree/bindings/sound/tas5805m.yaml > +++ b/Documentation/devicetree/bindings/sound/tas5805m.yaml > @@ -37,6 +37,8 @@ properties: > generated from TI's PPC3 tool. > $ref: /schemas/types.yaml#/definitions/string > > +additionalProperties: false > + > examples: > - | > i2c { > @@ -52,5 +54,4 @@ examples: > ti,dsp-config-name = "mono_pbtl_48khz"; > }; > }; > - > -additionalProperties: true > +... > -- > 2.42.0 > >
On Tue, Oct 17, 2023 at 11:50:42AM +0100, Conor Dooley wrote: > On Mon, Oct 16, 2023 at 10:55:47AM -0500, Rob Herring wrote: > > Device specific bindings should not allow undefined properties. This is > > accomplished in json-schema with 'additionalProperties: false'. > > > > Examples should be last in the schema, so move additionalProperties up > > while we're here. > > > > Signed-off-by: Rob Herring <robh@kernel.org> > Acked-by: Conor Dooley <conor.dooley@microchip.com> Rob, I don't have the original patch for this. It looks like whatever email troubles you were having are persisting - if there's anything else you've sent me I'm just unawaere of it.
On Mon, 16 Oct 2023 10:55:47 -0500, Rob Herring wrote: > Device specific bindings should not allow undefined properties. This is > accomplished in json-schema with 'additionalProperties: false'. > > Examples should be last in the schema, so move additionalProperties up > while we're here. > > > [...] Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [1/1] ASoC: dt-bindings: tas5805m: Disallow undefined properties commit: 086357275fc7635c5a2856c667b3d2f7604403fa All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark
diff --git a/Documentation/devicetree/bindings/sound/tas5805m.yaml b/Documentation/devicetree/bindings/sound/tas5805m.yaml index 63edf52f061c..12c41974274e 100644 --- a/Documentation/devicetree/bindings/sound/tas5805m.yaml +++ b/Documentation/devicetree/bindings/sound/tas5805m.yaml @@ -37,6 +37,8 @@ properties: generated from TI's PPC3 tool. $ref: /schemas/types.yaml#/definitions/string +additionalProperties: false + examples: - | i2c { @@ -52,5 +54,4 @@ examples: ti,dsp-config-name = "mono_pbtl_48khz"; }; }; - -additionalProperties: true +...