From patchwork Mon Oct 16 15:30:51 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 153501 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:612c:2908:b0:403:3b70:6f57 with SMTP id ib8csp3542294vqb; Mon, 16 Oct 2023 08:31:21 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHa+SNboSO2GsO5KmoP92rBMLe+imT7KJMDqDIk+DZ+wpf+mL15LRfeOb4EL91dvawRiepy X-Received: by 2002:a05:6a20:1584:b0:15d:f804:6907 with SMTP id h4-20020a056a20158400b0015df8046907mr40498884pzj.0.1697470281100; Mon, 16 Oct 2023 08:31:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697470281; cv=none; d=google.com; s=arc-20160816; b=rbGU49lP01nuppJwZUb77OG6/p66TSwq1RT+mTpWlOPw2VCiILrBjqPXXYJgnzsbyG 9HBp05ZYbTtobc8iNVferl7JcG/Ogm0MVUIVPTo9qPC/tREtB/XnPTshshEWVFaK/T7y 5wUrsPPwGAFaghmUbdGkixiqN4rgW5ZD9dovXgKU44o96rUxflLMbpumOrML7nAGH/GI tbZCZuF0crjgTINNU0BpCbiGJOP0LmMbFSEdKt3RmfKhJa1b0Ktk0gw5rUITx4x8Y/BJ gdBDg3vhBpk4djXQKGBBd4q3LUt/jZcVmQOYFek7D8seWa+4pe0S6fJO+vmKAqrK2whL Bj6w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=MblyG7AGWJgtk2SwVX1nf24vKreS1s9X0eDbBdaTscY=; fh=ieNU6J2CCMFcjsonbfumoLV8NJC7190bebRui38VHqc=; b=NM/qxkMsxuhHt9QFwlg4I9C3JsKvKLXgrMYQOdIGokqhLrW2mE9y1JCOdQiKOcR/Bb nbWAzsh938+6psppqyxrAl2bTc7dwJ8uVg+Lf88sp1tl6PhgaZZ2c9jFlEzlPJkin8vT XcV2IWlbBejyu9XgRP+sXzmbN5aAvHraJvMkA0HeIwhAzL6Qnwupp8JKqif4fQIHXbrH ZKWd/xnuQvd6itXVeC7/giBUPLTMEdtDVd8IOZcVoYjAbyyk/MU548aWxiZEQS5xAzY5 i350xokPYxzcPRqw/hAfypty67X1P/XVvHMOu6jcAuim2hjMCU128a1sy+ZV9Enie/bA HDRw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=New87foo; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from agentk.vger.email (agentk.vger.email. [23.128.96.32]) by mx.google.com with ESMTPS id ay24-20020a17090b031800b00276b87c8b8esi6302063pjb.59.2023.10.16.08.31.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Oct 2023 08:31:21 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=New87foo; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id 5A011805B9E4; Mon, 16 Oct 2023 08:31:18 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232731AbjJPPbA (ORCPT + 18 others); Mon, 16 Oct 2023 11:31:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51698 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231896AbjJPPa6 (ORCPT ); Mon, 16 Oct 2023 11:30:58 -0400 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.7]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 76D24B4; Mon, 16 Oct 2023 08:30:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1697470256; x=1729006256; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=RQU8/Zny7LUH+xDdoP1sBFUskYkB9NhPlwDT24YZKrQ=; b=New87fooCZGCPjDieI26pgbQ/3fMznUEs42SeLBDcvEMLov/Wwlrlshr DlszLacHjiaeOFDzHdsgqNiAM7SWumW4Fzvj0UyS3AyDbmb73BfQdVIM1 oN2dv3Gx8PpkCRVB3Ym8JPIFEaaoykVej38B+c0iz1lvHx873gIadL7JI i4tKIXfVaUklhXLwMAqjZkfXDb1i0a164KSyTLZmAZhXrgPAP2NeCYRJc 7OHByQpxC0Cy+BJwefY/717v2ns5MYDjXOllSTZwK27jCI2YRw7Ja5R0b cs4Gl1Nppr1Pvbeog3eYdcU6HJ4Vp82aXfdeC/OCmh24oH+g2JNTqZNhT Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10863"; a="7121603" X-IronPort-AV: E=Sophos;i="6.03,229,1694761200"; d="scan'208";a="7121603" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmvoesa101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Oct 2023 08:30:56 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10863"; a="1002987990" X-IronPort-AV: E=Sophos;i="6.03,229,1694761200"; d="scan'208";a="1002987990" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga006.fm.intel.com with ESMTP; 16 Oct 2023 08:30:54 -0700 Received: by black.fi.intel.com (Postfix, from userid 1003) id CF423385; Mon, 16 Oct 2023 18:30:52 +0300 (EEST) From: Andy Shevchenko To: Hans de Goede , linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Pavel Machek , Lee Jones , Andy Shevchenko , Denis Osterland-Heim Subject: [PATCH v2 1/1] leds: core: Refactor led_update_brightness() to use standard pattern Date: Mon, 16 Oct 2023 18:30:51 +0300 Message-Id: <20231016153051.1409074-1-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.40.0.1.gaa8946217a0b MIME-Version: 1.0 X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Mon, 16 Oct 2023 08:31:18 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1779926597560275093 X-GMAIL-MSGID: 1779926597560275093 The standard conditional pattern is to check for errors first and bail out if any. Refactor led_update_brightness() accordingly. While at it, drop unneeded assignment and return 0 unconditionally on success. Acked-by: Denis Osterland-Heim Signed-off-by: Andy Shevchenko Reviewed-by: Hans de Goede --- v2: added tag (Denis), Cc'ed to the updated list of LED maintainers drivers/leds/led-core.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/leds/led-core.c b/drivers/leds/led-core.c index 2230239283d0..89c9806cc97f 100644 --- a/drivers/leds/led-core.c +++ b/drivers/leds/led-core.c @@ -364,17 +364,17 @@ EXPORT_SYMBOL_GPL(led_set_brightness_sync); int led_update_brightness(struct led_classdev *led_cdev) { - int ret = 0; + int ret; if (led_cdev->brightness_get) { ret = led_cdev->brightness_get(led_cdev); - if (ret >= 0) { - led_cdev->brightness = ret; - return 0; - } + if (ret < 0) + return ret; + + led_cdev->brightness = ret; } - return ret; + return 0; } EXPORT_SYMBOL_GPL(led_update_brightness);