[resend,v1,1/1] logic_pio: Use RESOURCE_SIZE_MAX definition

Message ID 20231016132611.1201402-1-andriy.shevchenko@linux.intel.com
State New
Headers
Series [resend,v1,1/1] logic_pio: Use RESOURCE_SIZE_MAX definition |

Commit Message

Andy Shevchenko Oct. 16, 2023, 1:26 p.m. UTC
  Use a predefined limit instead of hardcoding it.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
v1: resent with Andrew in Cc list
Initial contribution was here more than a month ago:
https://lore.kernel.org/r/20230911224500.16677-1-andriy.shevchenko@linux.intel.com
 lib/logic_pio.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
  

Comments

Andy Shevchenko Nov. 20, 2023, 5:19 p.m. UTC | #1
On Mon, Oct 16, 2023 at 04:26:11PM +0300, Andy Shevchenko wrote:
> Use a predefined limit instead of hardcoding it.

Any comments on this?
  
Andy Shevchenko Dec. 22, 2023, 3:03 p.m. UTC | #2
On Mon, Nov 20, 2023 at 07:19:08PM +0200, Andy Shevchenko wrote:
> On Mon, Oct 16, 2023 at 04:26:11PM +0300, Andy Shevchenko wrote:
> > Use a predefined limit instead of hardcoding it.
> 
> Any comments on this?

It's month passed, can this be applied if no further comments?
  
Matthew Wilcox Dec. 22, 2023, 4:11 p.m. UTC | #3
On Fri, Dec 22, 2023 at 05:03:00PM +0200, Andy Shevchenko wrote:
> On Mon, Nov 20, 2023 at 07:19:08PM +0200, Andy Shevchenko wrote:
> > On Mon, Oct 16, 2023 at 04:26:11PM +0300, Andy Shevchenko wrote:
> > > Use a predefined limit instead of hardcoding it.
> > 
> > Any comments on this?
> 
> It's month passed, can this be applied if no further comments?

Maybe you should cc someone who knows about and cares about the
code instead of someone who did a driveby patch recently?
get_maintainer.pl is not a replacement for using your brain.
  
Andy Shevchenko Feb. 2, 2024, 3:35 p.m. UTC | #4
On Mon, Oct 16, 2023 at 04:26:11PM +0300, Andy Shevchenko wrote:
> Use a predefined limit instead of hardcoding it.

Can we apply this one?
  
Matthew Wilcox Feb. 2, 2024, 10:37 p.m. UTC | #5
On Fri, Feb 02, 2024 at 05:35:42PM +0200, Andy Shevchenko wrote:
> On Mon, Oct 16, 2023 at 04:26:11PM +0300, Andy Shevchenko wrote:
> > Use a predefined limit instead of hardcoding it.
> 
> Can we apply this one?

Why are you asking me?  I don't even know what this driver is for.
  

Patch

diff --git a/lib/logic_pio.c b/lib/logic_pio.c
index 2ea564a40064..1cab23e4f856 100644
--- a/lib/logic_pio.c
+++ b/lib/logic_pio.c
@@ -175,7 +175,7 @@  resource_size_t logic_pio_to_hwaddr(unsigned long pio)
 	if (range)
 		return range->hw_start + pio - range->io_start;
 
-	return (resource_size_t)~0;
+	return RESOURCE_SIZE_MAX;
 }
 
 /**