diff mbox series

arm64: dts: qcom: sc8280xp-crd: fix eDP phy compatible

Message ID 20231016080658.6667-1-johan+linaro@kernel.org
State New
Headers
Series arm64: dts: qcom: sc8280xp-crd: fix eDP phy compatible |

Commit Message

Johan Hovold Oct. 16, 2023, 8:06 a.m. UTC 
  The sc8280xp Display Port PHYs can be used in either DP or eDP mode and
this is configured using the devicetree compatible string which defaults
to DP mode in the SoC dtsi.

Override the default compatible string for the CRD eDP PHY node so that
the eDP settings are used.

Fixes: 4a883a8d80b5 ("arm64: dts: qcom: sc8280xp-crd: Enable EDP")
Cc: stable@vger.kernel.org      # 6.3
Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
---
 arch/arm64/boot/dts/qcom/sc8280xp-crd.dts | 2 ++
 1 file changed, 2 insertions(+)

Comments

Dmitry Baryshkov Oct. 16, 2023, 8:53 a.m. UTC | #1 
On Mon, 16 Oct 2023 at 11:07, Johan Hovold <johan+linaro@kernel.org> wrote:
>
> The sc8280xp Display Port PHYs can be used in either DP or eDP mode and
> this is configured using the devicetree compatible string which defaults
> to DP mode in the SoC dtsi.
>
> Override the default compatible string for the CRD eDP PHY node so that
> the eDP settings are used.
>
> Fixes: 4a883a8d80b5 ("arm64: dts: qcom: sc8280xp-crd: Enable EDP")
> Cc: stable@vger.kernel.org      # 6.3
> Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
> ---
>  arch/arm64/boot/dts/qcom/sc8280xp-crd.dts | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc8280xp-crd.dts b/arch/arm64/boot/dts/qcom/sc8280xp-crd.dts
> index 772953dc428e..31a2a2d27f4e 100644
> --- a/arch/arm64/boot/dts/qcom/sc8280xp-crd.dts
> +++ b/arch/arm64/boot/dts/qcom/sc8280xp-crd.dts
> @@ -458,6 +458,8 @@ mdss0_dp3_out: endpoint {
>  };
>
>  &mdss0_dp3_phy {
> +       compatible = "qcom,sc8280xp-edp-phy";

Same question here as the one I've sent for Konrad's patch. Is it the
same PHY type, just being repurposed for eDP or is it a different PHY
type?

> +
>         vdda-phy-supply = <&vreg_l6b>;
>         vdda-pll-supply = <&vreg_l3b>;
>
> --
> 2.41.0
>
Johan Hovold Oct. 16, 2023, 9:04 a.m. UTC | #2 
On Mon, Oct 16, 2023 at 11:53:02AM +0300, Dmitry Baryshkov wrote:
> On Mon, 16 Oct 2023 at 11:07, Johan Hovold <johan+linaro@kernel.org> wrote:
> >
> > The sc8280xp Display Port PHYs can be used in either DP or eDP mode and
> > this is configured using the devicetree compatible string which defaults
> > to DP mode in the SoC dtsi.
> >
> > Override the default compatible string for the CRD eDP PHY node so that
> > the eDP settings are used.
> >
> > Fixes: 4a883a8d80b5 ("arm64: dts: qcom: sc8280xp-crd: Enable EDP")
> > Cc: stable@vger.kernel.org      # 6.3
> > Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
> > ---
> >  arch/arm64/boot/dts/qcom/sc8280xp-crd.dts | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/sc8280xp-crd.dts b/arch/arm64/boot/dts/qcom/sc8280xp-crd.dts
> > index 772953dc428e..31a2a2d27f4e 100644
> > --- a/arch/arm64/boot/dts/qcom/sc8280xp-crd.dts
> > +++ b/arch/arm64/boot/dts/qcom/sc8280xp-crd.dts
> > @@ -458,6 +458,8 @@ mdss0_dp3_out: endpoint {
> >  };
> >
> >  &mdss0_dp3_phy {
> > +       compatible = "qcom,sc8280xp-edp-phy";
> 
> Same question here as the one I've sent for Konrad's patch. Is it the
> same PHY type, just being repurposed for eDP or is it a different PHY
> type?

Just replied in the other thread:

	https://lore.kernel.org/lkml/ZSz7---IW_7Oj2Zr@hovoldconsulting.com/

Johan
Bjorn Andersson Dec. 3, 2023, 4:54 a.m. UTC | #3 
On Mon, 16 Oct 2023 10:06:58 +0200, Johan Hovold wrote:
> The sc8280xp Display Port PHYs can be used in either DP or eDP mode and
> this is configured using the devicetree compatible string which defaults
> to DP mode in the SoC dtsi.
> 
> Override the default compatible string for the CRD eDP PHY node so that
> the eDP settings are used.
> 
> [...]

Applied, thanks!

[1/1] arm64: dts: qcom: sc8280xp-crd: fix eDP phy compatible
      commit: 663affdb12b3e26c77d103327cf27de720c8117e

Best regards,
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/qcom/sc8280xp-crd.dts b/arch/arm64/boot/dts/qcom/sc8280xp-crd.dts
index 772953dc428e..31a2a2d27f4e 100644
--- a/arch/arm64/boot/dts/qcom/sc8280xp-crd.dts
+++ b/arch/arm64/boot/dts/qcom/sc8280xp-crd.dts
@@ -458,6 +458,8 @@  mdss0_dp3_out: endpoint {
 };
 
 &mdss0_dp3_phy {
+	compatible = "qcom,sc8280xp-edp-phy";
+
 	vdda-phy-supply = <&vreg_l6b>;
 	vdda-pll-supply = <&vreg_l3b>;