| Message ID | 20231016080205.41982-2-tomeu@tomeuvizoso.net |
|---|---|
| State | New |
| Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org>
Delivered-To: ouuuleilei@gmail.com
Received: by 2002:a05:612c:2908:b0:403:3b70:6f57 with SMTP id
ib8csp3304323vqb;
Mon, 16 Oct 2023 01:02:48 -0700 (PDT)
X-Google-Smtp-Source:
AGHT+IHt8l1/9PLqALnMMkni24EoKtW3HsgwUHQ2uFcc0EyzzZVFruuT4e6S+rElKX6m+EsAckBr
X-Received: by 2002:a05:6a00:3386:b0:6b2:51a0:e1c9 with SMTP id
cm6-20020a056a00338600b006b251a0e1c9mr9376444pfb.1.1697443368576;
Mon, 16 Oct 2023 01:02:48 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1697443368; cv=none;
d=google.com; s=arc-20160816;
b=Bw9TVeMfjbRFgJiYhcRQfduMqzB9bn0bCNhDq4xvtQ6EdPXtqWT88q1ubHPO/6G/Ge
Z3JtutaErpDzFBFzCppeQzuHJVXmSv4XdTwRc6YuiX2qE81xW+FJd2BBgmolKxyEwGjc
UdnWU3cOkIMpUXt7GTPissIxeh0jC+UlxZsHUtmlQXFcdjymI5UpTVmodgxcY/Re2tL0
Rzu7nO/MfvaReSHxHj1yb9LDUKBfEmaq+3P11Gdcz7BUn28afI+6aRBOo0qdnOMbvzal
GCZzkFVjT1XcCgZUyiGiKvr7KzyTL5mcRPkez3cSFDVU9xx48rPkAkqQn1ZPbwWxYrpJ
aL0w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20160816;
h=list-id:precedence:content-transfer-encoding:mime-version
:references:in-reply-to:message-id:date:subject:cc:to:from;
bh=qtLS9Nj2nFZBWPhUvEtRP9PYRoru3Ywsw6HKjKsybKc=;
fh=L/Q/9IqQO0j73I7EuiwAfZwerblrtYYQQeBHZ+nnxwQ=;
b=SXdfra4eCjePmsCes215ipses6eBWWx0xbHBch4lspDbRG2bzAu8rNb+gBpmwmtYkk
zQBIhXyXrW3D374NBz8X+ka1Boy+FuSKqd4v04TwBUKAxGSVnxP6vsx3c9L7AgZKeHyZ
V+jw4sQEB5ILtB1fK26DyoFQysIHnmCdn0XZ3a0vQ0zSNkLu8nwyi8bnnU8Ogfgh/bcU
8FwzmUbyOFkTC2jdP4HUEAfKpRZs8N9tOeNxxK0YC0vd9QFn4zY5RIM80CTDkepwphnk
v0jLvKRBsQjDfFszZaDDYromp70/ML5AkXdxclFZ2pQ6v36iY0GaCZ8W1b8hTJuw1Ep9
hEXw==
ARC-Authentication-Results: i=1; mx.google.com;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 23.128.96.34 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: from howler.vger.email (howler.vger.email. [23.128.96.34])
by mx.google.com with ESMTPS id
d21-20020a056a0024d500b0068e3f55075esi4433656pfv.134.2023.10.16.01.02.48
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Mon, 16 Oct 2023 01:02:48 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34;
Authentication-Results: mx.google.com;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 23.128.96.34 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0])
by howler.vger.email (Postfix) with ESMTP id 9467180622B2;
Mon, 16 Oct 2023 01:02:46 -0700 (PDT)
X-Virus-Status: Clean
X-Virus-Scanned: clamav-milter 0.103.10 at howler.vger.email
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
id S231905AbjJPIC0 (ORCPT <rfc822;hjfbswb@gmail.com> + 18 others);
Mon, 16 Oct 2023 04:02:26 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57324 "EHLO
lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
with ESMTP id S229478AbjJPICX (ORCPT
<rfc822;linux-kernel@vger.kernel.org>);
Mon, 16 Oct 2023 04:02:23 -0400
Received: from mail-lf1-f44.google.com (mail-lf1-f44.google.com
[209.85.167.44])
by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 36529DC;
Mon, 16 Oct 2023 01:02:19 -0700 (PDT)
Received: by mail-lf1-f44.google.com with SMTP id
2adb3069b0e04-50435ad51bbso5317898e87.2;
Mon, 16 Oct 2023 01:02:19 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1697443337; x=1698048137;
h=content-transfer-encoding:mime-version:references:in-reply-to
:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc
:subject:date:message-id:reply-to;
bh=qtLS9Nj2nFZBWPhUvEtRP9PYRoru3Ywsw6HKjKsybKc=;
b=c0IZT4D8Nsxv62ZEZlgu2DEtSvWccOrCZFGl5xEN5f3Zf6/A3QZtj1WLO9HAQPcyn7
lVoy6gz6uyWT+wiWKYRkoEqtTy7r5sCJX3bd45pwpb2f9pZ3GoQkO5R89WMIplbM8KHz
KnyAh24OhQJ8/Qd7VI17JBaHRITSHl6kqjoHzlD6umbYj0/ewPlYHCOlWyHkh/DGUDtq
vArVJN00Q5RKyXIaLzI6VY/QTvH/HvHy7rX10KULcRzrG3fVN5EeqkkIHhmP9Q5GmfrN
WwO9qdiHr0jhPbpmtlXfh5XtSgi51z16aTYoBIU3LMsRgZMk7DZGJyYH5CcZGXFKcQiA
qJ7w==
X-Gm-Message-State: AOJu0Yw/3APZs4kQoqub3dP3Q00Ve4ryvSdnyroZru67MC+CYlmocv6P
nnrZL7c8v92q9J4Q/MFXrYAFX6Pe+5cR1jLH
X-Received: by 2002:a05:6512:33d0:b0:507:a1df:1408 with SMTP id
d16-20020a05651233d000b00507a1df1408mr4684169lfg.55.1697443337286;
Mon, 16 Oct 2023 01:02:17 -0700 (PDT)
Received: from cizrna.home (cst-prg-37-192.cust.vodafone.cz. [46.135.37.192])
by smtp.gmail.com with ESMTPSA id
p22-20020a05600c419600b00407460234f9sm6395535wmh.21.2023.10.16.01.02.16
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Mon, 16 Oct 2023 01:02:16 -0700 (PDT)
From: Tomeu Vizoso <tomeu@tomeuvizoso.net>
To: linux-kernel@vger.kernel.org
Cc: Da Xue <da@libre.computer>, Tomeu Vizoso <tomeu@tomeuvizoso.net>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Neil Armstrong <neil.armstrong@linaro.org>,
Kevin Hilman <khilman@baylibre.com>,
Jerome Brunet <jbrunet@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org, linux-pm@vger.kernel.org
Subject: [PATCH 2/2] pmdomain: amlogic: Fix mask for the second NNA mem PD
domain
Date: Mon, 16 Oct 2023 10:02:04 +0200
Message-ID: <20231016080205.41982-2-tomeu@tomeuvizoso.net>
X-Mailer: git-send-email 2.41.0
In-Reply-To: <20231016080205.41982-1-tomeu@tomeuvizoso.net>
References: <20231016080205.41982-1-tomeu@tomeuvizoso.net>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Status: No,
score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS,
MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable
autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test,
not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]);
Mon, 16 Oct 2023 01:02:46 -0700 (PDT)
X-getmail-retrieved-from-mailbox: INBOX
X-GMAIL-THRID: 1779898377638643786
X-GMAIL-MSGID: 1779898377638643786
|
| Series |
[1/2] arm64: dts: VIM3: Set the rates of the clocks for the NPU
|
|
Commit Message
Tomeu Vizoso
Oct. 16, 2023, 8:02 a.m. UTC
Without this change, the NPU hangs when the 8th NN core is used.
It matches what the out-of-tree driver does.
Signed-off-by: Tomeu Vizoso <tomeu@tomeuvizoso.net>
---
drivers/pmdomain/amlogic/meson-ee-pwrc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
On Mon, 16 Oct 2023 at 10:02, Tomeu Vizoso <tomeu@tomeuvizoso.net> wrote: > > Without this change, the NPU hangs when the 8th NN core is used. > > It matches what the out-of-tree driver does. > > Signed-off-by: Tomeu Vizoso <tomeu@tomeuvizoso.net> The change looks good to me, but I have been awaiting an ack from some of the platform/soc maintainers before applying. That said, it looks like we need a fixes/stable tag too. Is there a certain commit this fixes? Kind regards Uffe > --- > drivers/pmdomain/amlogic/meson-ee-pwrc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pmdomain/amlogic/meson-ee-pwrc.c b/drivers/pmdomain/amlogic/meson-ee-pwrc.c > index cfb796d40d9d..0dd71cd814c5 100644 > --- a/drivers/pmdomain/amlogic/meson-ee-pwrc.c > +++ b/drivers/pmdomain/amlogic/meson-ee-pwrc.c > @@ -228,7 +228,7 @@ static struct meson_ee_pwrc_mem_domain sm1_pwrc_mem_audio[] = { > > static struct meson_ee_pwrc_mem_domain g12a_pwrc_mem_nna[] = { > { G12A_HHI_NANOQ_MEM_PD_REG0, GENMASK(31, 0) }, > - { G12A_HHI_NANOQ_MEM_PD_REG1, GENMASK(23, 0) }, > + { G12A_HHI_NANOQ_MEM_PD_REG1, GENMASK(31, 0) }, > }; > > #define VPU_PD(__name, __top_pd, __mem, __is_pwr_off, __resets, __clks) \ > -- > 2.41.0 >
Hi Ulf, On 26/10/2023 16:36, Ulf Hansson wrote: > On Mon, 16 Oct 2023 at 10:02, Tomeu Vizoso <tomeu@tomeuvizoso.net> wrote: >> >> Without this change, the NPU hangs when the 8th NN core is used. >> >> It matches what the out-of-tree driver does. >> >> Signed-off-by: Tomeu Vizoso <tomeu@tomeuvizoso.net> > > The change looks good to me, but I have been awaiting an ack from some > of the platform/soc maintainers before applying. > > That said, it looks like we need a fixes/stable tag too. Is there a > certain commit this fixes? It looks good for me, you can add: Fixes: 9a217b7e8953 ("soc: amlogic: meson-pwrc: Add NNA power domain for A311D") and Acked-by: Neil Armstrong <neil.armstrong@linaro.org> Thanks, Neil > > Kind regards > Uffe > >> --- >> drivers/pmdomain/amlogic/meson-ee-pwrc.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/pmdomain/amlogic/meson-ee-pwrc.c b/drivers/pmdomain/amlogic/meson-ee-pwrc.c >> index cfb796d40d9d..0dd71cd814c5 100644 >> --- a/drivers/pmdomain/amlogic/meson-ee-pwrc.c >> +++ b/drivers/pmdomain/amlogic/meson-ee-pwrc.c >> @@ -228,7 +228,7 @@ static struct meson_ee_pwrc_mem_domain sm1_pwrc_mem_audio[] = { >> >> static struct meson_ee_pwrc_mem_domain g12a_pwrc_mem_nna[] = { >> { G12A_HHI_NANOQ_MEM_PD_REG0, GENMASK(31, 0) }, >> - { G12A_HHI_NANOQ_MEM_PD_REG1, GENMASK(23, 0) }, >> + { G12A_HHI_NANOQ_MEM_PD_REG1, GENMASK(31, 0) }, >> }; >> >> #define VPU_PD(__name, __top_pd, __mem, __is_pwr_off, __resets, __clks) \ >> -- >> 2.41.0 >>
On Mon, 16 Oct 2023 at 10:02, Tomeu Vizoso <tomeu@tomeuvizoso.net> wrote: > > Without this change, the NPU hangs when the 8th NN core is used. > > It matches what the out-of-tree driver does. > > Signed-off-by: Tomeu Vizoso <tomeu@tomeuvizoso.net> Applied for fixes and by adding a fixes/stable tag, thanks! Kind regards Uffe > --- > drivers/pmdomain/amlogic/meson-ee-pwrc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pmdomain/amlogic/meson-ee-pwrc.c b/drivers/pmdomain/amlogic/meson-ee-pwrc.c > index cfb796d40d9d..0dd71cd814c5 100644 > --- a/drivers/pmdomain/amlogic/meson-ee-pwrc.c > +++ b/drivers/pmdomain/amlogic/meson-ee-pwrc.c > @@ -228,7 +228,7 @@ static struct meson_ee_pwrc_mem_domain sm1_pwrc_mem_audio[] = { > > static struct meson_ee_pwrc_mem_domain g12a_pwrc_mem_nna[] = { > { G12A_HHI_NANOQ_MEM_PD_REG0, GENMASK(31, 0) }, > - { G12A_HHI_NANOQ_MEM_PD_REG1, GENMASK(23, 0) }, > + { G12A_HHI_NANOQ_MEM_PD_REG1, GENMASK(31, 0) }, > }; > > #define VPU_PD(__name, __top_pd, __mem, __is_pwr_off, __resets, __clks) \ > -- > 2.41.0 >
diff --git a/drivers/pmdomain/amlogic/meson-ee-pwrc.c b/drivers/pmdomain/amlogic/meson-ee-pwrc.c index cfb796d40d9d..0dd71cd814c5 100644 --- a/drivers/pmdomain/amlogic/meson-ee-pwrc.c +++ b/drivers/pmdomain/amlogic/meson-ee-pwrc.c @@ -228,7 +228,7 @@ static struct meson_ee_pwrc_mem_domain sm1_pwrc_mem_audio[] = { static struct meson_ee_pwrc_mem_domain g12a_pwrc_mem_nna[] = { { G12A_HHI_NANOQ_MEM_PD_REG0, GENMASK(31, 0) }, - { G12A_HHI_NANOQ_MEM_PD_REG1, GENMASK(23, 0) }, + { G12A_HHI_NANOQ_MEM_PD_REG1, GENMASK(31, 0) }, }; #define VPU_PD(__name, __top_pd, __mem, __is_pwr_off, __resets, __clks) \