arm64: dts: qcom: msm8939-longcheer-l9100: Add proximity-near-level

Message ID 20231016-bqm5_prox-v1-1-2acdc732be9d@apitzsch.eu
State New
Headers
Series arm64: dts: qcom: msm8939-longcheer-l9100: Add proximity-near-level |

Commit Message

André Apitzsch Oct. 16, 2023, 8:18 p.m. UTC
  Consider an object near to the sensor when their distance is about 4 cm
or below.

Signed-off-by: André Apitzsch <git@apitzsch.eu>
---
 arch/arm64/boot/dts/qcom/msm8939-longcheer-l9100.dts | 1 +
 1 file changed, 1 insertion(+)


---
base-commit: 4d0515b235dec789578d135a5db586b25c5870cb
change-id: 20231016-bqm5_prox-4958ff602855

Best regards,
  

Comments

Konrad Dybcio Oct. 17, 2023, 4:25 p.m. UTC | #1
On 10/16/23 22:18, André Apitzsch wrote:
> Consider an object near to the sensor when their distance is about 4 cm
> or below.
> 
> Signed-off-by: André Apitzsch <git@apitzsch.eu>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>

Out of interest, what is it set to by default?

Konrad
  
André Apitzsch Oct. 17, 2023, 8:03 p.m. UTC | #2
Am Dienstag, dem 17.10.2023 um 18:25 +0200 schrieb Konrad Dybcio:
> 
> 
> On 10/16/23 22:18, André Apitzsch wrote:
> > Consider an object near to the sensor when their distance is about
> > 4 cm
> > or below.
> > 
> > Signed-off-by: André Apitzsch <git@apitzsch.eu>
> > ---
> Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
> 
> Out of interest, what is it set to by default?
> 
> Konrad

The default value is 0.

André
  
Konrad Dybcio Oct. 18, 2023, 8:32 a.m. UTC | #3
On 10/17/23 22:03, André Apitzsch wrote:
> Am Dienstag, dem 17.10.2023 um 18:25 +0200 schrieb Konrad Dybcio:
>>
>>
>> On 10/16/23 22:18, André Apitzsch wrote:
>>> Consider an object near to the sensor when their distance is about
>>> 4 cm
>>> or below.
>>>
>>> Signed-off-by: André Apitzsch <git@apitzsch.eu>
>>> ---
>> Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
>>
>> Out of interest, what is it set to by default?
>>
>> Konrad
> 
> The default value is 0.
That much I could guess :) I was wondering if it meant more like "it can 
detect movement from 1km away" or "disabled"

Konrad
  
André Apitzsch Oct. 18, 2023, 7:53 p.m. UTC | #4
Am Mittwoch, dem 18.10.2023 um 10:32 +0200 schrieb Konrad Dybcio:
> 
> 
> On 10/17/23 22:03, André Apitzsch wrote:
> > Am Dienstag, dem 17.10.2023 um 18:25 +0200 schrieb Konrad Dybcio:
> > > 
> > > 
> > > On 10/16/23 22:18, André Apitzsch wrote:
> > > > Consider an object near to the sensor when their distance is
> > > > about
> > > > 4 cm
> > > > or below.
> > > > 
> > > > Signed-off-by: André Apitzsch <git@apitzsch.eu>
> > > > ---
> > > Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
> > > 
> > > Out of interest, what is it set to by default?
> > > 
> > > Konrad
> > 
> > The default value is 0.
> That much I could guess :) I was wondering if it meant more like "it
> can detect movement from 1km away" or "disabled"
> 
> Konrad

I doubt that this sensor can detect anything from a distance of 50cm.

The values returned by the sensor are all non-negative, i.e. zero means
something like "disabled" as every raw proximity value would be
considered 'near' to the sensor according to the description in
iio/common.yaml.

André
  

Patch

diff --git a/arch/arm64/boot/dts/qcom/msm8939-longcheer-l9100.dts b/arch/arm64/boot/dts/qcom/msm8939-longcheer-l9100.dts
index 6802714fda3f..43cadc826121 100644
--- a/arch/arm64/boot/dts/qcom/msm8939-longcheer-l9100.dts
+++ b/arch/arm64/boot/dts/qcom/msm8939-longcheer-l9100.dts
@@ -139,6 +139,7 @@  magnetometer@d {
 	light-sensor@23 {
 		compatible = "liteon,ltr559";
 		reg = <0x23>;
+		proximity-near-level = <75>;
 
 		vdd-supply = <&pm8916_l17>;
 		vddio-supply = <&pm8916_l5>;