Message ID | 20231014104942.856152-3-vamshigajjela@google.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:612c:2908:b0:403:3b70:6f57 with SMTP id ib8csp2411255vqb; Sat, 14 Oct 2023 03:50:42 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG9WPkNNFyFo/mJX12u1LLGFIj9BXDCy5og3sRq+9wKN+TyvlOHbTEWUvKRWZehKbhvJo+R X-Received: by 2002:a17:903:22cc:b0:1b8:2ba0:c9a8 with SMTP id y12-20020a17090322cc00b001b82ba0c9a8mr32039469plg.2.1697280641914; Sat, 14 Oct 2023 03:50:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697280641; cv=none; d=google.com; s=arc-20160816; b=Zidxi8DcBEyQ6A/F+eNHreohHyzfDzAdeEQBoSWR+EMeyW3MxbKbKS3vk1YBLdGIb7 0c1OokCX5/VssxONEIqCGpzAU8pB48yzym8e4KvuOXfnB80rUNJQ1Ga5cnmdk7V8fEpr 1AU9HUW76Onlk/D2NUnnO3i2bNw2ls5QFSSNYmAFifq/tyQo42dGr84MQSCPv0uo+GnX exhAB4y0yvPB4UxeotEMFNZvAh5ae4jsyx0ZpuCRiCX9qR0P+lxNNCDzNzdolXEl3ThE aJBGgR0aNdpNft0mTd1Ahf+RvUaxBza5atix/En4LqYF/BToT8+GwsuB45fgSpLDUwfP +tLA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:dkim-signature; bh=I0MUXgCgPp7gRv8+WcNEgYQP5+7MSeABFPYxMKK1EzU=; fh=4iPUH3SCaUeHRPwZInlqPLZI8cmh/b74OgcORLvvuVM=; b=xtHrnOqkEkQEaQ+6OYzk+sH2jxE9gqD7PdPtP72HCOBkMSH0TD3QFUmWZ5984XiV1K kXJnkSE8MOfdJFRO6rz60KjSwS0VtChHhhlOws7ffWdDtvxDMYsX0EMIYrrpZG4+IYiB OgwhsmcC2H6EU5DO9Ult0CKzulr2xNp/RjlnJzYH6D1QKmzsO+sjjugHiuCf8YvSjntd x+gCogaJi0WEMFyzp1hwRomZ2M8nSgVQ+WNV3Ew9M5kHUUWxnKyWA6jXVELsmArscFPg QcixQCmFNHkAbCOCzWKH5zAacLejQjI7DDvQuV3CfySI5pjJZmXCS7HbupaNmwx6i0KS eljw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20230601 header.b=FL36Pbjd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: from pete.vger.email (pete.vger.email. [2620:137:e000::3:6]) by mx.google.com with ESMTPS id x8-20020a170902ec8800b001b9be39eaa8si6956214plg.348.2023.10.14.03.50.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 14 Oct 2023 03:50:41 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) client-ip=2620:137:e000::3:6; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20230601 header.b=FL36Pbjd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by pete.vger.email (Postfix) with ESMTP id D527B8131C03; Sat, 14 Oct 2023 03:50:39 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at pete.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233157AbjJNKuQ (ORCPT <rfc822;hjfbswb@gmail.com> + 20 others); Sat, 14 Oct 2023 06:50:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43658 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233190AbjJNKuN (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Sat, 14 Oct 2023 06:50:13 -0400 Received: from mail-yw1-x1149.google.com (mail-yw1-x1149.google.com [IPv6:2607:f8b0:4864:20::1149]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 81CE7FC for <linux-kernel@vger.kernel.org>; Sat, 14 Oct 2023 03:50:10 -0700 (PDT) Received: by mail-yw1-x1149.google.com with SMTP id 00721157ae682-5a21c283542so46577907b3.3 for <linux-kernel@vger.kernel.org>; Sat, 14 Oct 2023 03:50:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1697280609; x=1697885409; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=I0MUXgCgPp7gRv8+WcNEgYQP5+7MSeABFPYxMKK1EzU=; b=FL36PbjdncuCHtvIiTjirmj8Y1uHygRUSEiSeK5NjGaW8kAni8c6BvB7VTxYgtO3GY mzzL1GlB7/TlqO/jV99WqnBvAt8nm1wBKYUwLZz1CiBCeD/oT8HQWTgtWKW0wzTNaqvM MKEh7aczALaYKVEMwOMq4hIrfdhPorxcAyvMV61i5+CCOIO86PbJG7EfkpWplE4GWkle 3OHU1MyjtgDDdxc5GH6Uc7vOcMd7xT+w8Rm9gB733C0nYG1qf4YLn9jd9Eut/37YdaDG Lp7rlqLFOgoQ2pCRBuJMDkkNl+Fq8u1V0c9MLt3/+gP7odqA/QMl4AOSsUXYnHb9jmrK 5u6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697280609; x=1697885409; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=I0MUXgCgPp7gRv8+WcNEgYQP5+7MSeABFPYxMKK1EzU=; b=An8pw9e4FLTs01edXEoTirVQXY4HiS8DJ9hSJQsHIj7maEte+oSjvoa80S5VLKDRZh ryYXcJdIPlItK2220SOo0uHxNDvuJdqawRVHLy9xScis90IsJjaJTfm8UQoBHI6etU2A FlF7f2DEWvPT34e41MQoaESG0lb0XkE8CnpTTnwmnI7OCn4gZOmQhltMhjtSHLlI4zU4 tViOiqtxzpC3ORmD30uPIZxAAZ2m5zCeio9/SI01+4b8Mj7XAZmuPLGCNN3qI/aWtgc1 5k0eh+rUpAZzlp4F2+s8EggbcmkOZunq76RVh1xwOWHdQtYjCLGFsfMIpS2F5VqKDQ7e QudA== X-Gm-Message-State: AOJu0YxT2Kgc2+iEMyLNDwchcJ+PGHrMN7pyFR72U2VKy/sHNsYXIE/6 WULqxA6rlyIzEMekXe8OTVLYGML5jl9mHxYHrBTR X-Received: from vamshig51.c.googlers.com ([fda3:e722:ac3:cc00:3:22c1:c0a8:70c]) (user=vamshigajjela job=sendgmr) by 2002:a05:690c:4086:b0:5a4:f657:36d9 with SMTP id gb6-20020a05690c408600b005a4f65736d9mr522763ywb.9.1697280609769; Sat, 14 Oct 2023 03:50:09 -0700 (PDT) Date: Sat, 14 Oct 2023 16:19:41 +0530 In-Reply-To: <20231014104942.856152-1-vamshigajjela@google.com> Mime-Version: 1.0 References: <20231014104942.856152-1-vamshigajjela@google.com> X-Mailer: git-send-email 2.42.0.655.g421f12c284-goog Message-ID: <20231014104942.856152-3-vamshigajjela@google.com> Subject: [PATCH 2/3] serial: core: Make local variable size to u64 From: Vamshi Gajjela <vamshigajjela@google.com> To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Jiri Slaby <jirislaby@kernel.org>, ilpo.jarvinen@linux.intel.com Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, manugautam@google.com, Subhash Jadavani <sjadavani@google.com>, Channa Kadabi <kadabi@google.com>, VAMSHI GAJJELA <vamshigajjela@google.com> Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-8.4 required=5.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Sat, 14 Oct 2023 03:50:39 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1779727746279746147 X-GMAIL-MSGID: 1779727746279746147 |
Series |
serial core type consistency and overflow checks
|
|
Commit Message
Vamshi Gajjela
Oct. 14, 2023, 10:49 a.m. UTC
From: VAMSHI GAJJELA <vamshigajjela@google.com> The variable size has been changed from u32 to u64 to accommodate a larger range of values without the need for explicit typecasting. Signed-off-by: VAMSHI GAJJELA <vamshigajjela@google.com> --- drivers/tty/serial/serial_core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
Comments
On Sat, 14 Oct 2023, Vamshi Gajjela wrote: > From: VAMSHI GAJJELA <vamshigajjela@google.com> > > The variable size has been changed from u32 to u64 to accommodate a > larger range of values without the need for explicit typecasting. Don't use too broad/generic terminology in shortlog (on [PATCH] line in subject) or changelog but explicitly mention the variable names please. > Signed-off-by: VAMSHI GAJJELA <vamshigajjela@google.com> > --- > drivers/tty/serial/serial_core.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/tty/serial/serial_core.c b/drivers/tty/serial/serial_core.c > index 7bdc21d5e13b..fb4696d17a8b 100644 > --- a/drivers/tty/serial/serial_core.c > +++ b/drivers/tty/serial/serial_core.c > @@ -410,10 +410,10 @@ void > uart_update_timeout(struct uart_port *port, unsigned int cflag, > unsigned int baud) > { > - unsigned int size = tty_get_frame_size(cflag); > + u64 size = tty_get_frame_size(cflag); > u64 frame_time; > > - frame_time = (u64)size * NSEC_PER_SEC; > + frame_time = size * NSEC_PER_SEC; > port->frame_time = DIV64_U64_ROUND_UP(frame_time, baud); > } > EXPORT_SYMBOL(uart_update_timeout); This is actually a good cleanup all by itself unrelated to the other change but you need to adapt the changelog to reflect why this is helpful instead wording it based on the other change.
On Mon, Oct 16, 2023 at 5:09 PM Ilpo Järvinen <ilpo.jarvinen@linux.intel.com> wrote: > > On Sat, 14 Oct 2023, Vamshi Gajjela wrote: > > > From: VAMSHI GAJJELA <vamshigajjela@google.com> > > > > The variable size has been changed from u32 to u64 to accommodate a > > larger range of values without the need for explicit typecasting. > > Don't use too broad/generic terminology in shortlog (on [PATCH] line in > subject) or changelog but explicitly mention the variable names please. name of the variable is "size", may be now I will rename the variable to "frame_size" in v2 > > > Signed-off-by: VAMSHI GAJJELA <vamshigajjela@google.com> > > --- > > drivers/tty/serial/serial_core.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/tty/serial/serial_core.c b/drivers/tty/serial/serial_core.c > > index 7bdc21d5e13b..fb4696d17a8b 100644 > > --- a/drivers/tty/serial/serial_core.c > > +++ b/drivers/tty/serial/serial_core.c > > @@ -410,10 +410,10 @@ void > > uart_update_timeout(struct uart_port *port, unsigned int cflag, > > unsigned int baud) > > { > > - unsigned int size = tty_get_frame_size(cflag); > > + u64 size = tty_get_frame_size(cflag); > > u64 frame_time; > > > > - frame_time = (u64)size * NSEC_PER_SEC; > > + frame_time = size * NSEC_PER_SEC; > > port->frame_time = DIV64_U64_ROUND_UP(frame_time, baud); > > } > > EXPORT_SYMBOL(uart_update_timeout); > > This is actually a good cleanup all by itself unrelated to the other > change but you need to adapt the changelog to reflect why this is helpful > instead wording it based on the other change. I shall submit this as a separate patch. As mentioned in 1/3 patch I will also add a cast u32 before assigning the value to port->frametime along with variable name and size change. > > -- > i. >
diff --git a/drivers/tty/serial/serial_core.c b/drivers/tty/serial/serial_core.c index 7bdc21d5e13b..fb4696d17a8b 100644 --- a/drivers/tty/serial/serial_core.c +++ b/drivers/tty/serial/serial_core.c @@ -410,10 +410,10 @@ void uart_update_timeout(struct uart_port *port, unsigned int cflag, unsigned int baud) { - unsigned int size = tty_get_frame_size(cflag); + u64 size = tty_get_frame_size(cflag); u64 frame_time; - frame_time = (u64)size * NSEC_PER_SEC; + frame_time = size * NSEC_PER_SEC; port->frame_time = DIV64_U64_ROUND_UP(frame_time, baud); } EXPORT_SYMBOL(uart_update_timeout);