Message ID | 20231013172739.1113964-1-kuba@kernel.org |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:612c:2908:b0:403:3b70:6f57 with SMTP id ib8csp2046246vqb; Fri, 13 Oct 2023 10:28:06 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFixrBq67QChLSJmjMSX1oXAVox6pBd+WNB3PaIHnCAxTEQloGQbb1G/sVdbb3N7OK7rlhT X-Received: by 2002:a05:6a00:39a8:b0:692:ad93:e852 with SMTP id fi40-20020a056a0039a800b00692ad93e852mr29879144pfb.2.1697218086595; Fri, 13 Oct 2023 10:28:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697218086; cv=none; d=google.com; s=arc-20160816; b=t8DlKCJv35cnUymmqdcUFe2RxupaP4Y3FMUwgYLHzGyzorQrA+1n0lDiLykZqCYPLk wX9/vexA96pvdmYQnfGQWh5LGFfvb85qHcxNu1BisIgSCp3wQFcjpZAltgVewIYJ7eQn 5cD574tIepJpfCZclwHOiAjAaVq0NBVaLwJjm/UE/CLe0gGJzi8ay2NREgkVBx44xxjs NcqpOeMdRvCfRixMSGxn1W5DmpPEulEYTuY/qg60dfgNDwxS1YmZuaT+kPsbOj1w2W/e 5jwW+fhCxRpIJ0/Vcct9qZ6TpGf9KCrcdDNobTWQZ0navHJcoJu27H5d3o4nH+SxCVjd lcBA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=mPZLK2aC3SK79HU62w3jpcM2um53A9UVGqcHVmbPQWc=; fh=3ptOOUucjPwos+Z/EZ0vtcLih7KZfexnGO9vW4XdD4Y=; b=d/79WxLq/wlxY7usgjbDugM1pGiBv3jhd+miYhZ63RQYMH3DLPV6jpbKmk7O8BTBvI XJ3EmXRe7fnUEnOEkmbwPgUu9dhBVoXWqgeCAfR/rgmfJmboTu3ddRGbyxoUZLL0bNca Al8XLZeIw+eMI7hKtDZJwha+RNTiplBPnPf5FdmnZ3g4qo1LlHOzn8M5aOJKpHtbiC7V QUsVPmqDsBC2ewoRxq4p+egNdo8L6pxMsrziEfvRcueYKoQAczTBR2vzfRpWS8AIOctB 2vOxj/k4EPwnBmzdAbtcBYS7CkZ8Bgks6nTGgJGpKnw5msY2qxhVJ7IPXr7bXFkZfiej MhYg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=FYnKJKOe; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from morse.vger.email (morse.vger.email. [23.128.96.31]) by mx.google.com with ESMTPS id bo12-20020a056a000e8c00b0068c0300a3f7si9778275pfb.279.2023.10.13.10.28.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Oct 2023 10:28:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=FYnKJKOe; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by morse.vger.email (Postfix) with ESMTP id D9DEE8031AE3; Fri, 13 Oct 2023 10:28:04 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at morse.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231307AbjJMR1r (ORCPT <rfc822;rua109.linux@gmail.com> + 19 others); Fri, 13 Oct 2023 13:27:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46022 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231145AbjJMR1n (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Fri, 13 Oct 2023 13:27:43 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0E837C0 for <linux-kernel@vger.kernel.org>; Fri, 13 Oct 2023 10:27:42 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 249A7C433C7; Fri, 13 Oct 2023 17:27:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1697218061; bh=IqG7fB9OIevVVYlNJDTPsuNDiAKmn7qxXQ6S04F0f9I=; h=From:To:Cc:Subject:Date:From; b=FYnKJKOeLDQaw9BflvX/fL1cuQZX3yDHwUZTbDqScRU03j+bANaZ67QMTfv2FAHhy Ob3O/5STX2G98t+S2I1Gf8FL8CU7Cc08S5ZSGd7Wp9o3Q8yyhBPvI1tpTD+79FsTMr fJhyARVdhf9zKcJkRzTP1TxDQS+++zqh/Q3bx7OdTRil2aibml8Y7t67HcWodRY/jt p5B1v5pi+H3mh0N0xVsclHvJZPpo6nkxzTNu9zVOQSR+7HmqybufWaAKgEBkrUwcCc WEg0kHrFH86+Mu4/xTk9DBp8t59LP9XJ5lANxdBCixqqqoSlLoAmS8CFq9qQCvTwXW BAqfq/0cel0AA== From: Jakub Kicinski <kuba@kernel.org> To: linux-kernel@vger.kernel.org Cc: Jakub Kicinski <kuba@kernel.org>, apw@canonical.com, joe@perches.com, dwaipayanray1@gmail.com, lukas.bulwahn@gmail.com Subject: [PATCH] checkpatch: avoid warning about Possible repeated word: 'Google' Date: Fri, 13 Oct 2023 10:27:39 -0700 Message-ID: <20231013172739.1113964-1-kuba@kernel.org> X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Fri, 13 Oct 2023 10:28:04 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1779662152471870486 X-GMAIL-MSGID: 1779662152471870486 |
Series |
checkpatch: avoid warning about Possible repeated word: 'Google'
|
|
Commit Message
Jakub Kicinski
Oct. 13, 2023, 5:27 p.m. UTC
syzbot stack traces often come with the following line:
Hardware name: Google Google Compute Engine/Google Compute Engine...
This generates the repeated word warning from checkpatch.
It hit 49 times in the last 6 months in networking
(false-positive rate of 0.34%). Mute the warning for "Google",
there's no other word which comes close to being this clear
cut false-positive in our traffic.
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
---
CC: apw@canonical.com
CC: joe@perches.com
CC: dwaipayanray1@gmail.com
CC: lukas.bulwahn@gmail.com
---
scripts/checkpatch.pl | 2 ++
1 file changed, 2 insertions(+)
Comments
On Fri, 2023-10-13 at 10:27 -0700, Jakub Kicinski wrote: > syzbot stack traces often come with the following line: > > Hardware name: Google Google Compute Engine/Google Compute Engine... If you must, you must, but I wonder if code to ignore syzbot blocks might be more sensible. I don't see obvious syzbot start/end block markers though. > This generates the repeated word warning from checkpatch. > It hit 49 times in the last 6 months in networking > (false-positive rate of 0.34%). Mute the warning for "Google", > there's no other word which comes close to being this clear > cut false-positive in our traffic. > > Signed-off-by: Jakub Kicinski <kuba@kernel.org> > --- > CC: apw@canonical.com > CC: joe@perches.com > CC: dwaipayanray1@gmail.com > CC: lukas.bulwahn@gmail.com > --- > scripts/checkpatch.pl | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl > index 7d16f863edf1..c99f8f93cb4c 100755 > --- a/scripts/checkpatch.pl > +++ b/scripts/checkpatch.pl > @@ -3524,6 +3524,8 @@ sub process { > > next if (lc($first) ne lc($second)); > next if ($first eq 'long'); > + # syzbot reports contain "Hardware name: Google Google Compute Engine" > + next if ($first eq 'Google'); > > # check for character before and after the word matches > my $start_char = '';
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 7d16f863edf1..c99f8f93cb4c 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -3524,6 +3524,8 @@ sub process { next if (lc($first) ne lc($second)); next if ($first eq 'long'); + # syzbot reports contain "Hardware name: Google Google Compute Engine" + next if ($first eq 'Google'); # check for character before and after the word matches my $start_char = '';