From patchwork Fri Oct 13 11:59:00 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frederic Weisbecker X-Patchwork-Id: 152551 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:612c:2908:b0:403:3b70:6f57 with SMTP id ib8csp1835324vqb; Fri, 13 Oct 2023 05:01:00 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEkonBEe1TYFOPYUawWzXwtZS7H5e3neOyT1muLbr0gX1s+rGtnkoDGiqKI/LjWwUigSEC4 X-Received: by 2002:a05:6359:b9a:b0:14d:2dd5:a777 with SMTP id gf26-20020a0563590b9a00b0014d2dd5a777mr23097243rwb.2.1697198460489; Fri, 13 Oct 2023 05:01:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697198460; cv=none; d=google.com; s=arc-20160816; b=sNCtylGypZ7GYCw/kvbFO+9hvxfesoj1GlT2QkpbPCxkS7anWk+bpMLNLDFaiZR6Yq ydVyhPUF1Gkwjtwglzvo4vkPNOfLUF6F8mqQZ8THdnKBBh38CUBV82sbDUor7FqvdSCC S2JVDXSinDa84yXz4YCyMX7vernCpfLrL9m3utoWHrOphw9aEbb9PWAyXSCe1Vj/rGvs 55yAeysJOj7eCkrpudLuzlSWQRPI7WLBTdCfXwby4w/csg3vUoGZsar2HdGVdAvciY1+ j1uy4mb2nODFjO/abBqfHsow1K6qrucr1w3gVP6fnGDTaBKApdDQnii/cJuqSVvy9iTr PtLQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=F94cAXAKPCL0o1q8MIify8cg62aD/UmtHGgtRInlSSE=; fh=lTKEK1Rt7LvnHRfa4w1cQ2RgMDufzBK6qxi+oKKQlPU=; b=Vr3X5gjQYhuEbHcqnqnL/te6R7AEDhOmKcd9Z9NQ3AzMOrA7YVSzuiH0VYgvCdCBeW 5e6fvPbqewHvFCi4cKanfHlFQ9Smhbia0atLN0qiwgdnUCYt3dkRUqaf/1IKLEeJYQb/ /QMK/VusmZAhiyepP9sXwF6m+aeWwgL6RHZ+fVuiWd001ZsLtjyV2HznbbX/rm6sj45l m6sNShKkpe8JZ3Tmfd5JdZifF/CdCNs/wJSiVa6fo+B/MN+B8r2MkDBQ3KgpXOoXEIdM MguhF46q8FtDvOLXG6KQdpDhY8ppAlTAITp5lt1eSnFcSx138tCGgJiETttf/FEVxDhU bX9Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=fWNbhv1U; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from fry.vger.email (fry.vger.email. [23.128.96.38]) by mx.google.com with ESMTPS id bv7-20020a056a00414700b00690c75e54e1si13328945pfb.402.2023.10.13.05.01.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Oct 2023 05:01:00 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=fWNbhv1U; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by fry.vger.email (Postfix) with ESMTP id 701B8839FC46; Fri, 13 Oct 2023 05:00:56 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at fry.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231536AbjJMMAu (ORCPT + 19 others); Fri, 13 Oct 2023 08:00:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52480 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231390AbjJMMAP (ORCPT ); Fri, 13 Oct 2023 08:00:15 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DB7471718; Fri, 13 Oct 2023 04:59:54 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 676A5C433CD; Fri, 13 Oct 2023 11:59:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1697198394; bh=DWCRnZosrwhCtgibC90qwLkqDfB/lV91PpsutuxykGQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=fWNbhv1UYD+5FMyjhsmroXXEl7ntF14NZ9IwxNXCXTG0hNaWAryF9wCiKDUblKWMq HlgU2pVpNeEqJv0fmRrCbjc2REyUxDiZXY9HMyz/fJ+qmdsvxoFR7i2u4/IMyRdgKV fYLKDiC+z5G8cDs2TVuCkVWV1XZndocU9EJ5mFuOVIBM30sRZss9yjeOPuq69SKfT+ S333nwDOFbqbuahG/VeBrus6DJaTmG+A0hyzANKLfsviFV50AMj9CLiqF0dlV1Yspa 6DQa4vEewIsK0+2A9BmMP23lnzbgPDNYodygKD2ecGbf0xZpgy0Ph7wTZ/5T6w4yGy GE1NfHOtmJyeg== From: Frederic Weisbecker To: LKML Cc: Frederic Weisbecker , Boqun Feng , Joel Fernandes , Josh Triplett , Mathieu Desnoyers , Neeraj Upadhyay , "Paul E . McKenney" , Steven Rostedt , Uladzislau Rezki , rcu Subject: [PATCH 16/18] rcu: Comment why callbacks migration can't wait for CPUHP_RCUTREE_PREP Date: Fri, 13 Oct 2023 13:59:00 +0200 Message-Id: <20231013115902.1059735-17-frederic@kernel.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20231013115902.1059735-1-frederic@kernel.org> References: <20231013115902.1059735-1-frederic@kernel.org> MIME-Version: 1.0 X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Fri, 13 Oct 2023 05:00:56 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1779641572904565493 X-GMAIL-MSGID: 1779641572904565493 The callbacks migration is performed through an explicit call from the hotplug control CPU right after the death of the target CPU and before proceeding with the CPUHP_ teardown functions. This is unusual but necessary and yet uncommented. Summarize the reason as explained in the changelog of: a58163d8ca2c (rcu: Migrate callbacks earlier in the CPU-offline timeline) Reviewed-by: Paul E. McKenney Signed-off-by: Frederic Weisbecker --- kernel/cpu.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/kernel/cpu.c b/kernel/cpu.c index 2491766e1fd5..3b9d5c7eb4a2 100644 --- a/kernel/cpu.c +++ b/kernel/cpu.c @@ -1372,7 +1372,14 @@ static int takedown_cpu(unsigned int cpu) cpuhp_bp_sync_dead(cpu); tick_cleanup_dead_cpu(cpu); + + /* + * Callbacks must be re-integrated right away to the RCU state machine. + * Otherwise an RCU callback could block a further teardown function + * waiting for its completion. + */ rcutree_migrate_callbacks(cpu); + return 0; }