diff mbox series

[-v2] x86/retpoline: Ensure default return thunk isn't used at runtime

Message ID 20231012141031.GHZSf+V1NjjUJTc9a9@fat_crate.local
State New
Headers
Series [-v2] x86/retpoline: Ensure default return thunk isn't used at runtime |

Commit Message

Borislav Petkov Oct. 12, 2023, 2:10 p.m. UTC 
  On Tue, Oct 10, 2023 at 01:41:19PM -0700, Josh Poimboeuf wrote:
> Even if it's not a security hole, I'd still view it as a major BUG() as
> it would directly contradict our understanding (and the comments above)
> and could cause performance or other correctness issues that would
> otherwise go unnoticed.
> 
> So I think an unconditional UD2 is warranted.

Before David's outlook mangles v2, lemme send it from a real mail
client :-P.

v2 uses X86_FEATURE_ALWAYS as Josh requested.

---
From: David Kaplan <david.kaplan@amd.com>
Date: Thu, 12 Oct 2023 08:52:32 -0500
Subject: [PATCH] x86/retpoline: Ensure default return thunk isn't used at runtime

All CPU bugs that require a return thunk define a special return thunk
to use (e.g., srso_return_thunk).  The default thunk,
__x86_return_thunk, should never be used after apply_returns()
completes.  Otherwise this could lead to potential speculation holes.

Enforce this by replacing this thunk with a ud2 when alternatives are
applied.  Alternative instructions are applied after apply_returns().

The default thunk is only used during kernel boot, it is not used during
module init since that occurs after apply_returns().

Signed-off-by: David Kaplan <david.kaplan@amd.com>
Signed-off-by: Borislav Petkov (AMD) <bp@alien8.de>
---
 arch/x86/lib/retpoline.S | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

Comments

Josh Poimboeuf Oct. 12, 2023, 5:11 p.m. UTC | #1 
On Thu, Oct 12, 2023 at 04:10:31PM +0200, Borislav Petkov wrote:
> On Tue, Oct 10, 2023 at 01:41:19PM -0700, Josh Poimboeuf wrote:
> > Even if it's not a security hole, I'd still view it as a major BUG() as
> > it would directly contradict our understanding (and the comments above)
> > and could cause performance or other correctness issues that would
> > otherwise go unnoticed.
> > 
> > So I think an unconditional UD2 is warranted.
> 
> Before David's outlook mangles v2, lemme send it from a real mail
> client :-P.
> 
> v2 uses X86_FEATURE_ALWAYS as Josh requested.
> 
> ---
> From: David Kaplan <david.kaplan@amd.com>
> Date: Thu, 12 Oct 2023 08:52:32 -0500
> Subject: [PATCH] x86/retpoline: Ensure default return thunk isn't used at runtime
> 
> All CPU bugs that require a return thunk define a special return thunk
> to use (e.g., srso_return_thunk).  The default thunk,
> __x86_return_thunk, should never be used after apply_returns()
> completes.  Otherwise this could lead to potential speculation holes.
> 
> Enforce this by replacing this thunk with a ud2 when alternatives are
> applied.  Alternative instructions are applied after apply_returns().
> 
> The default thunk is only used during kernel boot, it is not used during
> module init since that occurs after apply_returns().
> 
> Signed-off-by: David Kaplan <david.kaplan@amd.com>
> Signed-off-by: Borislav Petkov (AMD) <bp@alien8.de>

Reviewed-by: Josh Poimboeuf <jpoimboe@kernel.org>
diff mbox series

Patch

diff --git a/arch/x86/lib/retpoline.S b/arch/x86/lib/retpoline.S
index db813113e637..3f3a478b74dd 100644
--- a/arch/x86/lib/retpoline.S
+++ b/arch/x86/lib/retpoline.S
@@ -356,15 +356,17 @@  SYM_FUNC_END(call_depth_return_thunk)
  * This function name is magical and is used by -mfunction-return=thunk-extern
  * for the compiler to generate JMPs to it.
  *
- * This code is only used during kernel boot or module init.  All
+ * This code is only used during kernel boot.  All
  * 'JMP __x86_return_thunk' sites are changed to something else by
  * apply_returns().
+ *
+ * This thunk is turned into a ud2 to ensure it is never used at runtime.
+ * Alternative instructions are applied after apply_returns().
  */
 SYM_CODE_START(__x86_return_thunk)
 	UNWIND_HINT_FUNC
 	ANNOTATE_NOENDBR
-	ANNOTATE_UNRET_SAFE
-	ret
+	ALTERNATIVE __stringify(ANNOTATE_UNRET_SAFE;ret),"ud2", X86_FEATURE_ALWAYS
 	int3
 SYM_CODE_END(__x86_return_thunk)
 EXPORT_SYMBOL(__x86_return_thunk)