From patchwork Thu Oct 12 11:46:07 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Benjamin Gaignard X-Patchwork-Id: 151960 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:612c:2908:b0:403:3b70:6f57 with SMTP id ib8csp1165135vqb; Thu, 12 Oct 2023 04:48:21 -0700 (PDT) X-Google-Smtp-Source: AGHT+IH2hmu4YL2g235uwvzdVjztXXg5bczhRnEzFO4J1ms/hQYRueZiP7fyjqSBgvDl2x15hRou X-Received: by 2002:a05:6830:63c2:b0:6bc:a824:2750 with SMTP id ci2-20020a05683063c200b006bca8242750mr21017904otb.2.1697111301108; Thu, 12 Oct 2023 04:48:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697111301; cv=none; d=google.com; s=arc-20160816; b=ML8qMNaamPx2d2Mat3WIT/llVdnu6DuTYIdsFVsBfupUPHVcIQ0TIAsKZww32DrmtY h+3ApZVucZzJ2vZMFqVb+IQ2h1zWUFCCfKDxrwyjZPUL3L0CumC8Tk3ucJUaxTS2Kppb IiNAuieNOspVfvmMot9w6qWhUzXgGVL7TFlSfvJE279++6OPi4DOq1EX/SBkQGlKD5lu 4KESYeMuHDBH9lhP5+V6iDIX+PgsMmKj50BmSShZ3CQXPQOgJ2AA7DJnv7VRMWbU2gnq hSrfQGaxFzFmyVbjoTaImCneSGQ2ymlAtY9kCd7Cc4uhpyqyhfr6370E7ohMBrvckKbz rwSg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=9xb2HxFyj1VWE4LL8F6mZIXiQjdsk4zJ01SDd/HcuPw=; fh=nyy6kl3x7bvRns0O2iGfKgaQnRSGFqx2aqkUiW72Nok=; b=SrtvD1dOGmv6epkzZuNC/F0Dbt/UqmcqsughyMIZTOlT15U1xJX9ytXakUv65YdOLn lxuU9cFUO7FUUBC8DjlhugjAZKtPmq14B9Dc5cgT35dSmnD1Ul0yi5r+pVpmkSt+KLui mYWAejtFXEyihn9icZV+pSCOKHicEPS9Wr3bZHk/vzFQNH+k+fkdz42JQgpKVwhXGYlg IhzsDArUDmSv4/7LXdPaCTsyvGMu63QwDSgiOkyOKf18IMF4puSWNdFbH2LooPFKJCJ1 qFy4vic995Aeft021l44gLs+JMTRtmdp/77xRd5jeDv8fHGY62yLTfSmEzTlQhxqev+F moCw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=Ikpsd6wm; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id i194-20020a636dcb000000b00588fa0def2asi2089047pgc.778.2023.10.12.04.48.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Oct 2023 04:48:21 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=Ikpsd6wm; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 24024822CD4E; Thu, 12 Oct 2023 04:48:20 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1379211AbjJLLsN (ORCPT + 19 others); Thu, 12 Oct 2023 07:48:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49618 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1378557AbjJLLrL (ORCPT ); Thu, 12 Oct 2023 07:47:11 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 15545F1; Thu, 12 Oct 2023 04:47:02 -0700 (PDT) Received: from benjamin-XPS-13-9310.. (unknown [IPv6:2a01:e0a:120:3210:7ae7:b86d:c19a:877e]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: benjamin.gaignard) by madras.collabora.co.uk (Postfix) with ESMTPSA id 87F366607371; Thu, 12 Oct 2023 12:47:00 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1697111220; bh=Jt1mNMm36fegL/wBY23liBF0ngeSMzYwFlorrhK5AKs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Ikpsd6wm0YYrF8nGwJim6Sv46Xxi4+ScsUHZDGZGFg11Xq2SIcNnZJuk8JxZjYeis 1dDxmHOF/e9SWZ2vztz3EwGYkBzKS253R+V/+GwZ2hWFFsD93tg2yIctLbvp0BeXcv BGYfejgSuF20/iraRJ/0RSvSu5UBlJHtf0zjg5kyeA7bTHO1piM1KbtvRCpHMaT+qV CQQcxvHf/hi49UYNaT/ndwxI53687YmNz08aGpUbvHR1txfHCs8KfZQvXSofhTjT5E uR9MpIn01HNnQiYlZ9l9CkBIdPtUDlyqK5CShCdD4Mzgiz/BXMOwaUjYClBjruaA8A r0IVcbFWDbhlg== From: Benjamin Gaignard To: mchehab@kernel.org, tfiga@chromium.org, m.szyprowski@samsung.com, ming.qian@nxp.com, ezequiel@vanguardiasur.com.ar, p.zabel@pengutronix.de, gregkh@linuxfoundation.org, hverkuil-cisco@xs4all.nl, nicolas.dufresne@collabora.com Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-staging@lists.linux.dev, kernel@collabora.com, Benjamin Gaignard , Matt Ranostay Subject: [PATCH v11 21/56] media: video-i2c: Set min_buffers_needed to 2 Date: Thu, 12 Oct 2023 13:46:07 +0200 Message-Id: <20231012114642.19040-22-benjamin.gaignard@collabora.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20231012114642.19040-1-benjamin.gaignard@collabora.com> References: <20231012114642.19040-1-benjamin.gaignard@collabora.com> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Thu, 12 Oct 2023 04:48:20 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1779550179681603493 X-GMAIL-MSGID: 1779550179681603493 vb2 queue_setup checks for a minimum number of buffers so set min_buffers_needed to 2 and remove the useless check in video-i2c queue_setup(). Signed-off-by: Benjamin Gaignard CC: Matt Ranostay --- drivers/media/i2c/video-i2c.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/media/i2c/video-i2c.c b/drivers/media/i2c/video-i2c.c index 178bd06cc2ed..0a38b9614764 100644 --- a/drivers/media/i2c/video-i2c.c +++ b/drivers/media/i2c/video-i2c.c @@ -406,9 +406,6 @@ static int queue_setup(struct vb2_queue *vq, struct video_i2c_data *data = vb2_get_drv_priv(vq); unsigned int size = data->chip->buffer_size; - if (vq->num_buffers + *nbuffers < 2) - *nbuffers = 2; - if (*nplanes) return sizes[0] < size ? -EINVAL : 0; @@ -794,7 +791,7 @@ static int video_i2c_probe(struct i2c_client *client) queue->timestamp_flags = V4L2_BUF_FLAG_TIMESTAMP_MONOTONIC; queue->drv_priv = data; queue->buf_struct_size = sizeof(struct video_i2c_buffer); - queue->min_buffers_needed = 1; + queue->min_buffers_needed = 2; queue->ops = &video_i2c_video_qops; queue->mem_ops = &vb2_vmalloc_memops;