Message ID | 20231011202638.372382-4-andriy.shevchenko@linux.intel.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:612c:2908:b0:403:3b70:6f57 with SMTP id ib8csp795141vqb; Wed, 11 Oct 2023 13:27:05 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHqbuefUn92hygKqwmVqL0wpapyUk5lr6U4iobv0lkCSJllWZw8QqzGL8SowSPlpwPM0Tsj X-Received: by 2002:a17:90b:4f4d:b0:27d:9b6:ec1b with SMTP id pj13-20020a17090b4f4d00b0027d09b6ec1bmr2294694pjb.4.1697056025442; Wed, 11 Oct 2023 13:27:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697056025; cv=none; d=google.com; s=arc-20160816; b=qULcgEZ2AT0UAZ9ksCaDizvmolJJ+Pd0tptNZPdXGXEFSknV8G5cbwHDDiKH3FX95W qT3co4MjD/UOkbV5+NVHY/d3voyD+R6pVoqkNwhLAAIy7C8k1jL31AQ2urdB4B2glTHK mJepiSw7gxnW7r4w7A1Hk8NjyEl3MpfKUYKVPsTfkPWhrRj2gdvAuqb2TJl91K+uSNoU Ptt259noFuuA/MawPkPikOzmQKzxuPtieas1iFOVaRzNowetze90006ErzpKDZo5z9Ki OSoHy5UeYvoV63GDlK+sg4Bo/giWtH/AIO4UqHA+yy6Pi1VM3ucRq/XzRHoAO0Fess93 RebA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=f23EjPvQjxdKJdZD6jFI1wUlR852YRhURxPUBJGAbcY=; fh=RAF7KyPAfJnoj7VNMZqcV/N9L3IgTT6Eds+WXuPmNQA=; b=Om5q+bR8fb5K82bJ38La1r1mogA7zl9mmoXvJXbmGzJYGFulKL443BuQQNlfW+fTnc 9/6Yd0m0HcTvjETOb4a/ST+EZyc5d6StGfOAel6pM2RpqJpo2X3xkOt4qV+ibg4GBFLI viLuk0QmpNuv4pzlPMow/60fb4qZUYPiv1xETW72VoG0nos4T1dGch8zW7yHVLs7WmXQ VmwFdbMp5dRts19uoMYTf0xT0HndLi/Whpcw7dgZo9D6MeintwFNuWeor5dgD3QU2UKH zjQFNVVzQ+q4Z0NSC/gz0YGoyrf3GnRZsCpkSOi9sGcRllZb0U14X47+2/zA9neHcKcL IF2g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=PbGQqUkC; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from lipwig.vger.email (lipwig.vger.email. [23.128.96.33]) by mx.google.com with ESMTPS id mu10-20020a17090b388a00b0027b436159b0si684989pjb.165.2023.10.11.13.27.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Oct 2023 13:27:05 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=PbGQqUkC; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id D5F058184524; Wed, 11 Oct 2023 13:26:59 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1376362AbjJKU0t (ORCPT <rfc822;kartikey406@gmail.com> + 18 others); Wed, 11 Oct 2023 16:26:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54930 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233360AbjJKU0s (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Wed, 11 Oct 2023 16:26:48 -0400 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2533290; Wed, 11 Oct 2023 13:26:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1697056007; x=1728592007; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=ZRhu6GBogXEtacyQpk9MfPzZjieYt+h/X2GsbW/ugqU=; b=PbGQqUkCHfWl/z39Hmo2Pe/omc4YEB2mtpxEjtTP8w66A2mqWcIEG1H4 VPujcZH1QHdTrRcImoQXkhKo0NwITKDjhAmv+X0TIYDVj79i5dcEAHsTF KQYXvGP+IZ61Y+u82ZMtVJeHEG6w4eoEZuEAPNNDpcndvo/Pp5aAY8a0G D6AIeBQJnUOBnQrRPA1IUQn3dzCdXsUWWtbZGPhKtAR3rGQkFwNJhniVm LzRf9sRj2FrLL2CuH1XR0+aqXYf0e5H3f0lw287mearjip1T2+gMtdW0d sY3RIpJekKDOC2/Cx1OQNabSKbyEiq0zptK4Q1hE7+cIhRqru8s0ZyB0U Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10860"; a="471015120" X-IronPort-AV: E=Sophos;i="6.03,217,1694761200"; d="scan'208";a="471015120" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Oct 2023 13:26:46 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10860"; a="783393503" X-IronPort-AV: E=Sophos;i="6.03,217,1694761200"; d="scan'208";a="783393503" Received: from black.fi.intel.com ([10.237.72.28]) by orsmga008.jf.intel.com with ESMTP; 11 Oct 2023 13:26:43 -0700 Received: by black.fi.intel.com (Postfix, from userid 1003) id 2C8766DA; Wed, 11 Oct 2023 23:26:42 +0300 (EEST) From: Andy Shevchenko <andriy.shevchenko@linux.intel.com> To: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>, Andy Shevchenko <andriy.shevchenko@linux.intel.com>, Linus Walleij <linus.walleij@linaro.org>, Dipen Patel <dipenp@nvidia.com>, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, timestamp@lists.linux.dev, linux-tegra@vger.kernel.org Cc: Bartosz Golaszewski <brgl@bgdev.pl>, Andy Shevchenko <andy@kernel.org>, Thierry Reding <thierry.reding@gmail.com>, Jonathan Hunter <jonathanh@nvidia.com> Subject: [PATCH v2 3/4] hte: tegra194: Remove redundant dev_err() Date: Wed, 11 Oct 2023 23:26:37 +0300 Message-Id: <20231011202638.372382-4-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.40.0.1.gaa8946217a0b In-Reply-To: <20231011202638.372382-1-andriy.shevchenko@linux.intel.com> References: <20231011202638.372382-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=2.8 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Wed, 11 Oct 2023 13:26:59 -0700 (PDT) X-Spam-Level: ** X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1779492218706801510 X-GMAIL-MSGID: 1779492218706801510 |
Series | hte: Improve GPIO handling and other cleanups | |
Commit Message
Andy Shevchenko
Oct. 11, 2023, 8:26 p.m. UTC
There is no need to call the dev_err() function directly to print a custom message when handling an error from platform_get_irq() function as it is going to display an appropriate error message in case of a failure. Reviewed-by: Dipen Patel <dipenp@nvidia.com> Tested-by: Dipen Patel <dipenp@nvidia.com> Reviewed-by: Linus Walleij <linus.walleij@linaro.org> Link: https://lore.kernel.org/r/20231010151709.4104747-4-andriy.shevchenko@linux.intel.com Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> --- drivers/hte/hte-tegra194.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/hte/hte-tegra194.c b/drivers/hte/hte-tegra194.c index f6c2dbcd0aca..cf6058193403 100644 --- a/drivers/hte/hte-tegra194.c +++ b/drivers/hte/hte-tegra194.c @@ -731,10 +731,8 @@ static int tegra_hte_probe(struct platform_device *pdev) return -ENOMEM; ret = platform_get_irq(pdev, 0); - if (ret < 0) { - dev_err_probe(dev, ret, "failed to get irq\n"); + if (ret < 0) return ret; - } hte_dev->hte_irq = ret; ret = devm_request_irq(dev, hte_dev->hte_irq, tegra_hte_isr, 0, dev_name(dev), hte_dev);