| Message ID | 20231011164654.3671490-1-florian.fainelli@broadcom.com |
|---|---|
| State | New |
| Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org>
Delivered-To: ouuuleilei@gmail.com
Received: by 2002:a05:612c:2908:b0:403:3b70:6f57 with SMTP id ib8csp674486vqb;
Wed, 11 Oct 2023 09:48:08 -0700 (PDT)
X-Google-Smtp-Source:
AGHT+IEkfisMCcZ2ZnCqOo/3r/XVQRcKR2gfCoFBhipVrl8GH+H5pvwOGYWQClFrNx6rC87lDvUt
X-Received: by 2002:a05:6a20:1595:b0:163:ab09:195d with SMTP id
h21-20020a056a20159500b00163ab09195dmr25214896pzj.0.1697042888029;
Wed, 11 Oct 2023 09:48:08 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1697042888; cv=none;
d=google.com; s=arc-20160816;
b=X9IIS3Wn14bdIfBr0CIh82cID++eHijtmYVF13cPZUnLCkV5K8r2lICbvO4Fqsl9Rs
mMEp/gtunxw4WwLuuH5EcMOIZoxK6kN5nHfsCmEr/6h+jPcpDz6h6hG98g0chQNYmwm8
//F2FH8b4aq2AyAZ/Iv9FwRUIX726aAMalyEXOKTM3+I0El5zmxNc/+YqP3zu+6/8nnf
ODJLH7rWB8IB9zs10qQqvaLZWk20/nBegjpeudtdkxanxyvg0uR1+yATvACxbTyZxSaM
CPt9u0mDTRvuy3LiRnk85Ezq/ZOQCA4sDTkpcqCyise0A+1kPTkTCONv3tUqyxREetlR
NHyQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20160816;
h=list-id:precedence:mime-version:message-id:date:subject:cc:to:from
:dkim-signature;
bh=mwphwJ0xRX9CGg4Oi1EVpr8BiUCJg2jkSbjz0oMtEGQ=;
fh=lS6ijhR4+YgfdFdeiCM+rzv9QBV1aiZWFNQJVTz/t+A=;
b=LKnaqULrX5lsMSBSU8+hxwbFBJ4o6NzWycBX7X3+9D/mzXxWQNc5V+LVjh/nGHSD7a
miT/lyQBWk0ao0fa3DYCmDC+fLs4RTwglKnfz+tV/c/dQVTFl38EgFFBClmXB7vSweBn
ntZJ3qb3EZU2v3REiyGHuto0+N8nTHyY/w1GY1mV/8d+AMp4wTFEx+7F52hJ7lXJ0ND4
yG/9m+nkIXvZYGWZ70OZVAN+qDkrCmUX36lArdqctDX+Ka8VGvtRurKVHz3ivBx0+tE7
TvsRU5rAyvTCNDPZnk+9Qu/Uv0ryQK9h6FtRwkRpJL5Z0B3TTA8XZgyNGJ8Q5jKCbbz3
hNPg==
ARC-Authentication-Results: i=1; mx.google.com;
dkim=pass header.i=@broadcom.com header.s=google header.b=KcoZorBw;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::3:5 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE)
header.from=broadcom.com
Received: from groat.vger.email (groat.vger.email. [2620:137:e000::3:5])
by mx.google.com with ESMTPS id
j62-20020a638b41000000b0057755c96163si180775pge.14.2023.10.11.09.48.07
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Wed, 11 Oct 2023 09:48:07 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::3:5 as permitted sender)
client-ip=2620:137:e000::3:5;
Authentication-Results: mx.google.com;
dkim=pass header.i=@broadcom.com header.s=google header.b=KcoZorBw;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::3:5 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE)
header.from=broadcom.com
Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0])
by groat.vger.email (Postfix) with ESMTP id A82FE8052BFB;
Wed, 11 Oct 2023 09:48:04 -0700 (PDT)
X-Virus-Status: Clean
X-Virus-Scanned: clamav-milter 0.103.10 at groat.vger.email
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
id S233000AbjJKQrw (ORCPT <rfc822;kartikey406@gmail.com>
+ 18 others); Wed, 11 Oct 2023 12:47:52 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35366 "EHLO
lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
with ESMTP id S230292AbjJKQru (ORCPT
<rfc822;linux-kernel@vger.kernel.org>);
Wed, 11 Oct 2023 12:47:50 -0400
Received: from mail-qk1-x730.google.com (mail-qk1-x730.google.com
[IPv6:2607:f8b0:4864:20::730])
by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0FA1C98
for <linux-kernel@vger.kernel.org>;
Wed, 11 Oct 2023 09:47:48 -0700 (PDT)
Received: by mail-qk1-x730.google.com with SMTP id
af79cd13be357-77063481352so101306685a.1
for <linux-kernel@vger.kernel.org>;
Wed, 11 Oct 2023 09:47:48 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=broadcom.com; s=google; t=1697042867; x=1697647667;
darn=vger.kernel.org;
h=mime-version:message-id:date:subject:cc:to:from:from:to:cc:subject
:date:message-id:reply-to;
bh=mwphwJ0xRX9CGg4Oi1EVpr8BiUCJg2jkSbjz0oMtEGQ=;
b=KcoZorBwHNLgJLJr0qCE13UsevUp3t4LX5Q87BrquVAm7C+EfS2MpFnEohhnL3JiRR
qIE3NNuuGwBZsCFMgCE0VJhKeGFeB9Y99+N3dcc5qjQkvkfqaqGPOnEborKqhrHO/o2X
ALmn5FyD4tve1kVfM5KN0uQAvZH3caX5x4WAo=
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1697042867; x=1697647667;
h=mime-version:message-id:date:subject:cc:to:from:x-gm-message-state
:from:to:cc:subject:date:message-id:reply-to;
bh=mwphwJ0xRX9CGg4Oi1EVpr8BiUCJg2jkSbjz0oMtEGQ=;
b=YQu4uiIDLpOD5DIXHoFvEzYsLA55PkQt+sVRTOnnlZqdwJGPIyoQmni2tgTiadgMjm
70oW38Mb3FlMR10FSzYvDEtyd5NdTl0iZoh8lDLgpWGB8NRnmwI3ny/CJGox7jrZW6cJ
cVj9lOlpNfQfWeQeP1xUkoFjcUDy9hfaVkujW0vapShyDQOxKaBUxA2Az90FGui5Gx3N
iMVZexFmOh0ypnjapc42VTLg54sN9DVgOrv+LpWX/Fv9ZLxY56I+3IRO2OwG1BDHbv/i
o3HMXVblTIagc98eLp7+ZayM3/SY3zxXESt2mZP/ddayYV9Xmmyfb3QCpiePrOFaz9uW
rR0Q==
X-Gm-Message-State: AOJu0YwQmTBnd5Akk+KiJS9t2hdQbYSiIgJQtUS8gmr4Bw2teHPRuCdY
a2iZuu16lEJCAZiymVRPRmNa6I/OFV/OG+QXng1Y09pzg3O2IkkdUSWaGmumAOHM/O1YuXYtMPn
Hs41nWSfLi1aK2eDYhkabeCvp2oiP72tZXFXB4zNaevwHvPTTD18+l/t79IQZ7JJyqmVUCS9pob
79rRDmMF/6So3T+hgrWg==
X-Received: by 2002:a05:620a:c45:b0:76c:b7f0:2bc9 with SMTP id
u5-20020a05620a0c4500b0076cb7f02bc9mr26509977qki.16.1697042866716;
Wed, 11 Oct 2023 09:47:46 -0700 (PDT)
Received: from fainelli-desktop.igp.broadcom.net ([192.19.223.252])
by smtp.gmail.com with ESMTPSA id
c24-20020a05620a11b800b0076ee973b9a7sm5357492qkk.27.2023.10.11.09.47.45
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Wed, 11 Oct 2023 09:47:46 -0700 (PDT)
From: Florian Fainelli <florian.fainelli@broadcom.com>
To: linux-kernel@vger.kernel.org
Cc: mmayer@broadcom.com,
Florian Fainelli <florian.fainelli@broadcom.com>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Viresh Kumar <viresh.kumar@linaro.org>,
linux-pm@vger.kernel.org (open list:CPU FREQUENCY SCALING FRAMEWORK)
Subject: [PATCH v2] cpufreq: ARM_BRCMSTB_AVS_CPUFREQ cannot be used with
ARM_SCMI_CPUFREQ
Date: Wed, 11 Oct 2023 09:46:54 -0700
Message-Id: <20231011164654.3671490-1-florian.fainelli@broadcom.com>
X-Mailer: git-send-email 2.34.1
MIME-Version: 1.0
Content-Type: multipart/signed; protocol="application/pkcs7-signature";
micalg=sha-256;
boundary="000000000000430463060773955b"
X-Spam-Status: No, score=3.7 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
MAILING_LIST_MULTI,MIME_NO_TEXT,RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_PASS,
URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test,
not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]);
Wed, 11 Oct 2023 09:48:04 -0700 (PDT)
X-Spam-Level: ***
X-getmail-retrieved-from-mailbox: INBOX
X-GMAIL-THRID: 1779478443260862816
X-GMAIL-MSGID: 1779478443260862816
|
| Series |
[v2] cpufreq: ARM_BRCMSTB_AVS_CPUFREQ cannot be used with ARM_SCMI_CPUFREQ
|
|
Commit Message
Florian Fainelli
Oct. 11, 2023, 4:46 p.m. UTC
The brcmstb-avs-cpufreq driver is considered a legacy driver and since
2018, ARCH_BRCMSTB systems have been using scmi-cpufreq. As a matter of
fact, when SCMI is in use, brcmstb-avs-cpufreq is unusable since the
SCMI firmware takes over, this can result in various problems, including
external synchronous aborts.
Express those constraints such that the driver is not enabled by default
when SCMI CPU frequency scaling is in use.
Signed-off-by: Florian Fainelli <florian.fainelli@broadcom.com>
---
Changes in v2:
- address Viresh's feedback and reduce the depdendency to
!ARM_SCMI_CPUFREQ
drivers/cpufreq/Kconfig.arm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
On 11-10-23, 09:46, Florian Fainelli wrote: > The brcmstb-avs-cpufreq driver is considered a legacy driver and since > 2018, ARCH_BRCMSTB systems have been using scmi-cpufreq. As a matter of > fact, when SCMI is in use, brcmstb-avs-cpufreq is unusable since the > SCMI firmware takes over, this can result in various problems, including > external synchronous aborts. > > Express those constraints such that the driver is not enabled by default > when SCMI CPU frequency scaling is in use. > > Signed-off-by: Florian Fainelli <florian.fainelli@broadcom.com> > --- > Changes in v2: > > - address Viresh's feedback and reduce the depdendency to > !ARM_SCMI_CPUFREQ > > drivers/cpufreq/Kconfig.arm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/cpufreq/Kconfig.arm b/drivers/cpufreq/Kconfig.arm > index 123b4bbfcfee..207618043ee0 100644 > --- a/drivers/cpufreq/Kconfig.arm > +++ b/drivers/cpufreq/Kconfig.arm > @@ -90,7 +90,7 @@ config ARM_VEXPRESS_SPC_CPUFREQ > > config ARM_BRCMSTB_AVS_CPUFREQ > tristate "Broadcom STB AVS CPUfreq driver" > - depends on ARCH_BRCMSTB || COMPILE_TEST > + depends on (ARCH_BRCMSTB && !ARM_SCMI_CPUFREQ) || COMPILE_TEST > default y > help > Some Broadcom STB SoCs use a co-processor running proprietary firmware Applied. Thanks.
diff --git a/drivers/cpufreq/Kconfig.arm b/drivers/cpufreq/Kconfig.arm index 123b4bbfcfee..207618043ee0 100644 --- a/drivers/cpufreq/Kconfig.arm +++ b/drivers/cpufreq/Kconfig.arm @@ -90,7 +90,7 @@ config ARM_VEXPRESS_SPC_CPUFREQ config ARM_BRCMSTB_AVS_CPUFREQ tristate "Broadcom STB AVS CPUfreq driver" - depends on ARCH_BRCMSTB || COMPILE_TEST + depends on (ARCH_BRCMSTB && !ARM_SCMI_CPUFREQ) || COMPILE_TEST default y help Some Broadcom STB SoCs use a co-processor running proprietary firmware