Message ID | 20231010151709.4104747-5-andriy.shevchenko@linux.intel.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:612c:2908:b0:403:3b70:6f57 with SMTP id ib8csp278421vqb; Tue, 10 Oct 2023 08:17:40 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGNdH2+QhBwjVdEiWzdc3VcexWXKXA6ni9T2DqBRP7VkTQVOG5r7kcGF6qXWmaGEIk6GbIe X-Received: by 2002:a05:6a20:5490:b0:13d:8876:4c97 with SMTP id i16-20020a056a20549000b0013d88764c97mr19636036pzk.16.1696951060479; Tue, 10 Oct 2023 08:17:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696951060; cv=none; d=google.com; s=arc-20160816; b=z5YND71Pg8h4Oq4C1gW9wLiBcssHRGTMRuhws8zX4YO5n/yTCMx4DBlkadTpHPfXH6 CZKQhfdmnfpPUUovuj7WuO5UDRFYhRB3BFO2COEG6X7PTkASLh3VTOQs3xZwLuPUeqmR 5Y+0O/CQ1DZTUbrfGwtlSkqXdC789qQDw7ooPpT9qwNBCBbEm9pX5j7rG6TCJ2CbyH+e XI6nvRcsc/chVoEBt32Kv01isnSmQc3Fo/Fda/nkCZOHTodHZ5m3Stc+/AVEoTSH3Po0 tslgFNf2Jk95yzhAiOV1iU1ocGtGHlu4RXFeDz/DrDEe5LRuZg9vrKxSHaXfHj+0euF1 XRZw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=qLovOSMQCMNriOppPoSFCXk+WVTACTIUEZgc+4hbwfM=; fh=Pmv/3wCd/vMMkz6ztZZNrSYr82TrxG1l8ka93ZTHWP8=; b=yP155+AynUk3CqZsLDGFi6ebzsGVlh5j4m+Bjkcu3hmCfCVZmZE+NeFtE4PbX1Vugl p7xrbmCsMkFuB1XuNnf05qp3dElk2qH6v/IwZKNplF8T1hxQOiBQMexthJkRx/YV4di1 jrXLjqabeCgu/V76exepb32/EBbeFU/4hnZNMxpX2UB3+H6LUjLbkR1nxRkeRzu6JFNj +ompCrk6Ln1nV4rtrbAKFaNlDCX0ayiTqKYm10i7s+OlCGu+5IbTnrG5QQRtZyNl9MXM oXkWSJtOr/urPC6VzH71XbG9FYpufUJfnbMakCDe2+6V9W1EEoEf6QeLx/qEAl1JOk7W bZXg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=LsU22sFT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from agentk.vger.email (agentk.vger.email. [2620:137:e000::3:2]) by mx.google.com with ESMTPS id dw25-20020a056a00369900b00693366c707fsi9936536pfb.299.2023.10.10.08.17.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Oct 2023 08:17:40 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=LsU22sFT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id 9DDAA8023A26; Tue, 10 Oct 2023 08:17:34 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232859AbjJJPRS (ORCPT <rfc822;rua109.linux@gmail.com> + 20 others); Tue, 10 Oct 2023 11:17:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59620 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232667AbjJJPRQ (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Tue, 10 Oct 2023 11:17:16 -0400 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0F780B0; Tue, 10 Oct 2023 08:17:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1696951035; x=1728487035; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=b+eQ/uwdz+URzIJFW2ABqaZbfeJbxTuJSgGGfs7US3E=; b=LsU22sFTfH8FUie4sWiAbw/3z91MMYKZPy5IxgvFFZLr4QYBFQNrdViS VOC7a0gTtM6F33qpsnY17vr0oZPBte9ig6DnKrdLighZTSLvKT3Z/UR4D 9ucQdg09FGp3mjMGSbDKdErP61Ld4RRR0yZbvRJ3bDKzObfuC91/vTzTJ 2a6Vc/946DuDI3oBAEB+138JSzq2jpr1rTSRwaW8uCUbXQDRDyOiZzn5t gtiGdq0peMJmLvXhcE5HY8sHxjUSpQ9h3OD/9c1eiylrSs3FzdX3SByND uoDGIKhpMg3YT7Tgi/uMFE/nPrrlVt9vlTpE5gHpFsoD5uG06JCDwS034 Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10859"; a="363771580" X-IronPort-AV: E=Sophos;i="6.03,213,1694761200"; d="scan'208";a="363771580" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Oct 2023 08:17:14 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10859"; a="823812775" X-IronPort-AV: E=Sophos;i="6.03,213,1694761200"; d="scan'208";a="823812775" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga004.fm.intel.com with ESMTP; 10 Oct 2023 08:17:11 -0700 Received: by black.fi.intel.com (Postfix, from userid 1003) id 524C671B; Tue, 10 Oct 2023 18:17:10 +0300 (EEST) From: Andy Shevchenko <andriy.shevchenko@linux.intel.com> To: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>, Andy Shevchenko <andriy.shevchenko@linux.intel.com>, Dipen Patel <dipenp@nvidia.com>, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, timestamp@lists.linux.dev, linux-tegra@vger.kernel.org Cc: Linus Walleij <linus.walleij@linaro.org>, Bartosz Golaszewski <brgl@bgdev.pl>, Andy Shevchenko <andy@kernel.org>, Thierry Reding <thierry.reding@gmail.com>, Jonathan Hunter <jonathanh@nvidia.com> Subject: [PATCH v1 4/4] hte: tegra194: Switch to LATE_SIMPLE_DEV_PM_OPS() Date: Tue, 10 Oct 2023 18:17:09 +0300 Message-Id: <20231010151709.4104747-5-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.40.0.1.gaa8946217a0b In-Reply-To: <20231010151709.4104747-1-andriy.shevchenko@linux.intel.com> References: <20231010151709.4104747-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=2.8 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Tue, 10 Oct 2023 08:17:34 -0700 (PDT) X-Spam-Level: ** X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1779382154804418402 X-GMAIL-MSGID: 1779382154804418402 |
Series |
hte: Improve GPIO handling and other cleanups
|
|
Commit Message
Andy Shevchenko
Oct. 10, 2023, 3:17 p.m. UTC
SET_LATE_SYSTEM_SLEEP_PM_OPS is deprecated, replace it with
LATE_SYSTEM_SLEEP_PM_OPS() and use pm_sleep_ptr() for setting
the driver's pm routines. We can now remove the __maybe_unused
qualifier in the suspend and resume functions.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/hte/hte-tegra194.c | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)
Comments
On 10/10/23 8:17 AM, Andy Shevchenko wrote: > SET_LATE_SYSTEM_SLEEP_PM_OPS is deprecated, replace it with > LATE_SYSTEM_SLEEP_PM_OPS() and use pm_sleep_ptr() for setting > the driver's pm routines. We can now remove the __maybe_unused > qualifier in the suspend and resume functions. > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > --- > drivers/hte/hte-tegra194.c | 9 ++++----- > 1 file changed, 4 insertions(+), 5 deletions(-) > > diff --git a/drivers/hte/hte-tegra194.c b/drivers/hte/hte-tegra194.c > index 30ef1750a9fa..30fa7c0a555e 100644 > --- a/drivers/hte/hte-tegra194.c > +++ b/drivers/hte/hte-tegra194.c > @@ -815,7 +815,7 @@ static int tegra_hte_probe(struct platform_device *pdev) > return 0; > } > > -static int __maybe_unused tegra_hte_resume_early(struct device *dev) > +static int tegra_hte_resume_early(struct device *dev) > { > u32 i; > struct tegra_hte_soc *gs = dev_get_drvdata(dev); > @@ -836,7 +836,7 @@ static int __maybe_unused tegra_hte_resume_early(struct device *dev) > return 0; > } > > -static int __maybe_unused tegra_hte_suspend_late(struct device *dev) > +static int tegra_hte_suspend_late(struct device *dev) > { > u32 i; > struct tegra_hte_soc *gs = dev_get_drvdata(dev); > @@ -856,15 +856,14 @@ static int __maybe_unused tegra_hte_suspend_late(struct device *dev) > } > > static const struct dev_pm_ops tegra_hte_pm = { > - SET_LATE_SYSTEM_SLEEP_PM_OPS(tegra_hte_suspend_late, > - tegra_hte_resume_early) > + LATE_SYSTEM_SLEEP_PM_OPS(tegra_hte_suspend_late, tegra_hte_resume_early) > }; > > static struct platform_driver tegra_hte_driver = { > .probe = tegra_hte_probe, > .driver = { > .name = "tegra_hte", > - .pm = &tegra_hte_pm, > + .pm = pm_slee_ptr(&tegra_hte_pm), typo, pm_sleep_ptr instead? > .of_match_table = tegra_hte_of_match, > }, > };
On Tue, Oct 10, 2023 at 10:36 PM Dipen Patel <dipenp@nvidia.com> wrote: > On 10/10/23 8:17 AM, Andy Shevchenko wrote: > > + .pm = pm_slee_ptr(&tegra_hte_pm), > > typo, pm_sleep_ptr instead? Indeed. On my x86_64 this code slipped from compilation. I will try harder to compile-test it next time.
On 10/10/23 10:55 PM, Andy Shevchenko wrote: > On Tue, Oct 10, 2023 at 10:36 PM Dipen Patel <dipenp@nvidia.com> wrote: >> On 10/10/23 8:17 AM, Andy Shevchenko wrote: > >>> + .pm = pm_slee_ptr(&tegra_hte_pm), >> >> typo, pm_sleep_ptr instead? > > Indeed. On my x86_64 this code slipped from compilation. I will try > harder to compile-test it next time. > After manually correcting the error, Tested-by: Dipen Patel <dipenp@nvidia.com>
diff --git a/drivers/hte/hte-tegra194.c b/drivers/hte/hte-tegra194.c index 30ef1750a9fa..30fa7c0a555e 100644 --- a/drivers/hte/hte-tegra194.c +++ b/drivers/hte/hte-tegra194.c @@ -815,7 +815,7 @@ static int tegra_hte_probe(struct platform_device *pdev) return 0; } -static int __maybe_unused tegra_hte_resume_early(struct device *dev) +static int tegra_hte_resume_early(struct device *dev) { u32 i; struct tegra_hte_soc *gs = dev_get_drvdata(dev); @@ -836,7 +836,7 @@ static int __maybe_unused tegra_hte_resume_early(struct device *dev) return 0; } -static int __maybe_unused tegra_hte_suspend_late(struct device *dev) +static int tegra_hte_suspend_late(struct device *dev) { u32 i; struct tegra_hte_soc *gs = dev_get_drvdata(dev); @@ -856,15 +856,14 @@ static int __maybe_unused tegra_hte_suspend_late(struct device *dev) } static const struct dev_pm_ops tegra_hte_pm = { - SET_LATE_SYSTEM_SLEEP_PM_OPS(tegra_hte_suspend_late, - tegra_hte_resume_early) + LATE_SYSTEM_SLEEP_PM_OPS(tegra_hte_suspend_late, tegra_hte_resume_early) }; static struct platform_driver tegra_hte_driver = { .probe = tegra_hte_probe, .driver = { .name = "tegra_hte", - .pm = &tegra_hte_pm, + .pm = pm_slee_ptr(&tegra_hte_pm), .of_match_table = tegra_hte_of_match, }, };