[v1,1/3] regulator: dt-bindings: fixed-regulator: Add under-voltage interrupt support
Commit Message
Add under-voltage interrupt support. This can be used with simple
regulators having no other way to communicate an under-voltage event
except as by toggling some GPIO line.
Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
Comments
On Tue, Oct 10, 2023 at 10:59:04AM +0200, Oleksij Rempel wrote:
> Add under-voltage interrupt support. This can be used with simple
> regulators having no other way to communicate an under-voltage event
> except as by toggling some GPIO line.
This doesn't apply against current code, please check and resend.
On Tue, Oct 10, 2023 at 10:59:04AM +0200, Oleksij Rempel wrote:
> Add under-voltage interrupt support. This can be used with simple
> regulators having no other way to communicate an under-voltage event
> except as by toggling some GPIO line.
>
> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
>
> diff --git a/Documentation/devicetree/bindings/regulator/fixed-regulator.yaml b/Documentation/devicetree/bindings/regulator/fixed-regulator.yaml
> index ac0281b1cceb..0f8760ed2fb1 100644
> --- a/Documentation/devicetree/bindings/regulator/fixed-regulator.yaml
> +++ b/Documentation/devicetree/bindings/regulator/fixed-regulator.yaml
> @@ -100,6 +100,14 @@ properties:
> vin-supply:
> description: Input supply phandle.
>
> + interrupts:
> + maxItems: 1
> + description:
> + Under-voltage interrupt
> +
> + interrupt-names:
> + const: under-voltage
No need for a name. If there's ever a 2nd, it should be a specific
binding, not fixed-regulator.
> +
> required:
> - compatible
> - regulator-name
> ---
> .../devicetree/bindings/regulator/fixed-regulator.yaml | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/regulator/fixed-regulator.yaml b/Documentation/devicetree/bindings/regulator/fixed-regulator.yaml
> index ac0281b1cceb..0f8760ed2fb1 100644
> --- a/Documentation/devicetree/bindings/regulator/fixed-regulator.yaml
> +++ b/Documentation/devicetree/bindings/regulator/fixed-regulator.yaml
I think you've got some problems with your setup...
> @@ -100,6 +100,14 @@ properties:
> vin-supply:
> description: Input supply phandle.
>
> + interrupts:
> + maxItems: 1
> + description:
> + Under-voltage interrupt
> +
> + interrupt-names:
> + const: under-voltage
> +
> required:
> - compatible
> - regulator-name
> --
> 2.39.2
>
On Tue, 10 Oct 2023 10:59:04 +0200, Oleksij Rempel wrote:
> Add under-voltage interrupt support. This can be used with simple
> regulators having no other way to communicate an under-voltage event
> except as by toggling some GPIO line.
>
> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
>
> diff --git a/Documentation/devicetree/bindings/regulator/fixed-regulator.yaml b/Documentation/devicetree/bindings/regulator/fixed-regulator.yaml
> index ac0281b1cceb..0f8760ed2fb1 100644
> --- a/Documentation/devicetree/bindings/regulator/fixed-regulator.yaml
> +++ b/Documentation/devicetree/bindings/regulator/fixed-regulator.yaml
> @@ -100,6 +100,14 @@ properties:
> vin-supply:
> description: Input supply phandle.
>
> [...]
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-next
Thanks!
[1/3] regulator: dt-bindings: fixed-regulator: Add under-voltage interrupt support
commit: 0ab1dc9c657f30434ca55a3dcc87e624af0b2116
[2/3] regulator: fixed: add support for under-voltage IRQ
commit: ecb6f1f456144e9ade5a492192287decbeef4cfe
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
@@ -100,6 +100,14 @@ properties:
vin-supply:
description: Input supply phandle.
+ interrupts:
+ maxItems: 1
+ description:
+ Under-voltage interrupt
+
+ interrupt-names:
+ const: under-voltage
+
required:
- compatible
- regulator-name
---
.../devicetree/bindings/regulator/fixed-regulator.yaml | 8 ++++++++
1 file changed, 8 insertions(+)
@@ -100,6 +100,14 @@ properties:
vin-supply:
description: Input supply phandle.
+ interrupts:
+ maxItems: 1
+ description:
+ Under-voltage interrupt
+
+ interrupt-names:
+ const: under-voltage
+
required:
- compatible
- regulator-name