Message ID | 20231010005126.3425444-5-kieran.bingham@ideasonboard.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:a888:0:b0:403:3b70:6f57 with SMTP id x8csp2205035vqo; Mon, 9 Oct 2023 17:52:31 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFu2sZJ4upXnsUbBQ8ZpUe9sWjvvTOzyj1sXqSryVfLREGNWSE/NHYdFcChX+s8riHnzqzu X-Received: by 2002:a17:902:bd94:b0:1c5:bc83:557b with SMTP id q20-20020a170902bd9400b001c5bc83557bmr12960133pls.51.1696899150888; Mon, 09 Oct 2023 17:52:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696899150; cv=none; d=google.com; s=arc-20160816; b=jmRcjxqv5Xy1MTuxyD/bZX1PsRllaVhD7ywnzobWcVvIx4cCBKaO4KcT3+A6An6t6r 9gREZaaYSSAuDsyPXJ3TnwSJnQvMDHtuHUYPWgj4ny9FNf+brUWzmsMgWcJfYTTYHMXo 3gIFv0NNKHALlNW4qnXY3qQaCG/WC/Acvgn5DY7AXePyzKYpq6fgULS0oYtWhDxv8UVp ulg3StRYwy8HwxUgNXjDNU/pK/xFJcEkChWMSHPt60EV8MdyF3XQlQws8NHb8FS9ViLv v1KdVSJrAIL4ZMK7dwNpBtHHRj/oXt8mGLrcAjPOL/sReCgiAyMrydBNb3hhCFWjRm3j Bj6Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=A+jHWiY0otmijR8ARNJ3IA1ANTprjWNKtbNvj0UUJfg=; fh=KPPO4w/WNlKKcUme74fOJWAWFF+MJLt/bRW1ZZ7V1gk=; b=lZRG6OXcqSWGHxhDJGDUW5ybcxkMcQrUVT+FhglTSrlghNSoQwS7byXg5R4jeMT9uc 9K5PXAcarqhC9zR4SPqQa9mDp7UVEZvpK3Gc74t3L/sC/2tuJhCBz1wcZmF6EeLthUTP RdijlRzZx1mbYDDthVuqoir9Dn/bT48S05Izh0iasjud8U34aByH3c37J3hQiw5rvl1Y 92kNnfn5KT+5xe37WnckG5ob7+9lOnT89DBsZZwk3jPIDzS6sAB32CfDCOCoOZIj+fPw wdWqOJjjSB7AD60GIp1xanwcVDgA6kx0UCHwaXVbvUceS7datjVK6xR5+5i9w2QRZXqz vsKA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass (test mode) header.i=@ideasonboard.com header.s=mail header.b=MMyOMzOq; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from fry.vger.email (fry.vger.email. [2620:137:e000::3:8]) by mx.google.com with ESMTPS id jb18-20020a170903259200b001c5fc1f79f1si10270021plb.165.2023.10.09.17.52.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Oct 2023 17:52:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8; Authentication-Results: mx.google.com; dkim=pass (test mode) header.i=@ideasonboard.com header.s=mail header.b=MMyOMzOq; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by fry.vger.email (Postfix) with ESMTP id EBB458250DCE; Mon, 9 Oct 2023 17:52:28 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at fry.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1379305AbjJJAvs (ORCPT <rfc822;makky5685@gmail.com> + 18 others); Mon, 9 Oct 2023 20:51:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44994 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1379284AbjJJAvm (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Mon, 9 Oct 2023 20:51:42 -0400 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 40AAAB4; Mon, 9 Oct 2023 17:51:41 -0700 (PDT) Received: from Monstersaurus.local (aztw-30-b2-v4wan-166917-cust845.vm26.cable.virginm.net [82.37.23.78]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 2602BF0C; Tue, 10 Oct 2023 02:51:34 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1696899094; bh=gaWQ9+vNu5E0S40zJ98ILSdv6vdUDu9g/y/qreNcGv0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=MMyOMzOqmHBulm0ToE9kVYxEO0YjWXyclZnxFwBpvNai2AoxgaXGaOn1UazmDH3uo /n6a74k3N1f7D4IyxySQ/3j8lfu9nxJ1Nyf5q0n6+khaMBAR40bexMNdzM9erTdk5g NT0QettZzdL69NvhbjQAtKGIg7W/AgQf9M87Q3l8= From: Kieran Bingham <kieran.bingham@ideasonboard.com> To: linux-media@vger.kernel.org, devicetree@vger.kernel.org Cc: Kieran Bingham <kieran.bingham@ideasonboard.com>, "Paul J. Murphy" <paul.j.murphy@intel.com>, Daniele Alessandrelli <daniele.alessandrelli@intel.com>, Sakari Ailus <sakari.ailus@linux.intel.com>, Mauro Carvalho Chehab <mchehab@kernel.org>, linux-kernel@vger.kernel.org (open list) Subject: [PATCH 4/5] media: i2c: imx335: Fix hblank min/max values Date: Tue, 10 Oct 2023 01:51:25 +0100 Message-Id: <20231010005126.3425444-5-kieran.bingham@ideasonboard.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20231010005126.3425444-1-kieran.bingham@ideasonboard.com> References: <20231010005126.3425444-1-kieran.bingham@ideasonboard.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=2.7 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Mon, 09 Oct 2023 17:52:29 -0700 (PDT) X-Spam-Level: ** X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1779327724364518696 X-GMAIL-MSGID: 1779327724364518696 |
Series | [1/5] media: dt-bindings: media: imx335: Add supply bindings | |
Commit Message
Kieran Bingham
Oct. 10, 2023, 12:51 a.m. UTC
The V4L2_CID_HBLANK control is marked as readonly and can only be a
single value.
Set the minimum and maximum value to match the mode value.
Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
---
drivers/media/i2c/imx335.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Comments
Hi Kieran On 10/10/23 6:21 AM, Kieran Bingham wrote: > The V4L2_CID_HBLANK control is marked as readonly and can only be a > single value. > > Set the minimum and maximum value to match the mode value. > > Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com> Reviewed-by: Umang Jain <umang.jain@ideasonboard.com> > --- > drivers/media/i2c/imx335.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/media/i2c/imx335.c b/drivers/media/i2c/imx335.c > index 026777eb362e..1a34b2a43718 100644 > --- a/drivers/media/i2c/imx335.c > +++ b/drivers/media/i2c/imx335.c > @@ -1043,8 +1043,8 @@ static int imx335_init_controls(struct imx335 *imx335) > imx335->hblank_ctrl = v4l2_ctrl_new_std(ctrl_hdlr, > &imx335_ctrl_ops, > V4L2_CID_HBLANK, > - IMX335_REG_MIN, > - IMX335_REG_MAX, > + mode->hblank, > + mode->hblank, > 1, mode->hblank); > if (imx335->hblank_ctrl) > imx335->hblank_ctrl->flags |= V4L2_CTRL_FLAG_READ_ONLY;
diff --git a/drivers/media/i2c/imx335.c b/drivers/media/i2c/imx335.c index 026777eb362e..1a34b2a43718 100644 --- a/drivers/media/i2c/imx335.c +++ b/drivers/media/i2c/imx335.c @@ -1043,8 +1043,8 @@ static int imx335_init_controls(struct imx335 *imx335) imx335->hblank_ctrl = v4l2_ctrl_new_std(ctrl_hdlr, &imx335_ctrl_ops, V4L2_CID_HBLANK, - IMX335_REG_MIN, - IMX335_REG_MAX, + mode->hblank, + mode->hblank, 1, mode->hblank); if (imx335->hblank_ctrl) imx335->hblank_ctrl->flags |= V4L2_CTRL_FLAG_READ_ONLY;