From patchwork Mon Oct 9 15:34:15 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bartosz Golaszewski X-Patchwork-Id: 150158 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:a888:0:b0:403:3b70:6f57 with SMTP id x8csp1951910vqo; Mon, 9 Oct 2023 08:35:04 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEpqNuTXiYUm/bELR/0HLG5ijwHRHKTxE6uH81cGqgQ9O4gFHZsJrToJ0HEpu1zHF+nqEis X-Received: by 2002:a17:902:b698:b0:1c8:791c:d797 with SMTP id c24-20020a170902b69800b001c8791cd797mr10686621pls.56.1696865704054; Mon, 09 Oct 2023 08:35:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696865704; cv=none; d=google.com; s=arc-20160816; b=vpGP0uxV5bUBJtupQemNewGlqhuOFyFCQUWV3uypGdOaTL28jkv8rZ7J6GQPnH6aNc QbA7IrV8HsjIesyCBRN4iyT0UIW8/oqNeAeU9QP7RsG3gwgz1h7NaKVaeii+XPWxNtFy y8nsbnbTABepQCJBIyuBP3C9QEX+sTYPNbYinzI0igK1QEoZMWg1ukpxH26xeBwM/uS5 MQsu/CVm1d2ltoCe3Nhy9yQJ2kLHC+22+s74S6sxzrJguWlk5TZAhX0+V21BGDuGzF2v TYutqc/h1kVq5fqCHc/oXATj+vQ0B9XVrV4Iw2UV5pDorF2owY1MUQ7ncR7HaTwT4xvM a8jg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=D6eAwp+/NLgzsLQxQqIe9/6ILdI8QAjkHJ9+by+NSlg=; fh=lirm1ccAeXZZB1cIo+N1DqklpgcFmD/vJ7PCWNIL0HU=; b=gGhV3JaRXyT/lRwIDkyIqqEMpKEoT7b6ILq2IVnUkPmDLyOV9wVghq9Z1xlztxKI1F 1b08j5EDVNa/MO+jPptfg+cY8hnxeVyxELJUtNR56TPfWcTGtQE9YSoTTUAo2P9OBVYH L+SfJ4BP7P7x4jsZV/NQ40dgQtgD6iV3+8bdkYdbWK/kgVHvQ/NhPN4NHKPRGrPjtA+U tO0XzzhDRFGPT3klGQCoecaMaJYGMDKEahh9RP4qZp7mOivgLlYvMsxy7Oh6Kb517uJC RqZ5S8gGURhOL0cNBkwp+X45lvXDcWbF9FfZGFYKrmO9QAAZSbJfmFm4hhV7YbbACifC 1TDQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@bgdev-pl.20230601.gappssmtp.com header.s=20230601 header.b=xhXKuHps; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id u15-20020a170903124f00b001c60e273252si10038718plh.25.2023.10.09.08.35.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Oct 2023 08:35:04 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; dkim=pass header.i=@bgdev-pl.20230601.gappssmtp.com header.s=20230601 header.b=xhXKuHps; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id F02BF802128D; Mon, 9 Oct 2023 08:35:02 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1376821AbjJIPe5 (ORCPT + 18 others); Mon, 9 Oct 2023 11:34:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41806 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1376903AbjJIPer (ORCPT ); Mon, 9 Oct 2023 11:34:47 -0400 Received: from mail-wr1-x432.google.com (mail-wr1-x432.google.com [IPv6:2a00:1450:4864:20::432]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7EDE991 for ; Mon, 9 Oct 2023 08:34:45 -0700 (PDT) Received: by mail-wr1-x432.google.com with SMTP id ffacd0b85a97d-32615eaa312so4296184f8f.2 for ; Mon, 09 Oct 2023 08:34:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1696865684; x=1697470484; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=D6eAwp+/NLgzsLQxQqIe9/6ILdI8QAjkHJ9+by+NSlg=; b=xhXKuHps+ybCrEyg8BHskK+FPz7fzSwdZi4aTPWwWwvKXH7BLV1R3hz/8tY2aiUorZ 61aS9bBepbOFm4hAPOzVuqO45FhxlBNw6/96IUk9ajmiONQHuwF+FKR0zSBHZ0861uSz +08jsF7uSxSTbttElADRoY3tYX2xQmaf1t7x9W1sAEGo0mVUo/onpf5kVBGUdy3+qYKU XBAiWM1Ux/T9k6DCJPSLq8c/WRuiNkqd4X9fKyyptU9WWhHH7L9DsV6LBFHVkx6icbgn NsJ+DPcflylAOwkpQvSdccvKa32U4zChUHz2Nj665/3gQPpTXWOewEdyJF5rxwTcEtX4 CZag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696865684; x=1697470484; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=D6eAwp+/NLgzsLQxQqIe9/6ILdI8QAjkHJ9+by+NSlg=; b=Ut0STvZ43cMN9ClGQp09nAVt2XuMQ2SXerfbGaP2K2LD3pQjuwgWypFkzJ4KBi2kFX IZUIyaMP6MXojuKy9mO+gmrvtdYhISJHBkTqSs7YjCFl4mOq+xoajIB4v0RHKvizmK6m o/cUoUsswIIbSzDUA9bPArTJsMx/GQbz5X9cKVL2dAaP7UnciSc8mybDzaWhl+b9Sy4N 6nGAqHHGfD6gBgZp4jL2W3JMM/AvHGjs6hYcjZYLTKwNaFNSTKb0J7KA9ozCflgNykmh bMQgRgz6k0HZmARpmHOfq9eQeDlPRseBcJArMJB+mUvVn9mt2T2kqU7nufXQDPE4M52z Pt2g== X-Gm-Message-State: AOJu0YzM25t54SuawYl9nI7p99kPr/eys0K5vQpNj0iUACSUJpJNgNEt EDX1mMyJ8C51Kxag0IXNG6a+nQ== X-Received: by 2002:adf:f407:0:b0:31f:eed7:2fdc with SMTP id g7-20020adff407000000b0031feed72fdcmr14360253wro.35.1696865683428; Mon, 09 Oct 2023 08:34:43 -0700 (PDT) Received: from brgl-uxlite.home ([2a01:cb1d:334:ac00:f20d:2959:7545:e99f]) by smtp.gmail.com with ESMTPSA id b3-20020adff243000000b0031431fb40fasm10016521wrp.89.2023.10.09.08.34.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Oct 2023 08:34:43 -0700 (PDT) From: Bartosz Golaszewski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Elliot Berman , Krzysztof Kozlowski , Guru Das Srinagesh , Andrew Halaney , Maximilian Luz , Alex Elder , Srini Kandagatla Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kernel@quicinc.com, Bartosz Golaszewski Subject: [PATCH v3 03/15] firmware: qcom: scm: remove unneeded 'extern' specifiers Date: Mon, 9 Oct 2023 17:34:15 +0200 Message-Id: <20231009153427.20951-4-brgl@bgdev.pl> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20231009153427.20951-1-brgl@bgdev.pl> References: <20231009153427.20951-1-brgl@bgdev.pl> MIME-Version: 1.0 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Mon, 09 Oct 2023 08:35:03 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1779292652459799978 X-GMAIL-MSGID: 1779292652459799978 From: Bartosz Golaszewski 'extern' specifiers do nothing for function declarations. Remove them from the private qcom-scm header. Signed-off-by: Bartosz Golaszewski Reviewed-by: Andrew Halaney --- drivers/firmware/qcom/qcom_scm.h | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/drivers/firmware/qcom/qcom_scm.h b/drivers/firmware/qcom/qcom_scm.h index c88e29051d20..4532907e8489 100644 --- a/drivers/firmware/qcom/qcom_scm.h +++ b/drivers/firmware/qcom/qcom_scm.h @@ -66,18 +66,17 @@ int qcom_scm_wait_for_wq_completion(u32 wq_ctx); int scm_get_wq_ctx(u32 *wq_ctx, u32 *flags, u32 *more_pending); #define SCM_SMC_FNID(s, c) ((((s) & 0xFF) << 8) | ((c) & 0xFF)) -extern int __scm_smc_call(struct device *dev, const struct qcom_scm_desc *desc, - enum qcom_scm_convention qcom_convention, - struct qcom_scm_res *res, bool atomic); +int __scm_smc_call(struct device *dev, const struct qcom_scm_desc *desc, + enum qcom_scm_convention qcom_convention, + struct qcom_scm_res *res, bool atomic); #define scm_smc_call(dev, desc, res, atomic) \ __scm_smc_call((dev), (desc), qcom_scm_convention, (res), (atomic)) #define SCM_LEGACY_FNID(s, c) (((s) << 10) | ((c) & 0x3ff)) -extern int scm_legacy_call_atomic(struct device *dev, - const struct qcom_scm_desc *desc, - struct qcom_scm_res *res); -extern int scm_legacy_call(struct device *dev, const struct qcom_scm_desc *desc, +int scm_legacy_call_atomic(struct device *dev, const struct qcom_scm_desc *desc, struct qcom_scm_res *res); +int scm_legacy_call(struct device *dev, const struct qcom_scm_desc *desc, + struct qcom_scm_res *res); #define QCOM_SCM_SVC_BOOT 0x01 #define QCOM_SCM_BOOT_SET_ADDR 0x01