Message ID | 20231009124210.1064021-3-masahiroy@kernel.org |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:a888:0:b0:403:3b70:6f57 with SMTP id x8csp1839339vqo; Mon, 9 Oct 2023 05:42:44 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGf+kO+Y5vZsSx3p3N+XufYki/ccFP3ZLO7UfBYZ5RS4Ux+zQGH6gzX4uGbil5Q7i2UxOXu X-Received: by 2002:a05:6a20:4287:b0:16b:aad0:effe with SMTP id o7-20020a056a20428700b0016baad0effemr7913424pzj.62.1696855364492; Mon, 09 Oct 2023 05:42:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696855364; cv=none; d=google.com; s=arc-20160816; b=XIktT+PjFwfd3q5VEtFDFpDgwgwQpANez+cPjpp0zLb4ypZMcEjLySxmsCZE/h21+b 0irUnXgaZ/Sk/SkHwv7RhKRrZXYG/gO2R6w78DMwYoDzYQRvB+UZyFGgY2+qOxfRPBYN f+Hwboc9G3QAjHQdJ3IqcQV+TVmIc1C/ZXN9IVDwGGcQPAbNA75ZTT9RaURsK348lphZ V2gdgs60i+8EfiHTvDtb9oouP0d72yXmB+TmKsIbXVVy6d2tQgOaByrACMFGb1gtitRN C1FH0eBCjcHOzOA+uRhWvdKKxxVMtm+j01++aoKsQYW9YZ+Q0+Qf0E2HcKIEP5s9QWOH gX8A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=4CfhcOG7Hx77zGmLBqT+63In2/J1g2aTeJF4TKGJ+a0=; fh=gwxQ4RnOujgr7/mzA7Tigg4tLW6wDndlYvSgrnvtaiI=; b=aYGERTEuMgFwTs3+Qak71NXHHxWeWYlqs5XYNA99Bbl3EzMp2HWVVEbYQvOcSuwgXu K990diwKdmfvWVKui+ibrNLph/PT7okBcRO6bHmXCILPACqZB7pIXVOOvB84Rv+tBsfB LwTPNNtmtcP0TtG9mie8sB0LiQTTRoMbQwXt+zrjheO7OZpsa3VzS2ukIfDKQPWWqK+y 2hlT/JQkCFH2HZYUEdHgL967VqlkFoonyeACOOheVFqoE/tRt06opTAKetvJSgpHAhU2 82iahUzTCsvkArLPMVK0XFvrYHHUqg5zeMJq7+SqkN2ZmhONw1yooUnQojc4rIlQNe+G oc1g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=OHYkpZWP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from lipwig.vger.email (lipwig.vger.email. [23.128.96.33]) by mx.google.com with ESMTPS id y16-20020a17090264d000b001b8ac52a19esi9164375pli.436.2023.10.09.05.42.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Oct 2023 05:42:44 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=OHYkpZWP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id 22225804C232; Mon, 9 Oct 2023 05:42:41 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1376542AbjJIMmb (ORCPT <rfc822;ezelljr.billy@gmail.com> + 18 others); Mon, 9 Oct 2023 08:42:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60420 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1376527AbjJIMmZ (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Mon, 9 Oct 2023 08:42:25 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DF3CFAB; Mon, 9 Oct 2023 05:42:23 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 160ADC433C7; Mon, 9 Oct 2023 12:42:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1696855343; bh=2pDAXsYdr6lnZaEYy+XyoiLH0SPTSNq4AwXsBcAaKjg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=OHYkpZWPOomWrfTFYsYVR0dUXhsAstX8BQkaIe3nW9TdyVFGMja92VWRyCVFwtvLu CbD7EBBZEDbE6fCV4YR61vYddvnMXW67ZL85pe26/hUqPjUmqu0OAa8XY0PvvwbenC /oGofIlRr4w/Og4GChSzkelChds0+PIHOQPVgEybQ6zx+9uKj1+hy9HriCG/xUVpot U3xkmlZXMutL2G9oSGHhPB7gSKKDzof5imbxXPmpSZKgOHnUaD+6xRQHglYQzxwJjW yT5ERsvwknSJqNYTvtNznli7Pq9cxsMmX8BJaFSR2Egmg1Nb1Tb44If/mAVcG+esbL kM3C1xQExPh2Q== From: Masahiro Yamada <masahiroy@kernel.org> To: linux-kbuild@vger.kernel.org Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-parisc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-um@lists.infradead.org, loongarch@lists.linux.dev, sparclinux@vger.kernel.org, x86@kernel.org, Masahiro Yamada <masahiroy@kernel.org>, Helge Deller <deller@gmx.de>, "James E.J. Bottomley" <James.Bottomley@HansenPartnership.com> Subject: [PATCH 3/5] parisc: remove broken vdso_install Date: Mon, 9 Oct 2023 21:42:08 +0900 Message-Id: <20231009124210.1064021-3-masahiroy@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20231009124210.1064021-1-masahiroy@kernel.org> References: <20231009124210.1064021-1-masahiroy@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=2.4 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Mon, 09 Oct 2023 05:42:41 -0700 (PDT) X-Spam-Level: ** X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1779281810547765572 X-GMAIL-MSGID: 1779281810547765572 |
Series | [1/5] csky: remove unused cmd_vdso_install | |
Commit Message
Masahiro Yamada
Oct. 9, 2023, 12:42 p.m. UTC
'make ARCH=parisc vdso_install' has never worked. It attempts to
descend into arch/parisc/kernel/vdso/, which does not exist.
The command just fails:
scripts/Makefile.build:41: arch/parisc/kernel/vdso/Makefile: No such file or directory
The second line is also meaningless because parisc does not define
CONFIG_COMPAT_VDSO.
It appears that this code was copied from another architecture without
proper adaptation.
Remove the broken code.
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
---
arch/parisc/Makefile | 7 -------
1 file changed, 7 deletions(-)
Comments
Hi Masahiro, On 10/9/23 14:42, Masahiro Yamada wrote: > 'make ARCH=parisc vdso_install' has never worked. It attempts to > descend into arch/parisc/kernel/vdso/, which does not exist. > > The command just fails: > > scripts/Makefile.build:41: arch/parisc/kernel/vdso/Makefile: No such file or directory > > The second line is also meaningless because parisc does not define > CONFIG_COMPAT_VDSO. > > It appears that this code was copied from another architecture without > proper adaptation. Yes. > Remove the broken code. > > Signed-off-by: Masahiro Yamada <masahiroy@kernel.org> Thanks for cleaning this up and making it consistent across the architectures. Acked-by: Helge Deller <deller@gmx.de> # parisc In case you do a v2 version of the patch, would you add to arch/parisc/Makefile (otherwise I can send a follow-up patch in the parisc git tree): vdso-install-y += arch/parisc/kernel/vdso32/vdso32.so vdso-install-$(CONFIG_64BIT) += arch/parisc/kernel/vdso64/vdso64.so Thanks! Helge
diff --git a/arch/parisc/Makefile b/arch/parisc/Makefile index 968ebe17494c..4222fa73c34a 100644 --- a/arch/parisc/Makefile +++ b/arch/parisc/Makefile @@ -177,13 +177,6 @@ vdso_prepare: prepare0 $(Q)$(MAKE) $(build)=arch/parisc/kernel/vdso32 include/generated/vdso32-offsets.h endif -PHONY += vdso_install - -vdso_install: - $(Q)$(MAKE) $(build)=arch/parisc/kernel/vdso $@ - $(if $(CONFIG_COMPAT_VDSO), \ - $(Q)$(MAKE) $(build)=arch/parisc/kernel/vdso32 $@) - install: KBUILD_IMAGE := vmlinux zinstall: KBUILD_IMAGE := vmlinuz install zinstall: