From patchwork Mon Oct 9 08:38:43 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 149904 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:a888:0:b0:403:3b70:6f57 with SMTP id x8csp1743000vqo; Mon, 9 Oct 2023 02:23:36 -0700 (PDT) X-Google-Smtp-Source: AGHT+IF6zV1BUH+KgtJGd4rNd9VDIPGegpMdwHVmtpTyDDj+4Wcjw095RtZyBn9AQmwaIhRRivsK X-Received: by 2002:a17:90a:1b88:b0:27b:9fa:ef0a with SMTP id w8-20020a17090a1b8800b0027b09faef0amr16335815pjc.23.1696843415965; Mon, 09 Oct 2023 02:23:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696843415; cv=none; d=google.com; s=arc-20160816; b=F/mRJU7Hgon3kuv/I15g8m94lKbwtbc45fObAWPVYOaXunNNVeWP2bonIB1db8MHhz ZWUAgBf2SdT/1rb2A+zLlTgwSM7ed57lmVxoIymX14DDcIuYrZWTt/kDoYv43463WF0+ 5v9UWCdsIilsuRojlRuvIh93vHizIowTBiWJVeKJlb06mUkYPL1PMxUZnt2144urpfpK t0sMsFWZI3hW17Q4YnWhiqSUtck8oCGXxh3TzgRMqORNi6sk+CFNE/b+eEpkLbzatZ6Y 2htie784hjjJY/mh5c12gyBAM5Peookt1qmIIsrcEeznRVvqpertnRVaRsAeMEIhQAtz F3vA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=zS4WtoKV3d14Z/2c2lMoQygioEKVPvNVrTnZqAMQ2FM=; fh=pAo+ELfTqLZj0+fmLuLCcqqOGn4+JhBCWkgo6Lcn92M=; b=KjvHFR/7xUU73ArCNyUOK8rhLq4TKy0s9PW0KN5BsFrkmBSn2a5T+GGkDyAmUAZrFq 9acKIJqIQxoJi0l2z6+bjghgnEtJPuazv7BgZcKDT6om4N/ewUb+YpH+e8t20VcdMnQw CqwDIPN9++s2N2wlVlEQULbzvv2G70gSV+63JknCAvHWJ3pYokLOuJ4KmXMs0ruq0sCn vWT6Xi+GetwmvcOJO1PA29mCH07xyqk/niGxPQVM7H8cWZoe9qKEkRkxfX6VuucpcccL zq8DMfifwpLGYBuLPSfROjDuRWjblpYNQ84zbu90nUw27RsoH0AyAVREqg2xvoEL43mr 0pTQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from morse.vger.email (morse.vger.email. [23.128.96.31]) by mx.google.com with ESMTPS id z16-20020a656650000000b00564c67e66fbsi8948800pgv.842.2023.10.09.02.23.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Oct 2023 02:23:35 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by morse.vger.email (Postfix) with ESMTP id AAFAD802121C; Mon, 9 Oct 2023 02:23:28 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at morse.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345883AbjJIJW6 (ORCPT + 18 others); Mon, 9 Oct 2023 05:22:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58230 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345707AbjJIJWs (ORCPT ); Mon, 9 Oct 2023 05:22:48 -0400 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [IPv6:2a0a:edc0:2:b01:1d::104]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DE255DF for ; Mon, 9 Oct 2023 02:22:40 -0700 (PDT) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qpmTD-0006sy-Sw; Mon, 09 Oct 2023 11:22:35 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qpmTD-000NWi-Fw; Mon, 09 Oct 2023 11:22:35 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1qpmTD-00C4pD-71; Mon, 09 Oct 2023 11:22:35 +0200 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Linus Walleij Cc: linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 07/20] pinctrl: nomadik: abx500: Convert to platform remove callback returning void Date: Mon, 9 Oct 2023 10:38:43 +0200 Message-Id: <20231009083856.222030-8-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20231009083856.222030-1-u.kleine-koenig@pengutronix.de> References: <20231009083856.222030-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1861; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=x2KWQ8ND+eDvRay0aKLtZDCZD1SPAhsCIdQmVEps4lo=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBlI7wHsl1vdO0V+6YWoS08CB0bmd/UjRDek9bRC dXtf5HfDhCJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZSO8BwAKCRCPgPtYfRL+ TjeFCACbpMBmj7EOf+G1UFGYv3PxitszRTnu9lWkhurVE7IsmkEsb+WQq7EsN0hE+S5AIKjcuHX eoDGCNbRLj0Y50C6P3zDeCdwe91dtx7eugvi3xsOkeEFdmIqB8MIdgr+l9InqnIw/fWHDXY38Ac wshhoqeRZF3E3vuMDy97fhtAZKauXplJ8Z8FMVnPmUyCZiJQ4TZxqRwrc0r/ogUtzIJHxJaDaDs wBtk2i0BAlzXEiMmXBez1UkMLh15Xwxc8qlfANnoJn3TAQCqegPHFSKSfRC7dGfjghsH+7yPQn+ 4rO4837lZEUGxc0AH2HPL4f8ZfbZyXoPAWwZhB1QAdXu+SB1 X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=2.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Mon, 09 Oct 2023 02:23:28 -0700 (PDT) X-Spam-Level: ** X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1779269281742891378 X-GMAIL-MSGID: 1779269281742891378 The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/pinctrl/nomadik/pinctrl-abx500.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/pinctrl/nomadik/pinctrl-abx500.c b/drivers/pinctrl/nomadik/pinctrl-abx500.c index 6b90051af206..233857d54403 100644 --- a/drivers/pinctrl/nomadik/pinctrl-abx500.c +++ b/drivers/pinctrl/nomadik/pinctrl-abx500.c @@ -1079,12 +1079,11 @@ static int abx500_gpio_probe(struct platform_device *pdev) * abx500_gpio_remove() - remove Ab8500-gpio driver * @pdev: Platform device registered */ -static int abx500_gpio_remove(struct platform_device *pdev) +static void abx500_gpio_remove(struct platform_device *pdev) { struct abx500_pinctrl *pct = platform_get_drvdata(pdev); gpiochip_remove(&pct->chip); - return 0; } static struct platform_driver abx500_gpio_driver = { @@ -1093,7 +1092,7 @@ static struct platform_driver abx500_gpio_driver = { .of_match_table = abx500_gpio_match, }, .probe = abx500_gpio_probe, - .remove = abx500_gpio_remove, + .remove_new = abx500_gpio_remove, }; static int __init abx500_gpio_init(void)