From patchwork Mon Oct 9 08:38:46 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 149898 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:a888:0:b0:403:3b70:6f57 with SMTP id x8csp1742721vqo; Mon, 9 Oct 2023 02:22:51 -0700 (PDT) X-Google-Smtp-Source: AGHT+IElbqx9ys10vB+niQgRg/eSmg4xqXrLvCSQ345OYrTB3ek7QonDR4bw1T7SBiVFKM4u9OT2 X-Received: by 2002:a17:902:e750:b0:1c5:efd1:82b4 with SMTP id p16-20020a170902e75000b001c5efd182b4mr16610810plf.29.1696843371301; Mon, 09 Oct 2023 02:22:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696843371; cv=none; d=google.com; s=arc-20160816; b=Hj4shpL0ES4bEVbkV+oAOm3BpGMSd6aHl44QDdbywB2lhaSWW/ljlbG4zQOJnce8t/ zkrE+6J75glON9wnUJShpsq20HIzTy0Q40yx6hdizdLrbwxhvkJx0Raw99POH1F6DvZU K0ibUvQ/ARoMMsw/fhwDT7h+Lexs4zc0uQU9mWT+nfv1F4k14N1Pc5+vv2sTO+Q3k80n IulM7hHzxujojtNJRCrG7JhktKDxM72xEvkAqDXRDvNIV1k0iX5W7doWjis0mi6iq0w4 MYwCpt3q6i0Gzet1IvuxVI4q0XcYPPc5usQoGKUKp1MRlCMBuc6XH74VlSGCtBOh4MNI 0Axw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=h1Qg5v6DO4SOWmascaXNgPUMJfSDDgOZ+m8pKPK2xIQ=; fh=F4bs7feh0kNPfpkxC+XiThUexV96iac3bkIm5iNd+h4=; b=Wr/v3IOyK3TFaR9xUxKkLxWWJnmQjeyVB6ezTBuqFo/HJhXtxZGUVrbf26NInh/Gr0 h8BGPPhphsMpG5aLpUtIs4hw2f82kSEEd4piiW75+xOO2ceQlIkzA1BJMWvNRhCirpAu gllAiAMCE00XdQkC7hD67L9IDS9fd/quQmZce1uft7C2gziXLPpSNVeKKWc6iQJdVGt9 wU/wKLTyjZT6jgfqZsP2xTOrBHETl9jwZ3zFIEdMZ1Xs7YcYfdAXLCDyaRrqOfkR8K3Q OmCPRPb9yMPO9OWGQoilzJEY9voWSx8JKl8AysIy6HewN+lRvpinIG/PT0eC02gWLKwc XGiA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from morse.vger.email (morse.vger.email. [23.128.96.31]) by mx.google.com with ESMTPS id h12-20020a170902f7cc00b001c604f8de9fsi8827596plw.631.2023.10.09.02.22.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Oct 2023 02:22:51 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by morse.vger.email (Postfix) with ESMTP id 4E0B0802120A; Mon, 9 Oct 2023 02:22:48 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at morse.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345774AbjJIJWm (ORCPT + 18 others); Mon, 9 Oct 2023 05:22:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36294 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345695AbjJIJWj (ORCPT ); Mon, 9 Oct 2023 05:22:39 -0400 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [IPv6:2a0a:edc0:2:b01:1d::104]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 99CFF97 for ; Mon, 9 Oct 2023 02:22:38 -0700 (PDT) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qpmTE-0006td-KC; Mon, 09 Oct 2023 11:22:36 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qpmTE-000NWw-7o; Mon, 09 Oct 2023 11:22:36 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1qpmTD-00C4pP-Uy; Mon, 09 Oct 2023 11:22:35 +0200 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Linus Walleij Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 10/20] pinctrl: as3722: Convert to platform remove callback returning void Date: Mon, 9 Oct 2023 10:38:46 +0200 Message-Id: <20231009083856.222030-11-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20231009083856.222030-1-u.kleine-koenig@pengutronix.de> References: <20231009083856.222030-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1797; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=MPWtYbMOQgZR7mlnb/mgL+Kp5Cn22AjikhRP10lPHcU=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBlI7wKE74xmYD8QqeyqKDdAd0aRFg6ar601wE4U 3O0gprgCImJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZSO8CgAKCRCPgPtYfRL+ TigkB/0ezfjZNnv82AK92u26hpU28QyX4rIKqnS5KQojWwblAi+52ppN5+EMlbRRrFGYY5wSBn4 TnVuCrRpr6YUxKBV7pz7p490x5ndIbSoG2wc3Y0AXYrp9XbqC4bqPLq4mQ+9jfG3MKEC25+WbyF /N4Q5VRsfG5fuV5jlzoXjNzTr97EzrLIVmpy8UTVLLBHJl9lz1SpLYObXzJPtPwtcrBAg5KLuWn hIb4IhnvbcAahYVYJOl+49L09sxhggWJFA1jqK1ZQCSJN46A4o0WbeL0RKpHJ2srBnCTvjJZuvO tM6KKRWDc4dB+lNZ28YbuKUFaS09UNJJsveOHajkwX6taoPs X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=2.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Mon, 09 Oct 2023 02:22:48 -0700 (PDT) X-Spam-Level: ** X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1779269234792846540 X-GMAIL-MSGID: 1779269234792846540 The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/pinctrl/pinctrl-as3722.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/pinctrl/pinctrl-as3722.c b/drivers/pinctrl/pinctrl-as3722.c index f0e5d87ac50b..84b47a6cc3a6 100644 --- a/drivers/pinctrl/pinctrl-as3722.c +++ b/drivers/pinctrl/pinctrl-as3722.c @@ -587,12 +587,11 @@ static int as3722_pinctrl_probe(struct platform_device *pdev) return ret; } -static int as3722_pinctrl_remove(struct platform_device *pdev) +static void as3722_pinctrl_remove(struct platform_device *pdev) { struct as3722_pctrl_info *as_pci = platform_get_drvdata(pdev); gpiochip_remove(&as_pci->gpio_chip); - return 0; } static const struct of_device_id as3722_pinctrl_of_match[] = { @@ -607,7 +606,7 @@ static struct platform_driver as3722_pinctrl_driver = { .of_match_table = as3722_pinctrl_of_match, }, .probe = as3722_pinctrl_probe, - .remove = as3722_pinctrl_remove, + .remove_new = as3722_pinctrl_remove, }; module_platform_driver(as3722_pinctrl_driver);