diff mbox series

cpufreq: tegra194: remove redundant AND with cpu_online_mask

Message ID 20231009082423.16714-1-sumitg@nvidia.com
State New
Headers
Series cpufreq: tegra194: remove redundant AND with cpu_online_mask |

Commit Message

Sumit Gupta Oct. 9, 2023, 8:24 a.m. UTC 
  Remove redundant 'AND' with cpu_online_mask as the policy->cpus always
contains only the currently online CPUs.

Suggested-by: Viresh Kumar <viresh.kumar@linaro.org>
Link: https://lore.kernel.org/lkml/20231003050019.a6mcchw2o2z2wkrh@vireshk-i7/
Signed-off-by: Sumit Gupta <sumitg@nvidia.com>
---
 drivers/cpufreq/tegra194-cpufreq.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Viresh Kumar Oct. 9, 2023, 8:41 a.m. UTC | #1 
On 09-10-23, 13:54, Sumit Gupta wrote:
> Remove redundant 'AND' with cpu_online_mask as the policy->cpus always
> contains only the currently online CPUs.
> 
> Suggested-by: Viresh Kumar <viresh.kumar@linaro.org>
> Link: https://lore.kernel.org/lkml/20231003050019.a6mcchw2o2z2wkrh@vireshk-i7/
> Signed-off-by: Sumit Gupta <sumitg@nvidia.com>
> ---
>  drivers/cpufreq/tegra194-cpufreq.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/cpufreq/tegra194-cpufreq.c b/drivers/cpufreq/tegra194-cpufreq.c
> index 386aed3637b4..607e699b3d84 100644
> --- a/drivers/cpufreq/tegra194-cpufreq.c
> +++ b/drivers/cpufreq/tegra194-cpufreq.c
> @@ -135,7 +135,7 @@ static void tegra234_set_cpu_ndiv(struct cpufreq_policy *policy, u64 ndiv)
>  	u32 cpu, cpuid, clusterid;
>  	u64 mpidr_id;
>  
> -	for_each_cpu_and(cpu, policy->cpus, cpu_online_mask) {
> +	for_each_cpu(cpu, policy->cpus) {
>  		data->soc->ops->get_cpu_cluster_id(cpu, &cpuid, &clusterid);
>  
>  		/* use physical id to get address of per core frequency register */

Applied. Thanks.
diff mbox series

Patch

diff --git a/drivers/cpufreq/tegra194-cpufreq.c b/drivers/cpufreq/tegra194-cpufreq.c
index 386aed3637b4..607e699b3d84 100644
--- a/drivers/cpufreq/tegra194-cpufreq.c
+++ b/drivers/cpufreq/tegra194-cpufreq.c
@@ -135,7 +135,7 @@  static void tegra234_set_cpu_ndiv(struct cpufreq_policy *policy, u64 ndiv)
 	u32 cpu, cpuid, clusterid;
 	u64 mpidr_id;
 
-	for_each_cpu_and(cpu, policy->cpus, cpu_online_mask) {
+	for_each_cpu(cpu, policy->cpus) {
 		data->soc->ops->get_cpu_cluster_id(cpu, &cpuid, &clusterid);
 
 		/* use physical id to get address of per core frequency register */