From patchwork Sat Oct 7 17:04:47 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Masahiro Yamada X-Patchwork-Id: 149612 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:a888:0:b0:403:3b70:6f57 with SMTP id x8csp1025550vqo; Sat, 7 Oct 2023 10:05:08 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGbhAatePFR/EFnkGgWE2QYnaxAlmLQZ77xMgGKx7VgYg5Lf9E4HE43qhesZJp3JRQCU8CJ X-Received: by 2002:a05:6870:3328:b0:1d1:2605:bb0a with SMTP id x40-20020a056870332800b001d12605bb0amr13433792oae.26.1696698308249; Sat, 07 Oct 2023 10:05:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696698308; cv=none; d=google.com; s=arc-20160816; b=EjnlD61JrgfW5MT0umOrvxbSlfOpEjc0JsOTuobvWIQJkHNi6Xpqy/6nqBY6dsMPyd BlPl3o0VXAfOQNct3uSb3QMvUKWiL+IVMTiN12MKXkXbDKq7PxfJbt+YD4LDL80JcUWa J8qCNg/Tt/5Ec9CFKekS8GD6+G8tCPJrJka/g2zew2Hfl/pKp+NU+rq4/judpTLF131l uWe/W4sabHvEFVof19bQzliMmSsQiv0YWxDdubVWoSHlfrL/jYyCKp8hHvxJwWeVWaxU XNZGERdoc4ffuufZs7SFGp4qr2APr3Mgvqs66dXB0cLYNYORX26CqBgrVXHSVsK0pJ/S 5iyA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=Jvwplqz6ucSBvjkUsANhjfA04Bwuc+a9HhhxE6EV6k8=; fh=DNUEAfFafydB9vNApmSaMnjQC4olHhINF4DqgGQv3/I=; b=YTw/5Xr7M4ga/XeLOc9tnY1AGzvkMjfTTCQm9OYdbbh3VTKWfLm+OP8sRsusCGxrMx pivs+kWVdmAJRdHS0NOlbZ4BIAVTklmI/fBqskPRe79QKWIvc3PRpv/KL8dlVKJrspyR OvsOjjtJEvmob/Eit+Zo69fQ/iueYyFNMvvGmaJzcOP1B4IiSKivAfCulHW6N2SHzUb/ HBjFAKB2KhqQm6baudCaKhjDOqP7FOMnhwOPzE+ZoV9tvcrH+6GFxEXyI8+4COVgOlDv 1IXNCNE4bT73r3zhhopKViXetxWoqWKyygeNqN+BuSPYvZNgcD0dcJP3UlyEKXb1Eoq0 67Og== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=b8HZlTL4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id h15-20020a056a001a4f00b00690d42e334fsi3955937pfv.181.2023.10.07.10.05.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 07 Oct 2023 10:05:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=b8HZlTL4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id A9505809788E; Sat, 7 Oct 2023 10:05:07 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344121AbjJGRFE (ORCPT + 17 others); Sat, 7 Oct 2023 13:05:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56756 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344105AbjJGRFC (ORCPT ); Sat, 7 Oct 2023 13:05:02 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7DB12BA; Sat, 7 Oct 2023 10:05:01 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D892FC433CB; Sat, 7 Oct 2023 17:04:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1696698301; bh=TTLYNPGjyBivwozdoa07Smf/suztpzKvRG2LWS6FNas=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=b8HZlTL4Afo59CcwyOtgb4Y93r5LNHEiDZEKyeCjOhuDNWTEokl9GgaNHBDGyQl1m k98Volk7bHlMt8cG0kuf/X3YROh35Oz+RhlBeaNSQvs0X0nifaBb4BxkSA5iNpwmTK 9iW+aoM6iguuZVAIQnuN2KeXyNwMyiaGCWXPNG+Sn/NlT+R4sOQLgIvk6685gIjDdx 63f1dugnXyAhbGubHI/ZKunvbkiuu32lOajBgwSdiDrzzZilDkZDZybvabEJOA5Rnc w/pf5cUTLzYO+89crg7fWJMZBsp5CI260rVEUWjRUaoVlTxz8GdyxUWnty3p5PH4Z6 uocIjpipmOmtQ== From: Masahiro Yamada To: linux-kbuild@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Masahiro Yamada , Nick Desaulniers , Nathan Chancellor , Nicolas Schier Subject: [PATCH 4/5] modpost: refactor check_sec_ref() Date: Sun, 8 Oct 2023 02:04:47 +0900 Message-Id: <20231007170448.505487-4-masahiroy@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20231007170448.505487-1-masahiroy@kernel.org> References: <20231007170448.505487-1-masahiroy@kernel.org> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Sat, 07 Oct 2023 10:05:07 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1779117125313576539 X-GMAIL-MSGID: 1779117125313576539 We can replace &elf->sechdrs[i] with &sechdrs[i] to slightly shorten the code because we already have the local variable 'sechdrs'. However, defining 'sechdr' instead shortens the code further. Signed-off-by: Masahiro Yamada Reviewed-by: Nick Desaulniers --- scripts/mod/modpost.c | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/scripts/mod/modpost.c b/scripts/mod/modpost.c index 99476a9695c5..441d57ee3275 100644 --- a/scripts/mod/modpost.c +++ b/scripts/mod/modpost.c @@ -1518,16 +1518,17 @@ static void section_rel(struct module *mod, struct elf_info *elf, static void check_sec_ref(struct module *mod, struct elf_info *elf) { int i; - Elf_Shdr *sechdrs = elf->sechdrs; /* Walk through all sections */ for (i = 0; i < elf->num_sections; i++) { - check_section(mod->name, elf, &elf->sechdrs[i]); + Elf_Shdr *sechdr = &elf->sechdrs[i]; + + check_section(mod->name, elf, sechdr); /* We want to process only relocation sections and not .init */ - if (sechdrs[i].sh_type == SHT_RELA) - section_rela(mod, elf, &elf->sechdrs[i]); - else if (sechdrs[i].sh_type == SHT_REL) - section_rel(mod, elf, &elf->sechdrs[i]); + if (sechdr->sh_type == SHT_RELA) + section_rela(mod, elf, sechdr); + else if (sechdr->sh_type == SHT_REL) + section_rel(mod, elf, sechdr); } }