From patchwork Fri Oct 6 16:04:27 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dmitry Rokosov X-Patchwork-Id: 149319 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:a888:0:b0:403:3b70:6f57 with SMTP id x8csp433455vqo; Fri, 6 Oct 2023 09:05:27 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGxW9YaaChVIqvvj8CmsvN4PzbhCOUF7UnlZ2m9eSXvtRDGmwYrjAm3Hsfr6Yxxndh6lgR8 X-Received: by 2002:a17:902:c3cd:b0:1c6:1cd8:5b59 with SMTP id j13-20020a170902c3cd00b001c61cd85b59mr8347282plj.1.1696608327554; Fri, 06 Oct 2023 09:05:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696608327; cv=none; d=google.com; s=arc-20160816; b=wPWxsgkGPvosYb/n3qfExYKOdyksd2smRse2+hnBkPvGqcZhiFBLGwgXbVKgsKxjpn JZIRYe6INf7Z81Tv2i0ehN1Q16m++sUC7CmrSCdLDGQhH4lesGzRIRtL1tCbQtP+d2Nj E9E1d9p3FSj2RTSmTg3nfNAZ1Iy5Rfd0lEzeVmPmbkFkpVPaBd30aDZvS+EcC6LrCVK3 H8fTAk4QmUGQFQQaDN00xiCcf2Jhv8XWWIzdIDlYVxUiDCJi3D3vY4bYnOrSX86fVWoP 44mbsx7S7j4cJzLZKATiezBdbKMEajBLgKuu312S14GBMfiUfGEDDjKlQ46BZAXIMuT0 hONA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature:dkim-filter; bh=kHbodGBgf5sQJA6py7zjWhCy6Bs6OTAtXOE0QUASalA=; fh=kDlMvdXjJ67as7fXJwQpX4exlPqtmzTL4elpL9Zbjrk=; b=HfoHADxlKr9Y/Syw+dnsLepnSxX6vaacE56lvQWRbq0oSKgI69h9eceIIPCaFu2Pm8 2FkFD0PkGKsD5JmdWqstvkux7Tl4CNQ72rEgBJWz6zZmCKpdyodVH2PE00HD8g3pLnt7 ceyRRCqaLzOesCLkPYfNlAbFTjbP5cst9OfrTyVo0EGebQYxOQRNTOiBRjXicLhBXoUv dhpxYn+k+D5CJgz7b0FrlOMvewKAX4MryQyO/yC2hgxB/Sie3GdC1f/SOk6iAAeR5AjW yZUPlci+jOA1Ka0VKFVau/4VJm8/S3QVvry9mGPaJZDvhTtiAN1QIEpN+cd3jZJqnu9E GQSA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@salutedevices.com header.s=mail header.b=vWkqEGTF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=salutedevices.com Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id kh8-20020a170903064800b001c42d60b9e6si3805012plb.112.2023.10.06.09.05.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Oct 2023 09:05:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; dkim=pass header.i=@salutedevices.com header.s=mail header.b=vWkqEGTF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=salutedevices.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 4E1D482DD0AB; Fri, 6 Oct 2023 09:05:08 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232923AbjJFQFC (ORCPT + 18 others); Fri, 6 Oct 2023 12:05:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54528 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232583AbjJFQFB (ORCPT ); Fri, 6 Oct 2023 12:05:01 -0400 Received: from mx1.sberdevices.ru (mx1.sberdevices.ru [37.18.73.165]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 33A9EA6; Fri, 6 Oct 2023 09:04:59 -0700 (PDT) Received: from p-infra-ksmg-sc-msk01 (localhost [127.0.0.1]) by mx1.sberdevices.ru (Postfix) with ESMTP id 8D026100003; Fri, 6 Oct 2023 19:04:57 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.sberdevices.ru 8D026100003 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=salutedevices.com; s=mail; t=1696608297; bh=kHbodGBgf5sQJA6py7zjWhCy6Bs6OTAtXOE0QUASalA=; h=From:To:Subject:Date:Message-ID:MIME-Version:Content-Type:From; b=vWkqEGTFSDT/03+RtxcUEPx86eLHUuwNITpDMCN/ED/FFKeaMdMCUaYUN7+uyHw77 IaVlPCcumijd8QOV6W6BtfXaIzqbeJmHCZil/z9sbINEnTqewvZrmh0iKwqsCEHGK2 AxmqDPZ8xmzKDK5gGgXsEVVTeKzlI+fKVkxKBVsyftygBoVxJETywWMMY1wNAXpqbL 6mLohns5GKTjC7LayjhiZTWKICO6ed5FxQ9b+J8AdhrNUmBUTFunziBT4PrQQbQpfH NZy2lfzSNz9vuXEHrFoAxgDIOmC2f1QWv8OCuNNq/rCkSr/HA18PmwCZf6OlgxR79+ HWIe2KyXiWESw== Received: from p-i-exch-sc-m01.sberdevices.ru (p-i-exch-sc-m01.sberdevices.ru [172.16.192.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.sberdevices.ru (Postfix) with ESMTPS; Fri, 6 Oct 2023 19:04:57 +0300 (MSK) Received: from localhost.localdomain (100.64.160.123) by p-i-exch-sc-m01.sberdevices.ru (172.16.192.107) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.30; Fri, 6 Oct 2023 19:04:57 +0300 From: Dmitry Rokosov To: , , , , , CC: , , , , , Martin Kurbanov , Dmitry Rokosov Subject: [PATCH v1 01/11] leds: aw200xx: fix write to DIM parameter Date: Fri, 6 Oct 2023 19:04:27 +0300 Message-ID: <20231006160437.15627-2-ddrokosov@salutedevices.com> X-Mailer: git-send-email 2.36.0 In-Reply-To: <20231006160437.15627-1-ddrokosov@salutedevices.com> References: <20231006160437.15627-1-ddrokosov@salutedevices.com> MIME-Version: 1.0 X-Originating-IP: [100.64.160.123] X-ClientProxiedBy: p-i-exch-sc-m01.sberdevices.ru (172.16.192.107) To p-i-exch-sc-m01.sberdevices.ru (172.16.192.107) X-KSMG-Rule-ID: 10 X-KSMG-Message-Action: clean X-KSMG-AntiSpam-Lua-Profiles: 180438 [Oct 06 2023] X-KSMG-AntiSpam-Version: 6.0.0.2 X-KSMG-AntiSpam-Envelope-From: ddrokosov@salutedevices.com X-KSMG-AntiSpam-Rate: 0 X-KSMG-AntiSpam-Status: not_detected X-KSMG-AntiSpam-Method: none X-KSMG-AntiSpam-Auth: dkim=none X-KSMG-AntiSpam-Info: LuaCore: 535 535 da804c0ea8918f802fc60e7a20ba49783d957ba2, {Tracking_from_domain_doesnt_match_to}, salutedevices.com:7.1.1;100.64.160.123:7.1.2;p-i-exch-sc-m01.sberdevices.ru:7.1.1,5.0.1;127.0.0.199:7.1.2;d41d8cd98f00b204e9800998ecf8427e.com:7.1.1, FromAlignment: s, ApMailHostAddress: 100.64.160.123 X-MS-Exchange-Organization-SCL: -1 X-KSMG-AntiSpam-Interceptor-Info: scan successful X-KSMG-AntiPhishing: Clean X-KSMG-LinksScanning: Clean X-KSMG-AntiVirus: Kaspersky Secure Mail Gateway, version 2.0.1.6960, bases: 2023/10/06 13:25:00 #22070343 X-KSMG-AntiVirus-Status: Clean, skipped X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Fri, 06 Oct 2023 09:05:08 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1779022773523207152 X-GMAIL-MSGID: 1779022773523207152 From: Martin Kurbanov If write only DIM value to the page 4, LED brightness will not be updated, as both DIM and FADE need to be written to the page 4. Therefore, write DIM to the page 1. Fixes: 36a87f371b7a ("leds: Add AW20xx driver") Signed-off-by: Martin Kurbanov Signed-off-by: Dmitry Rokosov --- drivers/leds/leds-aw200xx.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/leds/leds-aw200xx.c b/drivers/leds/leds-aw200xx.c index 96979b8e09b7..4c1e7caf8941 100644 --- a/drivers/leds/leds-aw200xx.c +++ b/drivers/leds/leds-aw200xx.c @@ -74,6 +74,10 @@ #define AW200XX_LED2REG(x, columns) \ ((x) + (((x) / (columns)) * (AW200XX_DSIZE_COLUMNS_MAX - (columns)))) +/* DIM current configuration register on page 1 */ +#define AW200XX_REG_DIM_PAGE1(x, columns) \ + AW200XX_REG(AW200XX_PAGE1, AW200XX_LED2REG(x, columns)) + /* * DIM current configuration register (page 4). * The even address for current DIM configuration. @@ -153,7 +157,8 @@ static ssize_t dim_store(struct device *dev, struct device_attribute *devattr, if (dim >= 0) { ret = regmap_write(chip->regmap, - AW200XX_REG_DIM(led->num, columns), dim); + AW200XX_REG_DIM_PAGE1(led->num, columns), + dim); if (ret) goto out_unlock; }