Message ID | 20231006112945.1491265-1-geert+renesas@glider.be |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:a888:0:b0:403:3b70:6f57 with SMTP id x8csp249530vqo; Fri, 6 Oct 2023 04:30:03 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHpgADJRKFoPFjG9Zf40dsbOW905DEFEY4MyauvMAztNEMBv32MVEoXpiOgL65Y3cnrlbDb X-Received: by 2002:a17:90b:1017:b0:279:1141:398b with SMTP id gm23-20020a17090b101700b002791141398bmr7682562pjb.26.1696591803288; Fri, 06 Oct 2023 04:30:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696591803; cv=none; d=google.com; s=arc-20160816; b=oKhlodEpzAtYdejl6q33JLD34E/gNIBq3UzGt1WUMvzzm9Go7PM/Qzs38j3nwT4WWK qXBEDHMdDxUNy2ir2WEfzOSQjC3Nek++9DofozBtracRwvGsbVtyPl9Pxe1zGn5lhLT5 z6316nVEHBy0qKP9bPJuns87lqFfF8y/TBEMhGRayWQ0yv+JX+ZDr1AOcm0dcGrYimOl A6eQRFe9/hN9Y9SrGjc/1Yij0hPXDUnQp1pFDL/QJIOazBdTxaNamZdBbjYibKbE6LVD 6X6izzgnX76aTd6qoBt5JcBoV+QU7y55ylU4jswcVRELUofmzBSZmX3XaLhPxnU7t0Cl GQ+g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=/jQvgg2UzlnrxUf5+FZiMUnEcwyWn2iVYUFM9/ZtcKw=; fh=li8ngQPMRUZQE3mdbH+/+w5hH6SAPtxZkURIyVidZRc=; b=ZLkTVoEQY6a3MaZ/IBFG2dmUGCL4aMtIdIYyBI4dHMumCar3GVsw2jUhYH0JA1Hkw3 sOwYRnc/AIpGEOsZzvAbeGU5x6EvK8jXUJdNp3EfZNYXlS5bX215kD6Y9WYWXQMyJ6ES xzONHE5NFlvLGalU3LmWhESCoUQRYOZFICeEAv3ze5LZv+zpAaoJ7JSZkIT6TsqiGoI7 WJPplTan2Pok6RvgONEMO2SzUtgrL0vu5+dx+Aa0xOWL2zsXbHA2Rxo7x3GC+K5HS1h6 2K58uT6EvysJVu8ZqTd/RLhhR7un4ROGb84HtjHNYn3OD7ASnvFFcRvRK6KrRFwXQjOv 0t/g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id x2-20020a17090a8a8200b00277816efefasi3466876pjn.106.2023.10.06.04.30.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Oct 2023 04:30:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 8A5D680C5F95; Fri, 6 Oct 2023 04:30:02 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231444AbjJFL3v (ORCPT <rfc822;ezelljr.billy@gmail.com> + 18 others); Fri, 6 Oct 2023 07:29:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54292 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230138AbjJFL3u (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Fri, 6 Oct 2023 07:29:50 -0400 Received: from albert.telenet-ops.be (albert.telenet-ops.be [IPv6:2a02:1800:110:4::f00:1a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 86811CA for <linux-kernel@vger.kernel.org>; Fri, 6 Oct 2023 04:29:48 -0700 (PDT) Received: from ramsan.of.borg ([IPv6:2a02:1810:ac12:ed40:5e53:403c:300c:38ca]) by albert.telenet-ops.be with bizsmtp id ubVm2A00C0nPCdM06bVmLu; Fri, 06 Oct 2023 13:29:46 +0200 Received: from rox.of.borg ([192.168.97.57]) by ramsan.of.borg with esmtp (Exim 4.95) (envelope-from <geert@linux-m68k.org>) id 1qoj1D-005Kwp-SZ; Fri, 06 Oct 2023 13:29:46 +0200 Received: from geert by rox.of.borg with local (Exim 4.95) (envelope-from <geert@linux-m68k.org>) id 1qoj1e-006Fws-58; Fri, 06 Oct 2023 13:29:46 +0200 From: Geert Uytterhoeven <geert+renesas@glider.be> To: Mark Brown <broonie@kernel.org> Cc: linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, Geert Uytterhoeven <geert+renesas@glider.be>, kernel test robot <lkp@intel.com> Subject: [PATCH] spi: mpc52xx-psc: Make mpc52xx_psc_spi_transfer_one_message() static Date: Fri, 6 Oct 2023 13:29:45 +0200 Message-Id: <20231006112945.1491265-1-geert+renesas@glider.be> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.6 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE, SPF_NONE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Fri, 06 Oct 2023 04:30:02 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1779005446748067213 X-GMAIL-MSGID: 1779005446748067213 |
Series |
spi: mpc52xx-psc: Make mpc52xx_psc_spi_transfer_one_message() static
|
|
Commit Message
Geert Uytterhoeven
Oct. 6, 2023, 11:29 a.m. UTC
With W=1:
drivers/spi/spi-mpc52xx-psc.c:178:5: warning: no previous prototype for ‘mpc52xx_psc_spi_transfer_one_message’ [-Wmissing-prototypes]
178 | int mpc52xx_psc_spi_transfer_one_message(struct spi_controller *ctlr,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
mpc52xx_psc_spi_transfer_one_message() is only used inside the file that
defines it. Hence fix this by making it static.
Fixes: 145cfc3840e5931a ("spi: mpc52xx-psc: Switch to using core message queue")
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202310061815.7Rtyi4hs-lkp@intel.com/
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
drivers/spi/spi-mpc52xx-psc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Comments
On Fri, 06 Oct 2023 13:29:45 +0200, Geert Uytterhoeven wrote: > With W=1: > > drivers/spi/spi-mpc52xx-psc.c:178:5: warning: no previous prototype for ‘mpc52xx_psc_spi_transfer_one_message’ [-Wmissing-prototypes] > 178 | int mpc52xx_psc_spi_transfer_one_message(struct spi_controller *ctlr, > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > mpc52xx_psc_spi_transfer_one_message() is only used inside the file that > defines it. Hence fix this by making it static. > > [...] Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next Thanks! [1/1] spi: mpc52xx-psc: Make mpc52xx_psc_spi_transfer_one_message() static commit: 881fe6ed21e8c7e60095aabc274c4f2bfdc87c5e All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark
diff --git a/drivers/spi/spi-mpc52xx-psc.c b/drivers/spi/spi-mpc52xx-psc.c index 78405cb45c961ff9..28f06122edac5632 100644 --- a/drivers/spi/spi-mpc52xx-psc.c +++ b/drivers/spi/spi-mpc52xx-psc.c @@ -175,8 +175,8 @@ static int mpc52xx_psc_spi_transfer_rxtx(struct spi_device *spi, return 0; } -int mpc52xx_psc_spi_transfer_one_message(struct spi_controller *ctlr, - struct spi_message *m) +static int mpc52xx_psc_spi_transfer_one_message(struct spi_controller *ctlr, + struct spi_message *m) { struct spi_device *spi; struct spi_transfer *t = NULL;