From patchwork Thu Oct 5 20:55:57 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ondrej Zary X-Patchwork-Id: 149026 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:612c:2016:b0:403:3b70:6f57 with SMTP id fe22csp561263vqb; Thu, 5 Oct 2023 13:56:46 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFe5xhV+tMao7xv6QbgODEyoo5bkXN5Rfx1EU8JAvkEZYf7vjJYgRVP/Hn4E6F0zWYZX9ap X-Received: by 2002:a17:902:6b04:b0:1b7:e86f:7631 with SMTP id o4-20020a1709026b0400b001b7e86f7631mr6174571plk.19.1696539405838; Thu, 05 Oct 2023 13:56:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696539405; cv=none; d=google.com; s=arc-20160816; b=GvoCINayrksiSM5u0h0CEeLxZqqVxdAQ84Ytp8l4h7BcSO5viyY1MlAJZ+2Lawau2s +vtSgD+qg0QmdEENjZGIyRkXxn2VeO0Wmeory76NgWy2mAtKUy4RW6KDKls9HA5Qq6bn wEv7Ki39BfQcZ41vIYQ3kXdcbD7E4633omUe2HwAXnTeRNiTxTsVWRvj2cpPdW7dt6fd 2MW0XS3WnTtzWM4XXVCcNGnVaSg34mf1M944ISjfxDDEw5yMp0FG/p+NF1c2kO1ACVUI Sr9AnKNAuT5wNtOAjTn3LR4gyX/jvtZPXqosTc1pY3W25wIt5+B7PYwf6nxwDjk9cib6 M/Aw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=ojMs5e5+vivdenL0B4z8IB/laNKWeerQnh4larZP0Yc=; fh=0Kn3fvtcnx6vVXAlmep6T/Q5RzgM4nGjbgzeaq8HuW4=; b=MDSF2D/OMSlzUb+bAGv/9//wtmm9L6zsqWPJyBmDZdFMqB1g7Fsq2eWgpvTj1r5KTA oXOl2UK/DVigoTXHfvM84dTsUxVcGMcwDWxEpxcF2XOQntyIqv2b4cTfeAqAjDrxO5eB 9s2/tgv2kB5rQu1rLxpo0vEEpPwPSRTohZx9JDONWfvQgIxAa818qof1gA2bqofsQqFW lKZB86a9x+zMHNw8YJc5YfPqaoMOjf57bTturgxvehPAlV1QodUSJY/CqJpT6Lv2jy84 obDzX5ypPMkfVJ20u7EObe3HZB7f9lUkYqwJESsj3IzpZo4PzYCdBFdtL5kk+KB2630B e5DQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from morse.vger.email (morse.vger.email. [23.128.96.31]) by mx.google.com with ESMTPS id u8-20020a1709026e0800b001c60de17b5esi2187054plk.118.2023.10.05.13.56.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Oct 2023 13:56:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by morse.vger.email (Postfix) with ESMTP id 3AB418077924; Thu, 5 Oct 2023 13:56:43 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at morse.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231716AbjJEU4O (ORCPT + 18 others); Thu, 5 Oct 2023 16:56:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46914 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230137AbjJEU4J (ORCPT ); Thu, 5 Oct 2023 16:56:09 -0400 Received: from hosting.gsystem.sk (hosting.gsystem.sk [212.5.213.30]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id CCC06A6; Thu, 5 Oct 2023 13:56:07 -0700 (PDT) Received: from gsql.ggedos.sk (off-20.infotel.telecom.sk [212.5.213.20]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by hosting.gsystem.sk (Postfix) with ESMTPSA id B82437A0430; Thu, 5 Oct 2023 22:56:06 +0200 (CEST) From: Ondrej Zary To: Damien Le Moal , Sudip Mukherjee Cc: Christoph Hellwig , Sergey Shtylyov , Tim Waugh , linux-parport@lists.infradead.org, linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 2/4] ata: pata_parport: implement set_devctl Date: Thu, 5 Oct 2023 22:55:57 +0200 Message-Id: <20231005205559.6504-3-linux@zary.sk> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20231005205559.6504-1-linux@zary.sk> References: <20231005205559.6504-1-linux@zary.sk> MIME-Version: 1.0 X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Thu, 05 Oct 2023 13:56:43 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1778950503614658558 X-GMAIL-MSGID: 1778950503614658558 Add missing ops->sff_set_devctl implementation. Fixes: 246a1c4c6b7f ("ata: pata_parport: add driver (PARIDE replacement)") Cc: stable@vger.kernel.org Signed-off-by: Ondrej Zary Reviewed-by: Sergey Shtylyov --- drivers/ata/pata_parport/pata_parport.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/drivers/ata/pata_parport/pata_parport.c b/drivers/ata/pata_parport/pata_parport.c index 258d189f42e5..cf87bbb52f1f 100644 --- a/drivers/ata/pata_parport/pata_parport.c +++ b/drivers/ata/pata_parport/pata_parport.c @@ -51,6 +51,13 @@ static void pata_parport_dev_select(struct ata_port *ap, unsigned int device) ata_sff_pause(ap); } +static void pata_parport_set_devctl(struct ata_port *ap, u8 ctl) +{ + struct pi_adapter *pi = ap->host->private_data; + + pi->proto->write_regr(pi, 1, 6, ctl); +} + static bool pata_parport_devchk(struct ata_port *ap, unsigned int device) { struct pi_adapter *pi = ap->host->private_data; @@ -252,6 +259,7 @@ static struct ata_port_operations pata_parport_port_ops = { .hardreset = NULL, .sff_dev_select = pata_parport_dev_select, + .sff_set_devctl = pata_parport_set_devctl, .sff_check_status = pata_parport_check_status, .sff_check_altstatus = pata_parport_check_altstatus, .sff_tf_load = pata_parport_tf_load,