From patchwork Thu Oct 5 20:55:56 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ondrej Zary X-Patchwork-Id: 149025 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:612c:2016:b0:403:3b70:6f57 with SMTP id fe22csp561133vqb; Thu, 5 Oct 2023 13:56:23 -0700 (PDT) X-Google-Smtp-Source: AGHT+IF1+GiiOu5WwLq8yIHOaRvcWoDW77xtc+vtb3ENpwD5+gb8Ah31YfCDvRDWoRx6LTvEay6I X-Received: by 2002:a05:6358:419d:b0:135:4003:7857 with SMTP id w29-20020a056358419d00b0013540037857mr4418955rwc.31.1696539382898; Thu, 05 Oct 2023 13:56:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696539382; cv=none; d=google.com; s=arc-20160816; b=MDzBdphQhHtDP27V+WJfddecB0d74PPvTPybT9C2nbkgT2e9Qx28+/m9Avv7ZM1kfj VyhbZqTvCSip0GFkQIQs2voic+sC3qq77/l19i4NgL6MxzUWgcl38cCiYP1KB4Xnu0s+ RAytk/cbruLqM5x3WMMm5kUxHW1Ee+YhfVnEu7n0mi+W1QM/goZBxc9Ti4Mc5c8Q0iMn Y5LV0Gzfzb7ChpnB6zhAFx/LqQuzp7+BapkiCI2SMrc2HQiunuGEgZBZu51jUlwQJ6wm Pg6JcWug2adcb2XpzV5tKIsXQi95VMVaXqlOj1CCooakKwp3zsAeGCzqhv0KbG+AMbnp mNaA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=7P2SxlyPBbfA+FeABtKIEP+MsuGzRfiOYNXgiytXVjU=; fh=0Kn3fvtcnx6vVXAlmep6T/Q5RzgM4nGjbgzeaq8HuW4=; b=Xs6d2JmBd0piTsPoUDXs2W1DonaMSDAuxivno9Eqi9vnmn5nnA0i+MTw6gyNdaJbh6 gqDbl3milGNV2OLM5rwHP37l9Xi3NuVH1no/it3OAZa8Ld2ftMx0wl3/gTPnmRD2RteF 02PmMX/abYVM8gJufh7Enw5Lkcylmu3FfHBZQTzwd72gRF6zaxvwojHQfadQg0Ja7tXC s23Dbon9ViEa7en2zp8S1/Mz6wrAjSpgBBlmAMVrhvsjMiASfpYZ5HgcZEuz/C8K7txk SU1H2U8ADmsNxTf0uu3QdyO9k2opAEAzCqjV3CdSqOqH9zlIHsV/fl3AuQK3F2/oMdhT X/BA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from morse.vger.email (morse.vger.email. [23.128.96.31]) by mx.google.com with ESMTPS id z2-20020a1709027e8200b001bb2d95f2a7si2176531pla.267.2023.10.05.13.56.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Oct 2023 13:56:22 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by morse.vger.email (Postfix) with ESMTP id 220AA807792C; Thu, 5 Oct 2023 13:56:18 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at morse.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230521AbjJEU4K (ORCPT + 18 others); Thu, 5 Oct 2023 16:56:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46900 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230029AbjJEU4J (ORCPT ); Thu, 5 Oct 2023 16:56:09 -0400 Received: from hosting.gsystem.sk (hosting.gsystem.sk [212.5.213.30]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 9E18C9F; Thu, 5 Oct 2023 13:56:07 -0700 (PDT) Received: from gsql.ggedos.sk (off-20.infotel.telecom.sk [212.5.213.20]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by hosting.gsystem.sk (Postfix) with ESMTPSA id 95EEE7A01D5; Thu, 5 Oct 2023 22:56:06 +0200 (CEST) From: Ondrej Zary To: Damien Le Moal , Sudip Mukherjee Cc: Christoph Hellwig , Sergey Shtylyov , Tim Waugh , linux-parport@lists.infradead.org, linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/4] ata: pata_parport: fix pata_parport_devchk Date: Thu, 5 Oct 2023 22:55:56 +0200 Message-Id: <20231005205559.6504-2-linux@zary.sk> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20231005205559.6504-1-linux@zary.sk> References: <20231005205559.6504-1-linux@zary.sk> MIME-Version: 1.0 X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Thu, 05 Oct 2023 13:56:18 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1778950480060189284 X-GMAIL-MSGID: 1778950480060189284 There's a 'x' missing in 0x55 in pata_parport_devchk(), causing the detection to always fail. Fix it. Fixes: 246a1c4c6b7f ("ata: pata_parport: add driver (PARIDE replacement)") Cc: stable@vger.kernel.org Signed-off-by: Ondrej Zary Reviewed-by: Sergey Shtylyov --- drivers/ata/pata_parport/pata_parport.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/ata/pata_parport/pata_parport.c b/drivers/ata/pata_parport/pata_parport.c index 1af64d435d3c..258d189f42e5 100644 --- a/drivers/ata/pata_parport/pata_parport.c +++ b/drivers/ata/pata_parport/pata_parport.c @@ -64,7 +64,7 @@ static bool pata_parport_devchk(struct ata_port *ap, unsigned int device) pi->proto->write_regr(pi, 0, ATA_REG_NSECT, 0xaa); pi->proto->write_regr(pi, 0, ATA_REG_LBAL, 0x55); - pi->proto->write_regr(pi, 0, ATA_REG_NSECT, 055); + pi->proto->write_regr(pi, 0, ATA_REG_NSECT, 0x55); pi->proto->write_regr(pi, 0, ATA_REG_LBAL, 0xaa); nsect = pi->proto->read_regr(pi, 0, ATA_REG_NSECT);