From patchwork Thu Oct 5 19:24:37 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ondrej Zary X-Patchwork-Id: 149002 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:612c:2016:b0:403:3b70:6f57 with SMTP id fe22csp518387vqb; Thu, 5 Oct 2023 12:25:02 -0700 (PDT) X-Google-Smtp-Source: AGHT+IELuNSoSiDywXV6RxouPhyJKbRTJolQ7YhxWinxixlh0Q230JHcViciMoTMz2VOlfaN50Sy X-Received: by 2002:a17:902:da83:b0:1c6:e1d:8be0 with SMTP id j3-20020a170902da8300b001c60e1d8be0mr6184686plx.2.1696533901756; Thu, 05 Oct 2023 12:25:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696533901; cv=none; d=google.com; s=arc-20160816; b=rvcFo0V/wP63lbaBHqdgjFO0vV/gPHBgqeJh2Y5aVsoDvy4+l1VKaLj2lTW8YT3B7r jA6e8UdQ+5XIbORhuAfe7OHKo5nCydOk0c1stMFWXaP2snZvJckdZXuDVTo631m7I1GK 8OpKwCRVU5/4xesGBEeqaf75rNr652uavJA4q3gSgzNoYJhCZzYHvDWQeaw2Q0VifZKF 92gjOj2R9lUlbt4AfB7yBpQhPuX0lBHTgeeXvY21G/hAvKYxgCjVr0OF3oIAPcq2yZAx y6CwCtOYKIFXzjonsdOtjrDKkeCFaBJmOtQBBelnorfvWKurnek8Ar6KMO+Tq2bkqX7m Gpsw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=Eh6I++W8dr2E/fFHjBPO19b3/O+RIh9dC9Qrk5i3ZhM=; fh=0Kn3fvtcnx6vVXAlmep6T/Q5RzgM4nGjbgzeaq8HuW4=; b=AH6sqjxlbPCWSo2b87jaq9YyAUTQtn7xoJ99Li35YTNqAuaeXnaAkwr9t2LMFgAFTf xx73ciOBKqxwmvFESDCEVIBxwg4v7MZH/OwUYiguaAvWRyFoCvtBqZl4u+77CpB/hUn6 VhRUjlI4AfJrJizDUlRRWhjyig2hl3/No17m+rRUhIUpOAwLASHRuxzgn48YXQxWd3NI 60yK/ofWXsCVkF8ZGh2Fh7n6bnjQHj/znGFzQLWameD3H45mUd30FzCZqv23LkhjdMS9 Iyg7xDQkRRBhVdwM485nCO4Rf4319RixPSTHdDa0COKD4VzMnDz9MQ/YbbjGUv2FusJn kDOw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id kz7-20020a170902f9c700b001b89fd6bec4si1972314plb.144.2023.10.05.12.25.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Oct 2023 12:25:01 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id F08B082E750B; Thu, 5 Oct 2023 12:25:00 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231268AbjJETY6 (ORCPT + 18 others); Thu, 5 Oct 2023 15:24:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33858 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231224AbjJETY4 (ORCPT ); Thu, 5 Oct 2023 15:24:56 -0400 Received: from hosting.gsystem.sk (hosting.gsystem.sk [212.5.213.30]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 2D08AE5; Thu, 5 Oct 2023 12:24:50 -0700 (PDT) Received: from gsql.ggedos.sk (off-20.infotel.telecom.sk [212.5.213.20]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by hosting.gsystem.sk (Postfix) with ESMTPSA id BA0347A0319; Thu, 5 Oct 2023 21:24:47 +0200 (CEST) From: Ondrej Zary To: Damien Le Moal , Sudip Mukherjee Cc: Christoph Hellwig , Sergey Shtylyov , Tim Waugh , linux-parport@lists.infradead.org, linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/4] ata: pata_parport: fix pata_parport_devchk Date: Thu, 5 Oct 2023 21:24:37 +0200 Message-Id: <20231005192440.4047-2-linux@zary.sk> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20231005192440.4047-1-linux@zary.sk> References: <20231005192440.4047-1-linux@zary.sk> MIME-Version: 1.0 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Thu, 05 Oct 2023 12:25:01 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1778944732309723275 X-GMAIL-MSGID: 1778944732309723275 There's a 'x' missing in 0x55 in pata_parport_devchk(), causing the detection to always fail. Fix it. Fixes: 246a1c4c6b7f ("ata: pata_parport: add driver (PARIDE replacement)") Cc: stable@vger.kernel.org Signed-off-by: Ondrej Zary Reviewed-by: Sergey Shtylyov --- drivers/ata/pata_parport/pata_parport.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/ata/pata_parport/pata_parport.c b/drivers/ata/pata_parport/pata_parport.c index 1af64d435d3c..258d189f42e5 100644 --- a/drivers/ata/pata_parport/pata_parport.c +++ b/drivers/ata/pata_parport/pata_parport.c @@ -64,7 +64,7 @@ static bool pata_parport_devchk(struct ata_port *ap, unsigned int device) pi->proto->write_regr(pi, 0, ATA_REG_NSECT, 0xaa); pi->proto->write_regr(pi, 0, ATA_REG_LBAL, 0x55); - pi->proto->write_regr(pi, 0, ATA_REG_NSECT, 055); + pi->proto->write_regr(pi, 0, ATA_REG_NSECT, 0x55); pi->proto->write_regr(pi, 0, ATA_REG_LBAL, 0xaa); nsect = pi->proto->read_regr(pi, 0, ATA_REG_NSECT);