From patchwork Wed Oct 4 18:52:33 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ondrej Zary X-Patchwork-Id: 148468 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:612c:254a:b0:403:3b70:6f57 with SMTP id hf10csp338857vqb; Wed, 4 Oct 2023 11:53:34 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHLguDXo2ElPpk8Ubm3u0UCNuP2hZgjvj/Jyb0IKgqCeVmuZ4sgzsO/eSQHAmLjv3QWpxJF X-Received: by 2002:a05:6a20:7d98:b0:161:28e0:9abf with SMTP id v24-20020a056a207d9800b0016128e09abfmr3533084pzj.19.1696445614286; Wed, 04 Oct 2023 11:53:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696445614; cv=none; d=google.com; s=arc-20160816; b=rpazgSdMsA3SDXbY0VlbvVqcE2OOok8BIzE8go8VADKykMKaLI89aZJQiQviSi2kJB +rJrqOLdGCWSUP0HNfsaXMHBMZpuKmHAUxvZ3D6kTJi2XcxpgGnzjjzhN6SLJAvAGeGN CozT7nmcxIuEwNnPv8ex2rCSQdLj788BPqD5wUF15wpRcSlfRKrJnpayius8evsd8GXr WfGPdZM1i9aLW7i7pDohh4D/Oxxj4cEbZc+yAjzRiNH0R3wpwO9GsmxVq47dwd/T8hUJ tXQys9J8etpluG+/LYZ/HIRBj1mKprZzQdS3dcup7uo5PiiCzlFzfgiC0CrNzeCVM4D+ 1bbg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=4lqZ8PHjbkjq1dLhJLmf4HFUK26YsM51zmaiDBjQJHY=; fh=0Kn3fvtcnx6vVXAlmep6T/Q5RzgM4nGjbgzeaq8HuW4=; b=zTWX6LU+x0OE1t4IOc1LT0y1cLy4gaVGhuieR2mIlxJelbxODAYsYlF7YT9qWI9deK qgG36EihNrLWj3C0Re2IBWxj21xGGjOm6UhtHSdfCpnE07DAuo7uEB7o4W0vgWWaJViO mpCqILTUlXCQFqGQCLlBPIUq3mFBZdSi9OcJ1Q3AzKNFrdikYjhXUrd0Ysif9YAH8Sgh wEoKKT9F+EHp8ZUyh3OThh1+xv4DlZw2EJgSsSIn9yZ2JJ+Lv00wOjk6tqL9LYNM3mYP A5WhLLXUTgbI7GBn+vE8kqmk8XNbAe8rzgZJYrrhJd+bKywG9rb/BZv9W/RM1eMzAoyO qqCQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from snail.vger.email (snail.vger.email. [2620:137:e000::3:7]) by mx.google.com with ESMTPS id p10-20020a056a000a0a00b0068feb1cf986si4474353pfh.241.2023.10.04.11.53.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Oct 2023 11:53:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 8BF5B81A3349; Wed, 4 Oct 2023 11:53:33 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244501AbjJDSxX (ORCPT + 19 others); Wed, 4 Oct 2023 14:53:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46872 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244502AbjJDSxM (ORCPT ); Wed, 4 Oct 2023 14:53:12 -0400 Received: from hosting.gsystem.sk (hosting.gsystem.sk [212.5.213.30]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 360EEEC; Wed, 4 Oct 2023 11:52:46 -0700 (PDT) Received: from gsql.ggedos.sk (off-20.infotel.telecom.sk [212.5.213.20]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by hosting.gsystem.sk (Postfix) with ESMTPSA id 76F507A0648; Wed, 4 Oct 2023 20:52:45 +0200 (CEST) From: Ondrej Zary To: Damien Le Moal , Sudip Mukherjee Cc: Christoph Hellwig , Sergey Shtylyov , Tim Waugh , linux-parport@lists.infradead.org, linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 2/4] ata: pata_parport: implement set_devctl Date: Wed, 4 Oct 2023 20:52:33 +0200 Message-Id: <20231004185235.27417-3-linux@zary.sk> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20231004185235.27417-1-linux@zary.sk> References: <20231004185235.27417-1-linux@zary.sk> MIME-Version: 1.0 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Wed, 04 Oct 2023 11:53:33 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1778852156623711233 X-GMAIL-MSGID: 1778852156623711233 Add missing ops->sff_set_devctl implementation. Fixes: 246a1c4c6b7f ("ata: pata_parport: add driver (PARIDE replacement)") Reviewed-by: Sergey Shtylyov Signed-off-by: Ondrej Zary --- drivers/ata/pata_parport/pata_parport.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/drivers/ata/pata_parport/pata_parport.c b/drivers/ata/pata_parport/pata_parport.c index 258d189f42e5..cf87bbb52f1f 100644 --- a/drivers/ata/pata_parport/pata_parport.c +++ b/drivers/ata/pata_parport/pata_parport.c @@ -51,6 +51,13 @@ static void pata_parport_dev_select(struct ata_port *ap, unsigned int device) ata_sff_pause(ap); } +static void pata_parport_set_devctl(struct ata_port *ap, u8 ctl) +{ + struct pi_adapter *pi = ap->host->private_data; + + pi->proto->write_regr(pi, 1, 6, ctl); +} + static bool pata_parport_devchk(struct ata_port *ap, unsigned int device) { struct pi_adapter *pi = ap->host->private_data; @@ -252,6 +259,7 @@ static struct ata_port_operations pata_parport_port_ops = { .hardreset = NULL, .sff_dev_select = pata_parport_dev_select, + .sff_set_devctl = pata_parport_set_devctl, .sff_check_status = pata_parport_check_status, .sff_check_altstatus = pata_parport_check_altstatus, .sff_tf_load = pata_parport_tf_load,