From patchwork Wed Oct 4 18:52:32 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ondrej Zary X-Patchwork-Id: 148467 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:612c:254a:b0:403:3b70:6f57 with SMTP id hf10csp338825vqb; Wed, 4 Oct 2023 11:53:30 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHVdhkJzSalXtGhqR0QLzsRe707hMF5ZEv4HAAsGmq2awhpDmaDKD5Dd1iJaFd6k2uduPdX X-Received: by 2002:a05:6e02:12e3:b0:350:f442:9a4d with SMTP id l3-20020a056e0212e300b00350f4429a4dmr3547866iln.28.1696445610403; Wed, 04 Oct 2023 11:53:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696445610; cv=none; d=google.com; s=arc-20160816; b=P8jhD6r2mZn0AwgNTyJ/ulsjSvI2X8GhfwpZXLvZcexiXj9zpcMFYkWA/7/i/E8LfD mME8DGxTbNVbwFiYD0WFKoyds3G0JPpD0LOtJRVDVZY85Gbx1GZGyGYTRM+jN45fRClj X12m1RXlpg3iOQctbzhtYQJ6kVkbB0tRKWtNkhZ3hagszz8A256eTqKmTYMCqF8igaeH XtmGZi5R4RORYEuekv5zwXVZU+5BuOjfxm0IhCIJb+16dHJT9Ajaa8lp8XZdteSwqeI8 oIm5/H8ZJ6WjyNf6C/HLY+cSiUw+bccqBRqeVU0REt5EP/1xZAm4RQcrHTDAEtPTtexb 8WIQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=ya1DQzsTCRPItoC1SxpEqyu8g285dVwNlEbYUYINxCo=; fh=0Kn3fvtcnx6vVXAlmep6T/Q5RzgM4nGjbgzeaq8HuW4=; b=BoS90dgGdiXEcJwcIVP07PKgPplIcm2le5uEEU9KG2q2gi4XbXyqeYX6x8odWBoUKS IZVzr7mbLeQ8ki6miV6bVjWMj6g1UTAmFAZGdZbvYycrabf8gyR4h95Imft0rhqTNy+X Su/+4HoFrFvgYwOpdPMShyPL6z3XwBc1q39Y4ScyI2qzJyhZni1MXn9JEYtmPb4BePBN +FdL4dGdfiCvO2LJyHOKtKu6XOwTZpKSC2cEzNh0uRVZrdtFNZ/tKIPIcbwVO+PdSaHF igNvsgagS1ryeek4hXvs80eY7UYZFIRHZkXmrXEGcPg8M9VqULyUTimuJPJobNjnqm/1 OOcQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id b19-20020a6567d3000000b0056a1a149034si4420439pgs.650.2023.10.04.11.53.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Oct 2023 11:53:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 9247F81352A0; Wed, 4 Oct 2023 11:53:29 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244635AbjJDSxT (ORCPT + 19 others); Wed, 4 Oct 2023 14:53:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46858 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244503AbjJDSxM (ORCPT ); Wed, 4 Oct 2023 14:53:12 -0400 Received: from hosting.gsystem.sk (hosting.gsystem.sk [212.5.213.30]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 369C1EE; Wed, 4 Oct 2023 11:52:46 -0700 (PDT) Received: from gsql.ggedos.sk (off-20.infotel.telecom.sk [212.5.213.20]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by hosting.gsystem.sk (Postfix) with ESMTPSA id 657617A062F; Wed, 4 Oct 2023 20:52:45 +0200 (CEST) From: Ondrej Zary To: Damien Le Moal , Sudip Mukherjee Cc: Christoph Hellwig , Sergey Shtylyov , Tim Waugh , linux-parport@lists.infradead.org, linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/4] ata: pata_parport: fix pata_parport_devchk Date: Wed, 4 Oct 2023 20:52:32 +0200 Message-Id: <20231004185235.27417-2-linux@zary.sk> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20231004185235.27417-1-linux@zary.sk> References: <20231004185235.27417-1-linux@zary.sk> MIME-Version: 1.0 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Wed, 04 Oct 2023 11:53:29 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1778852152024373544 X-GMAIL-MSGID: 1778852152024373544 There's a 'x' missing in 0x55 in pata_parport_devchk(), causing the detection to always fail. Fix it. Fixes: 246a1c4c6b7f ("ata: pata_parport: add driver (PARIDE replacement)") Signed-off-by: Ondrej Zary --- drivers/ata/pata_parport/pata_parport.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/ata/pata_parport/pata_parport.c b/drivers/ata/pata_parport/pata_parport.c index 1af64d435d3c..258d189f42e5 100644 --- a/drivers/ata/pata_parport/pata_parport.c +++ b/drivers/ata/pata_parport/pata_parport.c @@ -64,7 +64,7 @@ static bool pata_parport_devchk(struct ata_port *ap, unsigned int device) pi->proto->write_regr(pi, 0, ATA_REG_NSECT, 0xaa); pi->proto->write_regr(pi, 0, ATA_REG_LBAL, 0x55); - pi->proto->write_regr(pi, 0, ATA_REG_NSECT, 055); + pi->proto->write_regr(pi, 0, ATA_REG_NSECT, 0x55); pi->proto->write_regr(pi, 0, ATA_REG_LBAL, 0xaa); nsect = pi->proto->read_regr(pi, 0, ATA_REG_NSECT);