From patchwork Wed Oct 4 18:39:06 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bartosz Golaszewski X-Patchwork-Id: 148454 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:612c:254a:b0:403:3b70:6f57 with SMTP id hf10csp332897vqb; Wed, 4 Oct 2023 11:41:01 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHEA0+tqhGk0XaqSYnFIWRJGlg1exBxuX28d8Hf+iuFtxmFnU/Zd4UrEz3X2V5XhSDdKqg2 X-Received: by 2002:a05:6a20:3941:b0:15e:7323:5bf3 with SMTP id r1-20020a056a20394100b0015e73235bf3mr565020pzg.26.1696444860818; Wed, 04 Oct 2023 11:41:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696444860; cv=none; d=google.com; s=arc-20160816; b=kpOyaqxTNaBfVxrZf38cIu3yZQWA3kH2/rqATTYbgfiGz/yPIjKUdhcCQhbxgEorsz GI0meEzLfarJiXafByFRe3K/zIVRCulH3yxJaR3scFtcQ1ZSstyvwUawLJBwBUr164f+ keo32iWbFW5Tes9hceGEJ7GFToz7/w5zkwE0sikjw+D+w8I1rBNxOGFa9eD7WWALejiq +HYyB7hyNTRo+OB8rc4g6VTBZUFaa+CcbZzrkCUDva8aAdJqYuuMFS+k+iJhGnQZE+NM dh0hcwmvVpXVhy8vkHBc22gKwo6IzqrarmjRtE3pYpCEToWVOSlkF6v64297amBArJj+ fw1Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=QA+Y3LssOPJ3KAADHkTgfkM+4lfsQSRUByKy5qehR+I=; fh=2cIJSp19K6VxKNwH4A2GMjrvqdLphw9vkHrTts2BE/4=; b=b8xV4TdFwapMNW3jngd3zQdTOw6HtDEtkpYiFNVXlA6Uqd7Mgc9erlcavjtfG0RU5D fJ7tPcc8k/B28YaBlUaIALFwELfbn+IqTfTeGG3l9jLecz6aXX6/3Dwt+UBl7j2FGUm4 0xvQmj5btJjBKnQN42Gwqn/enRCPXgOs1J/rBgIh6zCLJoyq0LV9lTf0By+xd4w5Saic hkoFdTlxx26pWET06unIPQR8AQy25/ATiVLS7ZdHW6qBIqQnF5LnH0VppxQRi5dMdgD3 cjQ+YP6FQ0uRtgQHeuuXvodlLpkZICebZmJHyAKI4377JTq8+iwNpXWpo/yREpX8IMU7 aziw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@bgdev-pl.20230601.gappssmtp.com header.s=20230601 header.b=l0c7FjqS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from groat.vger.email (groat.vger.email. [2620:137:e000::3:5]) by mx.google.com with ESMTPS id k6-20020a633d06000000b00565e42df278si4163427pga.759.2023.10.04.11.41.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Oct 2023 11:41:00 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5; Authentication-Results: mx.google.com; dkim=pass header.i=@bgdev-pl.20230601.gappssmtp.com header.s=20230601 header.b=l0c7FjqS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id CF9FC80D6AFB; Wed, 4 Oct 2023 11:40:04 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244523AbjJDSjU (ORCPT + 19 others); Wed, 4 Oct 2023 14:39:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59660 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243780AbjJDSjT (ORCPT ); Wed, 4 Oct 2023 14:39:19 -0400 Received: from mail-wr1-x431.google.com (mail-wr1-x431.google.com [IPv6:2a00:1450:4864:20::431]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2966FC4 for ; Wed, 4 Oct 2023 11:39:15 -0700 (PDT) Received: by mail-wr1-x431.google.com with SMTP id ffacd0b85a97d-3247cefa13aso162340f8f.1 for ; Wed, 04 Oct 2023 11:39:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1696444753; x=1697049553; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=QA+Y3LssOPJ3KAADHkTgfkM+4lfsQSRUByKy5qehR+I=; b=l0c7FjqSkm9u34rUPxY50qEdwFtPVWe0pfCN73L/g90h14reeFXkfq3V3kq6XpAFN4 Xh264Z3qgcHbFveEmK7lTjC2G54+t63+iCtOQV8zdSnZFX9ZVr3QxPfNSetxah0l/nTK Pl0anrgN+hkecZNIoPP4WKa6MMM4nBOiaAG6k2CfmbFroaFlUhGRFCSWCgLXjNcUxddi vUu/++ICtomys5urCSyWUQgsJ1u95bkvSJUfa2mwo5+F+8+aR+6NgK7HAs7XwDZt/5mJ ejQ0QfZ+IqV+9fCZXCL8QQ4VyVPXhNCoq0WPQR4rwnXRKfYZd3OElvzs57nFRuz1L9je sqqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696444753; x=1697049553; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=QA+Y3LssOPJ3KAADHkTgfkM+4lfsQSRUByKy5qehR+I=; b=lhta0f3V+ryYJiAN+S5ozBb1MOc4YCtgs9ys8WDNa2Kx43wckE4s7Bnpdr3MnMQ0Uc yZ81UEC9WziwBDcmO5voa1zhtXj4oapUAPdrEJpoBv6oQKnbGPxmfD/fjVAKwzDAiOex UuM9wcVvspDB2YWTzkq9ZyEZzKoIDiFKoXyTrtAH7jKuDIB7yEj7mbyDuxoMOuUC5jsb 4NnpA+Wy5OeExM+sd9SH6OFFwqCR6aGB4a/9ENY/mRk5HELX/7J10A8JFTYuwWIno7Jx 6OPu6mfrFEvIdWTBRxCMbIlQjIppZlep5B9tVEEL+HYNOFtAsXmoC8H3R0NooNG6UQsz 2btg== X-Gm-Message-State: AOJu0YzN5PAPsmr3yM/KRLUzIhZLj2Kt1hqw3K6mhkhTjHZW8NXZGknP lO+wTF9vEwry7kKhsRnJ9fU+oQ== X-Received: by 2002:adf:fdd0:0:b0:321:6fe4:d4eb with SMTP id i16-20020adffdd0000000b003216fe4d4ebmr2878576wrs.2.1696444753110; Wed, 04 Oct 2023 11:39:13 -0700 (PDT) Received: from brgl-uxlite.home ([2a01:cb1d:334:ac00:4cd6:4440:32bb:f50d]) by smtp.gmail.com with ESMTPSA id s21-20020a7bc395000000b004064cd71aa8sm2109950wmj.34.2023.10.04.11.39.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Oct 2023 11:39:12 -0700 (PDT) From: Bartosz Golaszewski To: Mark Brown , Florian Fainelli , Andy Shevchenko , Linus Walleij , Ray Jui , Scott Branden Cc: Broadcom internal kernel review list , linux-spi@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, Bartosz Golaszewski , Hans de Goede Subject: [PATCH] spi: bcm2835: add a sentinel at the end of the lookup array Date: Wed, 4 Oct 2023 20:39:06 +0200 Message-Id: <20231004183906.97845-1-brgl@bgdev.pl> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 X-Spam-Status: No, score=2.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_SBL_CSS, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Wed, 04 Oct 2023 11:40:05 -0700 (PDT) X-Spam-Level: ** X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1778851366301109511 X-GMAIL-MSGID: 1778851366301109511 From: Bartosz Golaszewski GPIOLIB expects the array of lookup entries to be terminated with an empty member. We need to increase the size of the variable length array in the lookup table by 1. Fixes: 21f252cd29f0 ("spi: bcm2835: reduce the abuse of the GPIO API") Reported-by: Hans de Goede Closes: https://lore.kernel.org/lkml/29764d46-8d3d-9794-bbde-d7928a91cbb5@redhat.com/ Signed-off-by: Bartosz Golaszewski Reviewed-by: Andy Shevchenko Reviewed-by: Linus Walleij --- drivers/spi/spi-bcm2835.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/spi/spi-bcm2835.c b/drivers/spi/spi-bcm2835.c index c9078fee3662..e709887eb2a9 100644 --- a/drivers/spi/spi-bcm2835.c +++ b/drivers/spi/spi-bcm2835.c @@ -1299,7 +1299,7 @@ static int bcm2835_spi_setup(struct spi_device *spi) * More on the problem that it addresses: * https://www.spinics.net/lists/linux-gpio/msg36218.html */ - lookup = kzalloc(struct_size(lookup, table, 1), GFP_KERNEL); + lookup = kzalloc(struct_size(lookup, table, 2), GFP_KERNEL); if (!lookup) { ret = -ENOMEM; goto err_cleanup;