[v3,1/8] wifi: wfx: fix power_save setting when AP is stopped

Message ID 20231004172843.195332-2-jerome.pouiller@silabs.com
State New
Headers
Series wfx: implement Remain On Channel |

Commit Message

Jérôme Pouiller Oct. 4, 2023, 5:28 p.m. UTC
  The WF200 allow to start two network interfaces (one AP, one station) on
two different channels. Since magic does not exist, it only works if the
station interface enables power save.

Thus, the driver detects this case and enforce power save as necessary.

This patch fixes the case where the AP interface is stopped and it is no
more necessary to enforce power saving on the station interface.

Signed-off-by: Jérôme Pouiller <jerome.pouiller@silabs.com>
---
 drivers/net/wireless/silabs/wfx/sta.c | 5 +++++
 1 file changed, 5 insertions(+)
  

Comments

Kalle Valo Oct. 9, 2023, 6:53 a.m. UTC | #1
Jérôme Pouiller  <jerome.pouiller@silabs.com> wrote:

> The WF200 allow to start two network interfaces (one AP, one station) on
> two different channels. Since magic does not exist, it only works if the
> station interface enables power save.
> 
> Thus, the driver detects this case and enforce power save as necessary.
> 
> This patch fixes the case where the AP interface is stopped and it is no
> more necessary to enforce power saving on the station interface.
> 
> Signed-off-by: Jérôme Pouiller <jerome.pouiller@silabs.com>

8 patches applied to wireless-next.git, thanks.

8b27aed225ca wifi: wfx: fix power_save setting when AP is stopped
94c104d51830 wifi: wfx: relocate wfx_rate_mask_to_hw()
cf0cc05c8c23 wifi: wfx: move wfx_skb_*() out of the header file
fc5cb24fd50e wifi: wfx: introduce hif_scan_uniq()
f091bcb62dc6 wifi: wfx: simplify exclusion between scan and Rx filters
04106ec5bb02 wifi: wfx: scan_lock is global to the device
f7385a20249e wifi: wfx: allow to send frames during ROC
fc627dad3f01 wifi: wfx: implement wfx_remain_on_channel()
  

Patch

diff --git a/drivers/net/wireless/silabs/wfx/sta.c b/drivers/net/wireless/silabs/wfx/sta.c
index 626dfb4b7a55d..9c0a11c277e97 100644
--- a/drivers/net/wireless/silabs/wfx/sta.c
+++ b/drivers/net/wireless/silabs/wfx/sta.c
@@ -402,7 +402,12 @@  void wfx_stop_ap(struct ieee80211_hw *hw, struct ieee80211_vif *vif,
 		 struct ieee80211_bss_conf *link_conf)
 {
 	struct wfx_vif *wvif = (struct wfx_vif *)vif->drv_priv;
+	struct wfx_dev *wdev = wvif->wdev;
 
+	wvif =  NULL;
+	while ((wvif = wvif_iterate(wdev, wvif)) != NULL)
+		wfx_update_pm(wvif);
+	wvif = (struct wfx_vif *)vif->drv_priv;
 	wfx_reset(wvif);
 }