| Message ID | 20231004120529.1155700-1-naresh.solanki@9elements.com |
|---|---|
| State | New |
| Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org>
Delivered-To: ouuuleilei@gmail.com
Received: by 2002:a05:612c:254a:b0:403:3b70:6f57 with SMTP id hf10csp80752vqb;
Wed, 4 Oct 2023 05:08:08 -0700 (PDT)
X-Google-Smtp-Source:
AGHT+IE3h/cbrW5946LLA1hUIMhoDhlQHsiQc1990Xln8pL+hswWKKoiT87XQC0Ofcs7IqrZKbEr
X-Received: by 2002:a05:6a20:430d:b0:140:61f8:53f6 with SMTP id
h13-20020a056a20430d00b0014061f853f6mr3173320pzk.29.1696421288336;
Wed, 04 Oct 2023 05:08:08 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1696421288; cv=none;
d=google.com; s=arc-20160816;
b=pZgpPhmAKOlo9MnJVV+3qWf/WmasfHZ4a+rQg2X7Nb0bJJ4LUDSz3qA86OVyCeBe3I
5m1j3Tqiz3H9Uaji0mKGTAslxdX4ulLgfIqiKFdqwDqtVT9b/GspCMolxwu+aPnjbxMw
Ox6lyTtsEOv5qTzrU1BtWF4obuCZ9l0VcKUd/doKbsGDfA/HNhWvWZUNXS3Ln0HPdHis
nsKvc5ENzWjted/dDCkQN5AV6q77UBsywOJAEXmlTieEdZu1TZcuKWnfIs1WKFBsMATR
Ur75bmZuyEMXVoCHj/6S3QmZbczKgFulyGe/lh9huuggxVjy1Od1maVYibqAJzepX7a5
kmjg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20160816;
h=list-id:precedence:content-transfer-encoding:mime-version
:message-id:date:subject:cc:to:from:dkim-signature;
bh=DcpgkwL12FHEODFIbiIinUiJz0ey3tDqVJ4nMPpi9XQ=;
fh=RfWhGbypFTBtpGjdcWLfYJ57rivHGVWSibYa/VOfhW4=;
b=eIwO1PBhH/GR6Pu8+iGusxPAttzcW2E00PgJKOkhvyASyGOGXD6wZ2X76xpEZyj7s8
tGmhmRDnaHsFit7NYWaAmoQHW68XPdxuFRcUB7btSj4vrFaJ1rN0KWGIBH2OwcFi326P
hDzTPCRhANbQBG9HhBjhaI6a46bs5vnzCl9eVNhTG/HpssemEPYuRLvG3zi27CloyGcC
1YnD6Nji0PHVUSxD9dVT1E7QKrKHNWFvq5glP2qrf9+7+I2tf05kjmm2Jur6FfKEfWCT
3aMzaj+3vmf1vrnUMb/yviE+Jkaf3GFk7Dm2S2BO/z1V1NErAekT/24aDS5Pfj//Ul0N
1qSg==
ARC-Authentication-Results: i=1; mx.google.com;
dkim=pass header.i=@9elements.com header.s=google header.b=V9RCFdlJ;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 23.128.96.34 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=9elements.com
Received: from howler.vger.email (howler.vger.email. [23.128.96.34])
by mx.google.com with ESMTPS id
k5-20020a056a00134500b0068e2dadcfc3si3871580pfu.48.2023.10.04.05.07.45
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Wed, 04 Oct 2023 05:08:08 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34;
Authentication-Results: mx.google.com;
dkim=pass header.i=@9elements.com header.s=google header.b=V9RCFdlJ;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 23.128.96.34 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=9elements.com
Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0])
by howler.vger.email (Postfix) with ESMTP id 1A1E4833F8F2;
Wed, 4 Oct 2023 05:07:45 -0700 (PDT)
X-Virus-Status: Clean
X-Virus-Scanned: clamav-milter 0.103.10 at howler.vger.email
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
id S242294AbjJDMHk (ORCPT <rfc822;pusanteemu@gmail.com> + 18 others);
Wed, 4 Oct 2023 08:07:40 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35994 "EHLO
lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
with ESMTP id S233212AbjJDMHi (ORCPT
<rfc822;linux-kernel@vger.kernel.org>);
Wed, 4 Oct 2023 08:07:38 -0400
Received: from mail-ed1-x52f.google.com (mail-ed1-x52f.google.com
[IPv6:2a00:1450:4864:20::52f])
by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 87C30F0
for <linux-kernel@vger.kernel.org>;
Wed, 4 Oct 2023 05:07:35 -0700 (PDT)
Received: by mail-ed1-x52f.google.com with SMTP id
4fb4d7f45d1cf-53639fb0ba4so3624686a12.0
for <linux-kernel@vger.kernel.org>;
Wed, 04 Oct 2023 05:07:35 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=9elements.com; s=google; t=1696421254; x=1697026054;
darn=vger.kernel.org;
h=content-transfer-encoding:mime-version:message-id:date:subject:cc
:to:from:from:to:cc:subject:date:message-id:reply-to;
bh=DcpgkwL12FHEODFIbiIinUiJz0ey3tDqVJ4nMPpi9XQ=;
b=V9RCFdlJxJPeN2qqsrEOkUbdbMF+s1l7AbJ8SVSHF1CpLqDU0jAn7W6yIBckYTOF+F
j+MEGX1ENQFHf1Qt9oVU1/zSaKL5ZG+2tX/nWl1KbTMDLeKAN6kqLhmjuYajxEaBWWIb
8XZ1ysD/dinxHrXCCqPTPkhm1Pcq1OPUslnholPy7j/W6E/B+EfqljJ5J+SqfvOQilfe
O/3VGquhkIbKpC6kNeZ//kEDnEwdzuvRl9FiQ3gXr67QnccPAH1mhN1/WRgk2ABwWl1z
69fsbmrq4oVfpFYXrfxcNe7wGrtMO0XHa8vkW2QcY/SWu+/CwOk6H2t8Upo3uqucjpcf
ZPuw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1696421254; x=1697026054;
h=content-transfer-encoding:mime-version:message-id:date:subject:cc
:to:from:x-gm-message-state:from:to:cc:subject:date:message-id
:reply-to;
bh=DcpgkwL12FHEODFIbiIinUiJz0ey3tDqVJ4nMPpi9XQ=;
b=o78IqHIzXFwR6KXlfNP5aXw+d+mIlzC81YQ+g68h2oCyywZlnApa84sJqVXcaXyhnl
Z7670i2L8M674cwxHkorDQMsiqWFvGYA6BrYNshg6jAXS8z/79zWw9BwrbxBbHT8iPJD
6cjLq8oaNawtX+u+ZuIaj5NF+YTwI7bcXU23JXSwP8dSzSg8oq+u08COMK7FFJH+SJ49
K/5kl5ai1HoEVgyOQ5xOy8pqC8ac16xLR2RHxB7vy45C38cUdHh4cBLw3pd2Gy+v+IlG
AxfEvz3dpV+rz2MkBc7BQIAyKX3PIl6FG0wNICH8xL3yvOKEpDLb4C3/gycCNIE4hxxG
BGuQ==
X-Gm-Message-State: AOJu0Yx16mVTugU9zgrgBnKL8FhCpOdq4q/aUN7pVGYQRtAL96efIKHJ
I6IMd9z73EsOT+pYMAxUVofGTw==
X-Received: by 2002:aa7:c58f:0:b0:531:f4:57a8 with SMTP id
g15-20020aa7c58f000000b0053100f457a8mr1872504edq.26.1696421253763;
Wed, 04 Oct 2023 05:07:33 -0700 (PDT)
Received: from stroh80.sec.9e.network
(ip-078-094-000-051.um19.pools.vodafone-ip.de. [78.94.0.51])
by smtp.gmail.com with ESMTPSA id
e6-20020aa7d7c6000000b005362bcc089csm2324665eds.67.2023.10.04.05.07.32
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Wed, 04 Oct 2023 05:07:33 -0700 (PDT)
From: Naresh Solanki <naresh.solanki@9elements.com>
To: broonie@kernel.org, zev@bewilderbeest.net,
Liam Girdwood <lgirdwood@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: Naresh Solanki <naresh.solanki@9elements.com>,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: [PATCH 1/3] dt-bindings: regulator: regulator-output: Multiple
supplies
Date: Wed, 4 Oct 2023 14:05:26 +0200
Message-ID: <20231004120529.1155700-1-naresh.solanki@9elements.com>
X-Mailer: git-send-email 2.41.0
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,
SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no
version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test,
not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]);
Wed, 04 Oct 2023 05:07:45 -0700 (PDT)
X-getmail-retrieved-from-mailbox: INBOX
X-GMAIL-THRID: 1778826648813004527
X-GMAIL-MSGID: 1778826648813004527
|
| Series |
[1/3] dt-bindings: regulator: regulator-output: Multiple supplies
|
|
Commit Message
Naresh Solanki
Oct. 4, 2023, 12:05 p.m. UTC
Add support for multiple supplies.
Signed-off-by: Naresh Solanki <naresh.solanki@9elements.com>
---
.../devicetree/bindings/regulator/regulator-output.yaml | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
base-commit: f9a1d31874c383f58bb4f89bfe79b764682cd026
Comments
On Wed, Oct 04, 2023 at 02:05:26PM +0200, Naresh Solanki wrote: > Add support for multiple supplies. Why? > > Signed-off-by: Naresh Solanki <naresh.solanki@9elements.com> > --- > .../devicetree/bindings/regulator/regulator-output.yaml | 9 +++++++-- > 1 file changed, 7 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/regulator/regulator-output.yaml b/Documentation/devicetree/bindings/regulator/regulator-output.yaml > index 078b37a1a71a..6d077f123729 100644 > --- a/Documentation/devicetree/bindings/regulator/regulator-output.yaml > +++ b/Documentation/devicetree/bindings/regulator/regulator-output.yaml > @@ -21,13 +21,13 @@ properties: > compatible: > const: regulator-output > > - vout-supply: > +patternProperties: > + ".*-supply": > description: > Phandle of the regulator supplying the output. > > required: > - compatible > - - vout-supply > > additionalProperties: false > > @@ -37,3 +37,8 @@ examples: > compatible = "regulator-output"; > vout-supply = <&output_reg>; > }; > + output1 { > + compatible = "regulator-output"; > + sw0-supply = <&output_reg0>; > + sw1-supply = <&output_reg2>; > + }; > > base-commit: f9a1d31874c383f58bb4f89bfe79b764682cd026 > -- > 2.41.0 >
Hi Rob, On Wed, 4 Oct 2023 at 20:44, Rob Herring <robh@kernel.org> wrote: > > On Wed, Oct 04, 2023 at 02:05:26PM +0200, Naresh Solanki wrote: > > Add support for multiple supplies. > > Why? 1. Driver is already capable of that using platform data. Hence added support to read DT property & initialize the same for multiple supplies instead of being limited to one. 2. This is particularly useful in cases wherein 2 or more regulators are coupled together, for example in a PCIe connector having 3.3V & 12V. Regards, Naresh > > > > > Signed-off-by: Naresh Solanki <naresh.solanki@9elements.com> > > --- > > .../devicetree/bindings/regulator/regulator-output.yaml | 9 +++++++-- > > 1 file changed, 7 insertions(+), 2 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/regulator/regulator-output.yaml b/Documentation/devicetree/bindings/regulator/regulator-output.yaml > > index 078b37a1a71a..6d077f123729 100644 > > --- a/Documentation/devicetree/bindings/regulator/regulator-output.yaml > > +++ b/Documentation/devicetree/bindings/regulator/regulator-output.yaml > > @@ -21,13 +21,13 @@ properties: > > compatible: > > const: regulator-output > > > > - vout-supply: > > +patternProperties: > > + ".*-supply": > > description: > > Phandle of the regulator supplying the output. > > > > required: > > - compatible > > - - vout-supply > > > > additionalProperties: false > > > > @@ -37,3 +37,8 @@ examples: > > compatible = "regulator-output"; > > vout-supply = <&output_reg>; > > }; > > + output1 { > > + compatible = "regulator-output"; > > + sw0-supply = <&output_reg0>; > > + sw1-supply = <&output_reg2>; > > + }; > > > > base-commit: f9a1d31874c383f58bb4f89bfe79b764682cd026 > > -- > > 2.41.0 > >
On 05/10/2023 09:46, Naresh Solanki wrote: > Hi Rob, > > > On Wed, 4 Oct 2023 at 20:44, Rob Herring <robh@kernel.org> wrote: >> >> On Wed, Oct 04, 2023 at 02:05:26PM +0200, Naresh Solanki wrote: >>> Add support for multiple supplies. >> >> Why? > 1. Driver is already capable of that using platform data. Hence added > support to read DT property & initialize the same for multiple > supplies instead of being limited to one. I am not sure that's a valid reason. Bindings focus on the hardware. We do not describe here driver capabilities. > 2. This is particularly useful in cases wherein 2 or more regulators > are coupled together, for example in a PCIe connector having 3.3V & > 12V. Commit message should explain this. Each commit, when not obvious, should say why you are doing things. Best regards, Krzysztof
On Thu, Oct 05, 2023 at 12:46:31AM PDT, Naresh Solanki wrote: >Hi Rob, > > >On Wed, 4 Oct 2023 at 20:44, Rob Herring <robh@kernel.org> wrote: >> >> On Wed, Oct 04, 2023 at 02:05:26PM +0200, Naresh Solanki wrote: >> > Add support for multiple supplies. >> >> Why? >1. Driver is already capable of that using platform data. Hence added >support to read DT property & initialize the same for multiple >supplies instead of being limited to one. >2. This is particularly useful in cases wherein 2 or more regulators >are coupled together, for example in a PCIe connector having 3.3V & >12V. > Hmm -- apologies if I pointed you in the wrong direction here on the last revision (or should have considered this earlier), but is there a particular need for this arrangement to be described by a single regulator-output DT node instead of just having one node per supply? If they're independently-controlled voltage outputs, treating them as two separate things instead of a single ganged one seems like it might be more appropriate anyway... Zev
diff --git a/Documentation/devicetree/bindings/regulator/regulator-output.yaml b/Documentation/devicetree/bindings/regulator/regulator-output.yaml index 078b37a1a71a..6d077f123729 100644 --- a/Documentation/devicetree/bindings/regulator/regulator-output.yaml +++ b/Documentation/devicetree/bindings/regulator/regulator-output.yaml @@ -21,13 +21,13 @@ properties: compatible: const: regulator-output - vout-supply: +patternProperties: + ".*-supply": description: Phandle of the regulator supplying the output. required: - compatible - - vout-supply additionalProperties: false @@ -37,3 +37,8 @@ examples: compatible = "regulator-output"; vout-supply = <&output_reg>; }; + output1 { + compatible = "regulator-output"; + sw0-supply = <&output_reg0>; + sw1-supply = <&output_reg2>; + };