diff mbox series

[v2,3/3] arm64: defconfig: Enable GPMC NAND support

Message ID 20231004111238.3968984-4-n-yadav@ti.com
State New
Headers
Series Add support for GPMC NAND |

Commit Message

Nitin Yadav Oct. 4, 2023, 11:12 a.m. UTC 
  Enable config required to support GPMC NAND on
AM62x LP SK and AM64x SKEVM.

Signed-off-by: Nitin Yadav <n-yadav@ti.com>
---
 arch/arm64/configs/defconfig | 3 +++
 1 file changed, 3 insertions(+)

Comments

Roger Quadros Oct. 4, 2023, 11:26 a.m. UTC | #1 
On 4.10.2023 14.12, Nitin Yadav wrote:
> Enable config required to support GPMC NAND on
> AM62x LP SK and AM64x SKEVM.
> 
> Signed-off-by: Nitin Yadav <n-yadav@ti.com>
> ---
>   arch/arm64/configs/defconfig | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
> index 66bfbef73324..a2758ac73f87 100644
> --- a/arch/arm64/configs/defconfig
> +++ b/arch/arm64/configs/defconfig
> @@ -270,6 +270,8 @@ CONFIG_MTD_DATAFLASH=y
>   CONFIG_MTD_SST25L=y
>   CONFIG_MTD_RAW_NAND=y
>   CONFIG_MTD_NAND_DENALI_DT=y
> +CONFIG_MTD_NAND_OMAP2=m

If rootfs is required on NAND, it is better to be built-in.

> +CONFIG_MTD_NAND_OMAP_BCH=y
>   CONFIG_MTD_NAND_MARVELL=y
>   CONFIG_MTD_NAND_BRCMNAND=m
>   CONFIG_MTD_NAND_FSL_IFC=y
> @@ -1357,6 +1359,7 @@ CONFIG_ARM_MEDIATEK_CCI_DEVFREQ=m
>   CONFIG_EXTCON_PTN5150=m
>   CONFIG_EXTCON_USB_GPIO=y
>   CONFIG_EXTCON_USBC_CROS_EC=y
> +CONFIG_OMAP_GPMC=m

This is a memory controller so better to be built-in.

>   CONFIG_RENESAS_RPCIF=m
>   CONFIG_IIO=y
>   CONFIG_EXYNOS_ADC=y
Nishanth Menon Oct. 4, 2023, 12:06 p.m. UTC | #2 
On 14:26-20231004, Roger Quadros wrote:
> 
> 
> On 4.10.2023 14.12, Nitin Yadav wrote:
> > Enable config required to support GPMC NAND on
> > AM62x LP SK and AM64x SKEVM.
> > 
> > Signed-off-by: Nitin Yadav <n-yadav@ti.com>
> > ---
> >   arch/arm64/configs/defconfig | 3 +++
> >   1 file changed, 3 insertions(+)
> > 
> > diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
> > index 66bfbef73324..a2758ac73f87 100644
> > --- a/arch/arm64/configs/defconfig
> > +++ b/arch/arm64/configs/defconfig
> > @@ -270,6 +270,8 @@ CONFIG_MTD_DATAFLASH=y
> >   CONFIG_MTD_SST25L=y
> >   CONFIG_MTD_RAW_NAND=y
> >   CONFIG_MTD_NAND_DENALI_DT=y
> > +CONFIG_MTD_NAND_OMAP2=m
> 
> If rootfs is required on NAND, it is better to be built-in.
> 
> > +CONFIG_MTD_NAND_OMAP_BCH=y
> >   CONFIG_MTD_NAND_MARVELL=y
> >   CONFIG_MTD_NAND_BRCMNAND=m
> >   CONFIG_MTD_NAND_FSL_IFC=y
> > @@ -1357,6 +1359,7 @@ CONFIG_ARM_MEDIATEK_CCI_DEVFREQ=m
> >   CONFIG_EXTCON_PTN5150=m
> >   CONFIG_EXTCON_USB_GPIO=y
> >   CONFIG_EXTCON_USBC_CROS_EC=y
> > +CONFIG_OMAP_GPMC=m
> 
> This is a memory controller so better to be built-in.
> 
> >   CONFIG_RENESAS_RPCIF=m
> >   CONFIG_IIO=y
> >   CONFIG_EXYNOS_ADC=y

For the boards mentioned, NAND is optional and not a primary rootfs
storage media - I'd rather leave it as "m" and not impact the size of
generic Image file.
diff mbox series

Patch

diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
index 66bfbef73324..a2758ac73f87 100644
--- a/arch/arm64/configs/defconfig
+++ b/arch/arm64/configs/defconfig
@@ -270,6 +270,8 @@  CONFIG_MTD_DATAFLASH=y
 CONFIG_MTD_SST25L=y
 CONFIG_MTD_RAW_NAND=y
 CONFIG_MTD_NAND_DENALI_DT=y
+CONFIG_MTD_NAND_OMAP2=m
+CONFIG_MTD_NAND_OMAP_BCH=y
 CONFIG_MTD_NAND_MARVELL=y
 CONFIG_MTD_NAND_BRCMNAND=m
 CONFIG_MTD_NAND_FSL_IFC=y
@@ -1357,6 +1359,7 @@  CONFIG_ARM_MEDIATEK_CCI_DEVFREQ=m
 CONFIG_EXTCON_PTN5150=m
 CONFIG_EXTCON_USB_GPIO=y
 CONFIG_EXTCON_USBC_CROS_EC=y
+CONFIG_OMAP_GPMC=m
 CONFIG_RENESAS_RPCIF=m
 CONFIG_IIO=y
 CONFIG_EXYNOS_ADC=y