From patchwork Tue Oct 3 23:29:03 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frederic Weisbecker X-Patchwork-Id: 148104 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:612c:2a8e:b0:403:3b70:6f57 with SMTP id in14csp2413366vqb; Tue, 3 Oct 2023 16:29:39 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGk9qZJQA7AbSbfpR1B4YTOomhGVoHMghgYf4DRnO9AibgyQa3sS3g9EuwXysYD3gtQLiCJ X-Received: by 2002:a05:6358:591c:b0:143:7d73:6e66 with SMTP id g28-20020a056358591c00b001437d736e66mr1060600rwf.1.1696375778913; Tue, 03 Oct 2023 16:29:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696375778; cv=none; d=google.com; s=arc-20160816; b=mWn7APr1WaLkbZIvJXWshjLPkntXp/nmMn3+2RQHWgU8XzhWtfMp7G05Y5/rwjyNyC NYwyhHdD3WlGjBaoTRqrqg8JAo/e9A9jRRsew3zci4CvbfUDUf/mZfvhBJHWE4x94sO3 bHPFvLTL0wh08bKaI16SwpKhwHNtW1IvXN6m/LQqWrxLrtXLhcPKFBaeKMYNzh/P1WtF WtjosSZHCFnwianbCmkVgcy5HUTSJQlSIEUWmdCf1HRxBFr+pRvf3lVlWNa1mcIqVzqX WtmuGgJAQThLd9bhgOKNTIIun95At97Ihl4EWdvVjET6Qbn5FFgJtxdnTJAexGKtIVb7 ly5w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=mVKbX4aKsx1H5J6w9BmWyps9Z918RvdMzTu3RurVgzU=; fh=F5rAnPhwm0E3NuqHck/WDxlMw3n2ra+y1fhewNj930Q=; b=WLGbj1Hhi2SUzcGVdo8iFrHkNOXUEXnTn8+Qhympk5Ocgm0Q73zWXdD3n80JgqHcvG my+ecKZtBcLC0jMeIjTwkko2hFYUk5BhlNQjhN9yVfB/KGo11OEu8lbtyBqyyWVpg/Gh quetN2EL4stx4hLXOQTmiW1gAU3yLoTX/bt24iiCaabxR7HPGZFEeas9QxDSxEneo5wN uz0yEnZaAEu4cVb620746pGsouWWvZvDTGMP2fZkCkM3Gephc8DA4EawtuzszkMjYxM/ 5o9o0523uu3Gm9Fql8LiSlR8zLBRFvBKYzNWb9h3Rb6SDh8Hghhde6q2eZ08LiS2JGd9 OhJQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ckZ84jL+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from snail.vger.email (snail.vger.email. [2620:137:e000::3:7]) by mx.google.com with ESMTPS id a21-20020a17090aa51500b00263a2156cd5si295922pjq.30.2023.10.03.16.29.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Oct 2023 16:29:38 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ckZ84jL+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 0B5F081B94D4; Tue, 3 Oct 2023 16:29:38 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237072AbjJCX3h (ORCPT + 17 others); Tue, 3 Oct 2023 19:29:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53746 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236767AbjJCX33 (ORCPT ); Tue, 3 Oct 2023 19:29:29 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D0F92F0; Tue, 3 Oct 2023 16:29:24 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 33129C433CA; Tue, 3 Oct 2023 23:29:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1696375764; bh=0rRo8FAmb5oxl6EZiJPhw9pHIJx5I2TobFmAd6Jx3js=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ckZ84jL+5znrqWKHYEA+9b1Rw3RT0Gi+UXmpmDTGlZhoPinert8WUNxoDLU4o56nk dmedaAxQJKrj7ntNQVKbPtnO2xlcoeh9TptXuh3uHCcLUzchAgQQSAxWftjDL7dHI4 F0GlfzowXeBcgPjhVYmPfr5Vtqv1pKYzqUVAEbkdOOLw4rADsiMRppbrszlTsiYIXp najipfPoK5n//X9Kg/cvv3L1npieqZqr+QdozUZ9ALZVuzsIdeTaN32AS/NkaSNHQV vrd4UXNW8B3aGZGyz0IN4a6Eb7zGdywILKMBiwNxLEtYz+WsYVe5USMhK4ClYS+sxK PV7LRnOBhW8iw== From: Frederic Weisbecker To: "Paul E . McKenney" Cc: LKML , Frederic Weisbecker , Yong He , Neeraj upadhyay , Joel Fernandes , Boqun Feng , Uladzislau Rezki , RCU Subject: [PATCH 5/5] srcu: Explain why callbacks invocations can't run concurrently Date: Wed, 4 Oct 2023 01:29:03 +0200 Message-ID: <20231003232903.7109-6-frederic@kernel.org> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20231003232903.7109-1-frederic@kernel.org> References: <20231003232903.7109-1-frederic@kernel.org> MIME-Version: 1.0 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Tue, 03 Oct 2023 16:29:38 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1778778928978909766 X-GMAIL-MSGID: 1778778928978909766 If an SRCU barrier is queued while callbacks are running and a new callbacks invocator for the same sdp were to run concurrently, the RCU barrier might execute too early. As this requirement is non-obvious, make sure to keep a record. Signed-off-by: Frederic Weisbecker --- kernel/rcu/srcutree.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/kernel/rcu/srcutree.c b/kernel/rcu/srcutree.c index 2bfc8ed1eed2..0351a4e83529 100644 --- a/kernel/rcu/srcutree.c +++ b/kernel/rcu/srcutree.c @@ -1715,6 +1715,11 @@ static void srcu_invoke_callbacks(struct work_struct *work) WARN_ON_ONCE(!rcu_segcblist_segempty(&sdp->srcu_cblist, RCU_NEXT_TAIL)); rcu_segcblist_advance(&sdp->srcu_cblist, rcu_seq_current(&ssp->srcu_sup->srcu_gp_seq)); + /* + * Although this function is theoretically re-entrant, concurrent + * callbacks invocation is disallowed to avoid executing an SRCU barrier + * too early. + */ if (sdp->srcu_cblist_invoking || !rcu_segcblist_ready_cbs(&sdp->srcu_cblist)) { spin_unlock_irq_rcu_node(sdp); @@ -1745,6 +1750,7 @@ static void srcu_invoke_callbacks(struct work_struct *work) sdp->srcu_cblist_invoking = false; more = rcu_segcblist_ready_cbs(&sdp->srcu_cblist); spin_unlock_irq_rcu_node(sdp); + /* An SRCU barrier or callbacks from previous nesting work pending */ if (more) srcu_schedule_cbs_sdp(sdp, 0); }