From patchwork Tue Oct 3 15:55:52 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Johan Hovold X-Patchwork-Id: 147978 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:612c:2a8e:b0:403:3b70:6f57 with SMTP id in14csp2183149vqb; Tue, 3 Oct 2023 08:59:11 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEeiF+3+eiH2MN6aiKhsJ9tVsI+VlOY2748OBTSHNE3FiJceyDh1s2HJEwsqXBGq5mbAHCY X-Received: by 2002:a17:90a:fa49:b0:276:caee:db4d with SMTP id dt9-20020a17090afa4900b00276caeedb4dmr11747245pjb.10.1696348750667; Tue, 03 Oct 2023 08:59:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696348750; cv=none; d=google.com; s=arc-20160816; b=bZPfh9TTPB6Ojy7VqFOg9gPQbekZMSM5Bv0l5SUkfI2XRyYP7QIhQ8yi0DzYSiBi9F pjOmgxLyNdGWfNuK84ZjxStohQye56ggb7twtGV/du5WlWJy6LVOOBDDowKY+zFRHSKy kgKwYqBqfCjIo+mUa0iiiE0LkMt7ZzfT8YnacEhyzSlrrMhQSy24YXwWSk/NoUlBf26N DrNRZO+7VkAswA8I+a7WxhE7bJIUhb1o2k7UjfU2MpyBDgNoYn9Hd7U18mPwbFsO2bGb lNwWkaa/HLRCAOxYSCSeo1KMsftdMt0dDxi4Mg4OeTV/H8AuwSntuFwyP7hkbos3uuSq Rq+g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=IxKg04mE6i++vapO2XphoeGWU6W5Q+SkiiQzjYlfHfQ=; fh=A7ESGAPW6WV+DCQVqmR+9L9s97lYo7gbF/gPHfKJi14=; b=VVqaOFVYLMFbSiViCZUhZ07KQ0XbX32TYOZEWgPgIZXFGnksYq6KK4Pvm3tdrMkJ5C jAq/g1+8gsQOcuc+uhxQovUGmNqPQFL0ptqsuWr7qZK/qYzAyW/tmWABKUY0qVMGsBBL 0IFLxeVzR299/DqZyFS38+y6gKIhVi61QUsazE3f/YVq6GBayiwEYLvRU8Gpa9S2OrwE SVbm2n9SiTvK2HyFu4OKcK1HkNuJRMKhNyouAd8rEl7bB3WmDeRbWYdEl3Qv9dSW+2Zz CUoDNEWrFjndvDECsVaVoXQTwZJx7uqpoS+/mT610HUyBLFpA5n35m9YnbtkT9PyDLFZ 7KqQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=NSXp24s3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from lipwig.vger.email (lipwig.vger.email. [2620:137:e000::3:3]) by mx.google.com with ESMTPS id h3-20020a655183000000b005740b47241csi1611722pgq.804.2023.10.03.08.59.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Oct 2023 08:59:10 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=NSXp24s3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id CFFEE816EF8F; Tue, 3 Oct 2023 08:59:01 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239431AbjJCP6i (ORCPT + 17 others); Tue, 3 Oct 2023 11:58:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57564 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237235AbjJCP6e (ORCPT ); Tue, 3 Oct 2023 11:58:34 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4888AAB; Tue, 3 Oct 2023 08:58:31 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DADCEC433C8; Tue, 3 Oct 2023 15:58:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1696348710; bh=d3VaEwaFlyeMPWg3YHua4F4aRB7Tfwof5FHIy9UNucg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=NSXp24s3e8mvkSzjU7j3jfbsRkiRrdsCcyLfcSU7362Ak3Pd1N7fODvRQ4m+VKKlW Ai8Q9kjjgXWiyuSP/UM391TIW0Bb83+rnOv39UL8WfvkKMRRldnqm7Qfez/ONMhCi6 0apiliYSifzA+dQq+cQXY60acuMFANuvzSEgJNsTLlztN80W43GeWCiFkH32Zxlk05 Mh5r91tfqDbY9cDihmDPBpsSWJUJ9J4dXWsv23MS2ejPJ2b8+ODoMlGKXscZnE3nsC EPMYYoX4pvJj+SvCzca2F2OHaufKQE70zf9O73lQJ1kf8RKYR3fmBoX0hs8UTxRTA4 5S2mdKljgQBSg== Received: from johan by xi.lan with local (Exim 4.96) (envelope-from ) id 1qnhnF-00074n-3C; Tue, 03 Oct 2023 17:58:42 +0200 From: Johan Hovold To: Mark Brown Cc: Liam Girdwood , Jaroslav Kysela , Takashi Iwai , Srinivas Kandagatla , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Johan Hovold , stable@vger.kernel.org Subject: [PATCH 1/7] ASoC: codecs: wcd938x: drop bogus bind error handling Date: Tue, 3 Oct 2023 17:55:52 +0200 Message-ID: <20231003155558.27079-2-johan+linaro@kernel.org> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20231003155558.27079-1-johan+linaro@kernel.org> References: <20231003155558.27079-1-johan+linaro@kernel.org> MIME-Version: 1.0 X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Tue, 03 Oct 2023 08:59:01 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1778750587308598884 X-GMAIL-MSGID: 1778750587308598884 Drop the bogus error handling for a soundwire device backcast during bind() that cannot fail. Fixes: 16572522aece ("ASoC: codecs: wcd938x-sdw: add SoundWire driver") Cc: stable@vger.kernel.org # 5.14 Cc: Srinivas Kandagatla Signed-off-by: Johan Hovold --- sound/soc/codecs/wcd938x.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/sound/soc/codecs/wcd938x.c b/sound/soc/codecs/wcd938x.c index a3c680661377..cf1eaf678fc2 100644 --- a/sound/soc/codecs/wcd938x.c +++ b/sound/soc/codecs/wcd938x.c @@ -3448,10 +3448,6 @@ static int wcd938x_bind(struct device *dev) wcd938x->sdw_priv[AIF1_CAP] = dev_get_drvdata(wcd938x->txdev); wcd938x->sdw_priv[AIF1_CAP]->wcd938x = wcd938x; wcd938x->tx_sdw_dev = dev_to_sdw_dev(wcd938x->txdev); - if (!wcd938x->tx_sdw_dev) { - dev_err(dev, "could not get txslave with matching of dev\n"); - return -EINVAL; - } /* As TX is main CSR reg interface, which should not be suspended first. * expicilty add the dependency link */