[5/5] spmi: rename spmi device lookup helper
Commit Message
Rename the SPMI device helper which is used to lookup a device from its
OF node as spmi_find_device_by_of_node() so that it reflects the
implementation and matches how other helpers like this are named.
This will specifically make it more clear that this is a lookup function
which returns a reference counted structure.
Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
---
drivers/mfd/qcom-spmi-pmic.c | 2 +-
drivers/spmi/spmi.c | 6 +++---
include/linux/spmi.h | 2 +-
3 files changed, 5 insertions(+), 5 deletions(-)
Comments
Quoting Johan Hovold (2023-10-03 08:29:27)
> Rename the SPMI device helper which is used to lookup a device from its
> OF node as spmi_find_device_by_of_node() so that it reflects the
> implementation and matches how other helpers like this are named.
>
> This will specifically make it more clear that this is a lookup function
> which returns a reference counted structure.
>
> Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
> ---
Acked-by: Stephen Boyd <sboyd@kernel.org>
On Tue, 03 Oct 2023 17:29:27 +0200, Johan Hovold wrote:
> Rename the SPMI device helper which is used to lookup a device from its
> OF node as spmi_find_device_by_of_node() so that it reflects the
> implementation and matches how other helpers like this are named.
>
> This will specifically make it more clear that this is a lookup function
> which returns a reference counted structure.
>
> [...]
Applied, thanks!
[5/5] spmi: rename spmi device lookup helper
commit: 2a2aaed224d93093f4c94234c796ae3396bdceee
--
Lee Jones [李琼斯]
@@ -114,7 +114,7 @@ static struct spmi_device *qcom_pmic_get_base_usid(struct spmi_device *sdev, str
}
if (pmic_addr == function_parent_usid - (ctx->num_usids - 1)) {
- sdev = spmi_device_from_of(child);
+ sdev = spmi_find_device_by_of_node(child);
if (!sdev) {
/*
* If the base USID for this PMIC hasn't been
@@ -388,7 +388,7 @@ static struct bus_type spmi_bus_type = {
};
/**
- * spmi_device_from_of() - get the associated SPMI device from a device node
+ * spmi_find_device_by_of_node() - look up an SPMI device from a device node
*
* @np: device node
*
@@ -397,7 +397,7 @@ static struct bus_type spmi_bus_type = {
*
* Returns the struct spmi_device associated with a device node or NULL.
*/
-struct spmi_device *spmi_device_from_of(struct device_node *np)
+struct spmi_device *spmi_find_device_by_of_node(struct device_node *np)
{
struct device *dev = bus_find_device_by_of_node(&spmi_bus_type, np);
@@ -405,7 +405,7 @@ struct spmi_device *spmi_device_from_of(struct device_node *np)
return to_spmi_device(dev);
return NULL;
}
-EXPORT_SYMBOL_GPL(spmi_device_from_of);
+EXPORT_SYMBOL_GPL(spmi_find_device_by_of_node);
/**
* spmi_device_alloc() - Allocate a new SPMI device
@@ -166,7 +166,7 @@ static inline void spmi_driver_unregister(struct spmi_driver *sdrv)
struct device_node;
-struct spmi_device *spmi_device_from_of(struct device_node *np);
+struct spmi_device *spmi_find_device_by_of_node(struct device_node *np);
int spmi_register_read(struct spmi_device *sdev, u8 addr, u8 *buf);
int spmi_ext_register_read(struct spmi_device *sdev, u8 addr, u8 *buf,
size_t len);