[next] perf: fix spelling mistake "parametrized" -> "parameterized"

Message ID 20231003074911.220216-1-colin.i.king@gmail.com
State New
Headers
Series [next] perf: fix spelling mistake "parametrized" -> "parameterized" |

Commit Message

Colin Ian King Oct. 3, 2023, 7:49 a.m. UTC
  There are spelling mistakes in comments and a pr_debug message. Fix them.

Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
 tools/perf/tests/parse-events.c        | 4 ++--
 tools/perf/tests/shell/stat_all_pmu.sh | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)
  

Comments

Ian Rogers Oct. 4, 2023, 1:07 a.m. UTC | #1
On Tue, Oct 3, 2023 at 12:49 AM Colin Ian King <colin.i.king@gmail.com> wrote:
>
> There are spelling mistakes in comments and a pr_debug message. Fix them.
>
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>

+ Athira Rajeev

Reviewed-by: Ian Rogers <irogers@google.com>

Thanks,
Ian

> ---
>  tools/perf/tests/parse-events.c        | 4 ++--
>  tools/perf/tests/shell/stat_all_pmu.sh | 2 +-
>  2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/tools/perf/tests/parse-events.c b/tools/perf/tests/parse-events.c
> index f78be21a5999..e52f45c7c3d1 100644
> --- a/tools/perf/tests/parse-events.c
> +++ b/tools/perf/tests/parse-events.c
> @@ -2549,7 +2549,7 @@ static int test__pmu_events(struct test_suite *test __maybe_unused, int subtest
>                         if (strchr(ent->d_name, '.'))
>                                 continue;
>
> -                       /* exclude parametrized ones (name contains '?') */
> +                       /* exclude parameterized ones (name contains '?') */
>                         n = snprintf(pmu_event, sizeof(pmu_event), "%s%s", path, ent->d_name);
>                         if (n >= PATH_MAX) {
>                                 pr_err("pmu event name crossed PATH_MAX(%d) size\n", PATH_MAX);
> @@ -2578,7 +2578,7 @@ static int test__pmu_events(struct test_suite *test __maybe_unused, int subtest
>                         fclose(file);
>
>                         if (is_event_parameterized == 1) {
> -                               pr_debug("skipping parametrized PMU event: %s which contains ?\n", pmu_event);
> +                               pr_debug("skipping parameterized PMU event: %s which contains ?\n", pmu_event);
>                                 continue;
>                         }
>
> diff --git a/tools/perf/tests/shell/stat_all_pmu.sh b/tools/perf/tests/shell/stat_all_pmu.sh
> index c77955419173..d2a3506e0d19 100755
> --- a/tools/perf/tests/shell/stat_all_pmu.sh
> +++ b/tools/perf/tests/shell/stat_all_pmu.sh
> @@ -4,7 +4,7 @@
>
>  set -e
>
> -# Test all PMU events; however exclude parametrized ones (name contains '?')
> +# Test all PMU events; however exclude parameterized ones (name contains '?')
>  for p in $(perf list --raw-dump pmu | sed 's/[[:graph:]]\+?[[:graph:]]\+[[:space:]]//g'); do
>    echo "Testing $p"
>    result=$(perf stat -e "$p" true 2>&1)
> --
> 2.39.2
>
  
Athira Rajeev Oct. 4, 2023, 8:13 a.m. UTC | #2
> On 04-Oct-2023, at 6:37 AM, Ian Rogers <irogers@google.com> wrote:
> 
> On Tue, Oct 3, 2023 at 12:49 AM Colin Ian King <colin.i.king@gmail.com> wrote:
>> 
>> There are spelling mistakes in comments and a pr_debug message. Fix them.
>> 
>> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
> 
> + Athira Rajeev
> 
> Reviewed-by: Ian Rogers <irogers@google.com>

Reviewed-by: Athira Rajeev <atrajeev@linux.vnet.ibm.com <mailto:atrajeev@linux.vnet.ibm.com>>

Thanks
Athira
> 
> Thanks,
> Ian
> 
>> ---
>> tools/perf/tests/parse-events.c        | 4 ++--
>> tools/perf/tests/shell/stat_all_pmu.sh | 2 +-
>> 2 files changed, 3 insertions(+), 3 deletions(-)
>> 
>> diff --git a/tools/perf/tests/parse-events.c b/tools/perf/tests/parse-events.c
>> index f78be21a5999..e52f45c7c3d1 100644
>> --- a/tools/perf/tests/parse-events.c
>> +++ b/tools/perf/tests/parse-events.c
>> @@ -2549,7 +2549,7 @@ static int test__pmu_events(struct test_suite *test __maybe_unused, int subtest
>>                        if (strchr(ent->d_name, '.'))
>>                                continue;
>> 
>> -                       /* exclude parametrized ones (name contains '?') */
>> +                       /* exclude parameterized ones (name contains '?') */
>>                        n = snprintf(pmu_event, sizeof(pmu_event), "%s%s", path, ent->d_name);
>>                        if (n >= PATH_MAX) {
>>                                pr_err("pmu event name crossed PATH_MAX(%d) size\n", PATH_MAX);
>> @@ -2578,7 +2578,7 @@ static int test__pmu_events(struct test_suite *test __maybe_unused, int subtest
>>                        fclose(file);
>> 
>>                        if (is_event_parameterized == 1) {
>> -                               pr_debug("skipping parametrized PMU event: %s which contains ?\n", pmu_event);
>> +                               pr_debug("skipping parameterized PMU event: %s which contains ?\n", pmu_event);
>>                                continue;
>>                        }
>> 
>> diff --git a/tools/perf/tests/shell/stat_all_pmu.sh b/tools/perf/tests/shell/stat_all_pmu.sh
>> index c77955419173..d2a3506e0d19 100755
>> --- a/tools/perf/tests/shell/stat_all_pmu.sh
>> +++ b/tools/perf/tests/shell/stat_all_pmu.sh
>> @@ -4,7 +4,7 @@
>> 
>> set -e
>> 
>> -# Test all PMU events; however exclude parametrized ones (name contains '?')
>> +# Test all PMU events; however exclude parameterized ones (name contains '?')
>> for p in $(perf list --raw-dump pmu | sed 's/[[:graph:]]\+?[[:graph:]]\+[[:space:]]//g'); do
>>   echo "Testing $p"
>>   result=$(perf stat -e "$p" true 2>&1)
>> --
>> 2.39.2
>>
  
Arnaldo Carvalho de Melo Nov. 6, 2023, 9:35 p.m. UTC | #3
Em Wed, Oct 04, 2023 at 01:43:28PM +0530, Athira Rajeev escreveu:
> > On 04-Oct-2023, at 6:37 AM, Ian Rogers <irogers@google.com> wrote:
> > On Tue, Oct 3, 2023 at 12:49 AM Colin Ian King <colin.i.king@gmail.com> wrote:
> >> There are spelling mistakes in comments and a pr_debug message. Fix them.
> >> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
> > + Athira Rajeev
> > Reviewed-by: Ian Rogers <irogers@google.com>
 
> Reviewed-by: Athira Rajeev <atrajeev@linux.vnet.ibm.com <mailto:atrajeev@linux.vnet.ibm.com>>


Thanks, applied.

- Arnaldo
  

Patch

diff --git a/tools/perf/tests/parse-events.c b/tools/perf/tests/parse-events.c
index f78be21a5999..e52f45c7c3d1 100644
--- a/tools/perf/tests/parse-events.c
+++ b/tools/perf/tests/parse-events.c
@@ -2549,7 +2549,7 @@  static int test__pmu_events(struct test_suite *test __maybe_unused, int subtest
 			if (strchr(ent->d_name, '.'))
 				continue;
 
-			/* exclude parametrized ones (name contains '?') */
+			/* exclude parameterized ones (name contains '?') */
 			n = snprintf(pmu_event, sizeof(pmu_event), "%s%s", path, ent->d_name);
 			if (n >= PATH_MAX) {
 				pr_err("pmu event name crossed PATH_MAX(%d) size\n", PATH_MAX);
@@ -2578,7 +2578,7 @@  static int test__pmu_events(struct test_suite *test __maybe_unused, int subtest
 			fclose(file);
 
 			if (is_event_parameterized == 1) {
-				pr_debug("skipping parametrized PMU event: %s which contains ?\n", pmu_event);
+				pr_debug("skipping parameterized PMU event: %s which contains ?\n", pmu_event);
 				continue;
 			}
 
diff --git a/tools/perf/tests/shell/stat_all_pmu.sh b/tools/perf/tests/shell/stat_all_pmu.sh
index c77955419173..d2a3506e0d19 100755
--- a/tools/perf/tests/shell/stat_all_pmu.sh
+++ b/tools/perf/tests/shell/stat_all_pmu.sh
@@ -4,7 +4,7 @@ 
 
 set -e
 
-# Test all PMU events; however exclude parametrized ones (name contains '?')
+# Test all PMU events; however exclude parameterized ones (name contains '?')
 for p in $(perf list --raw-dump pmu | sed 's/[[:graph:]]\+?[[:graph:]]\+[[:space:]]//g'); do
   echo "Testing $p"
   result=$(perf stat -e "$p" true 2>&1)