From patchwork Tue Oct 3 00:34:28 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Boyd X-Patchwork-Id: 147591 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:612c:2a8e:b0:403:3b70:6f57 with SMTP id in14csp1775525vqb; Mon, 2 Oct 2023 17:34:57 -0700 (PDT) X-Google-Smtp-Source: AGHT+IELcNhWascfOTWzhzO5JzvxEwCpREgWJd0OrxzXerGnYa7N26JyYziuEFH2ZFIfqUMfzYze X-Received: by 2002:a25:8548:0:b0:d77:fddd:c343 with SMTP id f8-20020a258548000000b00d77fdddc343mr10991589ybn.48.1696293297748; Mon, 02 Oct 2023 17:34:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696293297; cv=none; d=google.com; s=arc-20160816; b=SDfduyOiQQTq4QqwxL1dtd0idzJzHXTBjsPPFGlg1Twb+BBLiH5otp1Oc8Iit+B18R cHqDJ7BXNf6K84r49IzuEptcydnT8r6hgNPfjdDHfAoAc34A4K8lxuNe1XbINlFgk0Me 5u/TOuuphFN8Qkqm3aP9acHhGvdtGgSzUHx75mMZn2AXBacyA4IedgzoBmRNaoW6+eYv gsKWglKbQokfySgk+qoAAQJ6ft4F8IvOPNQv2sKyYAXQYRUzLbsj8ERBWDVg1gCjiZ+u TTBS7Q2wM6gcNVoWN5npE7CxEJse+liOibo+h4OvTT3KsGxWHGK4/dwn1Ujq0UpaTEIJ 2izw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=ULFaUXbFksMdiOTX7EFeIrZO1zGruO/Y5COdeG+mbmw=; fh=YJV7s35UDfTu410NGMNaxLgUC83Mipoa1f3x561mYKo=; b=rmKam1SYKxl2W07EAO6SFkImNU/we2UdypCeA4e+qvhFwUmHSHwQG+YURzHoNDLHhT x1zqSbdaTVCikSB7zkFW/nPMoWvfXeNXOyG2xojcvyFTG0mllD9OxiJmsBbPKZPk4bEU FCBUK/shIi7CLpKyv2sBxjG1N770ZhFCvPH+A3DNTTfcdTyTQ2GmmbJ2Ep9XMk8AJCXj y9PDLPDJPhUaX0G3qITaWBFuI0vPNuOYTmU42a7tpZLWNyI9IEEZA8dyYVV1D5ATQlzg 6ufC46iKUQ9Dr0FQTWj+uRVnjhbHQXEeP1qXMRF6WG2+HoZaZftOzp8hVJ+v6WcaNpVs RnqQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=aCkqFxpo; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: from howler.vger.email (howler.vger.email. [2620:137:e000::3:4]) by mx.google.com with ESMTPS id m133-20020a633f8b000000b00585a4fc83fbsi166487pga.255.2023.10.02.17.34.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Oct 2023 17:34:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=aCkqFxpo; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by howler.vger.email (Postfix) with ESMTP id D746B8247742; Mon, 2 Oct 2023 17:34:56 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at howler.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238919AbjJCAeu (ORCPT + 18 others); Mon, 2 Oct 2023 20:34:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54478 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230045AbjJCAek (ORCPT ); Mon, 2 Oct 2023 20:34:40 -0400 Received: from mail-pf1-x433.google.com (mail-pf1-x433.google.com [IPv6:2607:f8b0:4864:20::433]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9E057C6 for ; Mon, 2 Oct 2023 17:34:36 -0700 (PDT) Received: by mail-pf1-x433.google.com with SMTP id d2e1a72fcca58-692779f583fso279364b3a.0 for ; Mon, 02 Oct 2023 17:34:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1696293276; x=1696898076; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ULFaUXbFksMdiOTX7EFeIrZO1zGruO/Y5COdeG+mbmw=; b=aCkqFxpoJ1W/FvxslnLgbXWH7lmfgtEJ/BY9wVHdupH/enLEg1qCiifjUePo5vCvbs iC2AFdU4y1ufFuKo0J2z1ud5g7HhhA7Y7UodaHOUqI3m8I5osY2FZIL0PVEXkwNByqRH XMhGrOxFxTTZ4ZKwFvkztkQ+QOOIChQwOUTbM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696293276; x=1696898076; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ULFaUXbFksMdiOTX7EFeIrZO1zGruO/Y5COdeG+mbmw=; b=MRuF+dGONLbGbaaBS204u4ygVeiwglw7iemLpy5wx74utg2NSDKyWVyve9dziX32Wh HEIa9n3bAmfWEPbcn3KLxdvjPKPT+1m4f83Ba9TfA/d3T7FHxSOGqvhecK5pfTxN3bvp 0JTc+goQ97r7TCs9zqDBgiJSX8jEM+stzO8dsijwivvQeOi9Lyv7fB/GKtzoUeANGA5f t2BYykbPXcMHW4BtU+smt5A4c6NFwYyYa5Xf9YnOIFsupt88PP5AESJMVZbWiz43Q3Ux 14daJCr/MqRBCz1JwTIS7espiUzTb9BKT2UNEPf/m91r9xxjn0RgsoHeFdobfnqHrW9X KMzw== X-Gm-Message-State: AOJu0Yyq6wGIEuLJIFMWJzWZnbi/vKsNGgOC+gCegY4VqWG68mKK0NJM U++QKes40usJAuOJNkNQjpXEUAvNUlr8iHJ/IIs= X-Received: by 2002:a05:6a00:1787:b0:68e:2478:d6c9 with SMTP id s7-20020a056a00178700b0068e2478d6c9mr13123617pfg.2.1696293275992; Mon, 02 Oct 2023 17:34:35 -0700 (PDT) Received: from smtp.gmail.com ([2620:15c:11a:201:f676:8db:8677:aefe]) by smtp.gmail.com with ESMTPSA id bm2-20020a056a00320200b0068a13b0b300sm101368pfb.11.2023.10.02.17.34.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Oct 2023 17:34:35 -0700 (PDT) From: Stephen Boyd To: Benson Leung , Tzung-Bi Shih Cc: linux-kernel@vger.kernel.org, patches@lists.linux.dev, chrome-platform@lists.linux.dev, Prashant Malani Subject: [PATCH 4/4] platform/chrome: cros_ec_proto: Mark outdata as const Date: Mon, 2 Oct 2023 17:34:28 -0700 Message-ID: <20231003003429.1378109-5-swboyd@chromium.org> X-Mailer: git-send-email 2.42.0.582.g8ccd20d70d-goog In-Reply-To: <20231003003429.1378109-1-swboyd@chromium.org> References: <20231003003429.1378109-1-swboyd@chromium.org> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Mon, 02 Oct 2023 17:34:57 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1778692441292387032 X-GMAIL-MSGID: 1778692441292387032 The 'outdata' is copied to the data buffer in cros_ec_cmd() before being sent over to the EC. Mark the argument as const so that callers can pass const pointers to this function and so that callers know the data won't be modified. Cc: Prashant Malani Signed-off-by: Stephen Boyd --- drivers/platform/chrome/cros_ec_proto.c | 2 +- include/linux/platform_data/cros_ec_proto.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/platform/chrome/cros_ec_proto.c b/drivers/platform/chrome/cros_ec_proto.c index 475a6dd72db6..945b1b15a04c 100644 --- a/drivers/platform/chrome/cros_ec_proto.c +++ b/drivers/platform/chrome/cros_ec_proto.c @@ -1004,7 +1004,7 @@ EXPORT_SYMBOL_GPL(cros_ec_get_sensor_count); int cros_ec_cmd(struct cros_ec_device *ec_dev, unsigned int version, int command, - void *outdata, + const void *outdata, size_t outsize, void *indata, size_t insize) diff --git a/include/linux/platform_data/cros_ec_proto.h b/include/linux/platform_data/cros_ec_proto.h index 4f9f756bc17c..8865e350c12a 100644 --- a/include/linux/platform_data/cros_ec_proto.h +++ b/include/linux/platform_data/cros_ec_proto.h @@ -258,7 +258,7 @@ bool cros_ec_check_features(struct cros_ec_dev *ec, int feature); int cros_ec_get_sensor_count(struct cros_ec_dev *ec); -int cros_ec_cmd(struct cros_ec_device *ec_dev, unsigned int version, int command, void *outdata, +int cros_ec_cmd(struct cros_ec_device *ec_dev, unsigned int version, int command, const void *outdata, size_t outsize, void *indata, size_t insize); /**