From patchwork Mon Oct 2 11:59:55 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Gleixner X-Patchwork-Id: 147408 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:612c:2a8e:b0:403:3b70:6f57 with SMTP id in14csp1598352vqb; Mon, 2 Oct 2023 11:02:44 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGa34SBe1wez9P0uKjOVuD7jsTuxUgJbZRSxbd4DQaEezBpL1RdiaQW9O3GJPAITENrU48B X-Received: by 2002:a05:6870:ac25:b0:1b0:17f2:6518 with SMTP id kw37-20020a056870ac2500b001b017f26518mr15051176oab.42.1696269764504; Mon, 02 Oct 2023 11:02:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696269764; cv=none; d=google.com; s=arc-20160816; b=NVMRN7dKmoPDp8vMpEn1sF5n0r5M8o/91lTHfOOtpDXzogPnKIOVvoGkM7zj/Vxvx1 JlXEaxwOqxQd9dxJ+Qg0m/sBflQJqoyhpJDRWYoaFvOE/E1Bq95NBPBukIsXhpRMkE9v DT2LtwwMH0eFwHN7vsywfAmT6GSnpRQX/TxVGmoA7R8DFyXktyDTs/YoEpwqzdatQPym fqbwX2XD0gXNSAC19Jw0U/hmXbEn6ldPYMDzyAODxB8dKBXEyseBYxHoJb5SNVfE+goG PnVaRcxDhwz+xQRDgqL5orrdCK890VovSmPv19pnHzxGUyg4KBqDaIrBPQd5cv7Dv8LG H0xQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:date:mime-version:references:subject:cc:to:from :dkim-signature:dkim-signature:message-id; bh=7j90uOLtW2Wz9UtqDt1Dp/sqHiCZcf49IdRLgKDZvBw=; fh=u57tXYamzTrJA+Ht8n1u7SfTMptrQaIb6LVW+jsaYf4=; b=m3ryZnOaiIHRHsfbow2+N6V/ygIdR+K3fmbN35fR+gDDj+lfrVK1vJqllGJ4ri9uto PbZ5RxJ/6zM+OB7JYLtmzxkeVUevUZavvuaQm9uLKoQ6rXMx0ze3HfWgfzPv7lm5y/D5 9DWRK/WOBwGtJIRr/hGUNgGBesMi9bQtmR8w5l3eucFLqi2FGPq4Cxtfa+hBFDqQ7T32 DGRCEnQVTrKpAy9SfaYH/zPA6Rc2EA/1WNXF5ct7vmFYvDjlG6MXsRlLrfQ76b8omyvl cD2AHuOC0zqNgHmcRi/gTunINDhd98j2Qws2IIVn2wwqssE5xOZ0xzXC0BZqCCXzLRz6 Rh3w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=FAZjiJ69; dkim=neutral (no key) header.i=@linutronix.de header.s=2020e header.b=TK+09Dsj; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: from groat.vger.email (groat.vger.email. [23.128.96.35]) by mx.google.com with ESMTPS id z11-20020a6552cb000000b005775a0cd009si15604685pgp.331.2023.10.02.11.02.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Oct 2023 11:02:44 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35; Authentication-Results: mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=FAZjiJ69; dkim=neutral (no key) header.i=@linutronix.de header.s=2020e header.b=TK+09Dsj; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id AA14F802AFD8; Mon, 2 Oct 2023 05:02:09 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236932AbjJBMAf (ORCPT + 18 others); Mon, 2 Oct 2023 08:00:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46214 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236946AbjJBMAW (ORCPT ); Mon, 2 Oct 2023 08:00:22 -0400 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E425CCCC for ; Mon, 2 Oct 2023 04:59:56 -0700 (PDT) Message-ID: <20231002115903.028651784@linutronix.de> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1696247995; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=7j90uOLtW2Wz9UtqDt1Dp/sqHiCZcf49IdRLgKDZvBw=; b=FAZjiJ692BNjL7M3QRIjWGOh9L7JutBy22k9ZlFOJfpicREccxMM2sbNeu9RVwIWmcfqym 7zgvao+1iBLiMrEQN5NYriWwPexJc069HWuS19nlqUMMK0DymyZ8xna+5HaIra8cyuByD+ FgGrlXL7jwF4I2F9q9bRKAxrEKPHcjOQ8WrqOVoi3r6hwkEGcS2vP5F1Vf5+4d8NlkAyi2 /gtX1DhQsf0nCGgTM34qm4zDAHNdP9hHm0LbyAqNsMOxAoGGpzXkDfisil5qtrCL+FLz16 qmHQh40Jtrif03klDVAv3vnux4ON0naJYIUH4ikQIfzGVoqJd5NA9ITkn/eRBQ== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1696247995; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=7j90uOLtW2Wz9UtqDt1Dp/sqHiCZcf49IdRLgKDZvBw=; b=TK+09Dsj/i8zlx64hwldIx+xmav0JdFReJ64MI2lZPzHncy/tailjJEa/JKQZqiAAHW70T 8CXkEIk/QfKrynDw== From: Thomas Gleixner To: LKML Cc: x86@kernel.org, Borislav Petkov , "Chang S. Bae" , Arjan van de Ven , Nikolay Borisov Subject: [patch V4 17/30] x86/microcode: Clean up mc_cpu_down_prep() References: <20231002115506.217091296@linutronix.de> MIME-Version: 1.0 Date: Mon, 2 Oct 2023 13:59:55 +0200 (CEST) X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Mon, 02 Oct 2023 05:02:09 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1778667764290204326 X-GMAIL-MSGID: 1778667764290204326 This function has nothing to do with suspend. It's a hotplug callback. Remove the bogus comment. Drop the pointless debug printk. The hotplug core provides tracepoints which track the invocation of those callbacks. Signed-off-by: Thomas Gleixner --- V2: New patch --- arch/x86/kernel/cpu/microcode/core.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) --- a/arch/x86/kernel/cpu/microcode/core.c +++ b/arch/x86/kernel/cpu/microcode/core.c @@ -527,16 +527,10 @@ static int mc_cpu_online(unsigned int cp static int mc_cpu_down_prep(unsigned int cpu) { - struct device *dev; - - dev = get_cpu_device(cpu); + struct device *dev = get_cpu_device(cpu); microcode_fini_cpu(cpu); - - /* Suspend is in progress, only remove the interface */ sysfs_remove_group(&dev->kobj, &mc_attr_group); - pr_debug("%s: CPU%d\n", __func__, cpu); - return 0; }