From patchwork Mon Oct 2 09:48:13 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Ilpo_J=C3=A4rvinen?= X-Patchwork-Id: 147297 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:612c:2a8e:b0:403:3b70:6f57 with SMTP id in14csp1428016vqb; Mon, 2 Oct 2023 06:30:29 -0700 (PDT) X-Google-Smtp-Source: AGHT+IF6125HsDpMV3Ir+7JktTYquOFiI3Y9xYZxU6J2M9bVbJLW6nU0lgCMq2OlSRAkyYkIKLLa X-Received: by 2002:a17:902:7404:b0:1c5:a49e:7aa with SMTP id g4-20020a170902740400b001c5a49e07aamr12620567pll.27.1696253429441; Mon, 02 Oct 2023 06:30:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696253429; cv=none; d=google.com; s=arc-20160816; b=r6VhFcKaAXzn5sSIWHIYuuaV4GONWq3sPzjkh3qISqsX/DCj4eDvgtdZNMOEdlDIgg ND2CmbNpHcxLzSWTFP4GW63ZwHzgCf0c2Vf+5lGlqE1C/EU5U2ZMgxBzyfX9L/CJMGML TaxpW/C5LAy0XfQ2r0bJ5LCOhDBbxFnhxisl0OVmgWwtzoUoZ9OGyM0cxfKkFNvaE0lP g0xsQIIbP1tHCjLaPIEWlir39rQdjub3Z8w8PKOS4Cs/Z+55Q7ufUe9dLVF2KC3N6Rqd 4/3JTaV+vR3Otitlw+/Nn2e3MGKKxaQtfDmQIf0fVXSkXPJqholujpsC1rwRtmpuONrI dmdw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=2keUNVMQ34QaH0CuypKQEHCSwkkwyFQ1/fjpoCwhFU8=; fh=0zBAjxShfumhVJgCQ7/PrZqZq2D8mhtAJK1GC38L6Jc=; b=0rfLg+3zf9EpBHWhqTqKcpMgDOCGDwh0avS23I8DdAZ3JBy2alQRksvioSgTbMy5aq BK/PI7OyLqVO9qy5s8PEQ6A0yptRxb3KjDuueJJnG699Xgpq7Kh0s7fQONoFjVqQ4h+c SRBX1qOud4O1viSFCnBl7uDtVyd8zpnnVllcJdWDwYRbCMhNJ3P6VMuup3DiPTnXMY5t HKJLAPmOmAOyuaSp8Bp3F+KzGAS1XtCxynpHu3rAHiYGgGIjcfsNNplUkbUi0A2c1keg jmof9thKjLZ3xra2gJIP/j+Nyalg1fN4p/pIOmIymDiTCPvz3/A7ucwlSvnU1mLh5zpO 5AkQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=Axn64ntU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from howler.vger.email (howler.vger.email. [23.128.96.34]) by mx.google.com with ESMTPS id l16-20020a170903121000b001c62e465391si5062697plh.147.2023.10.02.06.30.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Oct 2023 06:30:29 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=Axn64ntU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by howler.vger.email (Postfix) with ESMTP id DAA1F809AF8E; Mon, 2 Oct 2023 02:50:00 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at howler.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236289AbjJBJtv (ORCPT + 16 others); Mon, 2 Oct 2023 05:49:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51548 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236287AbjJBJtr (ORCPT ); Mon, 2 Oct 2023 05:49:47 -0400 Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.20]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ED42A10D; Mon, 2 Oct 2023 02:49:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1696240182; x=1727776182; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=sp0x4fJkDtvf5U3jrcchNzXDHSx4PqVE55/imOH1bT4=; b=Axn64ntUCu4JVs+35v0jPCkV9PCp/IMBvVVNZMqj2bspTzNFG7lgwe1O Wm6809huDVD4r6nmOmFpOjRHAK0EbTzEWDlMGoDrglhB7NGp6TSc2JJtq NEOw2urCrUBWVbKlxKiSZChD/qCKPP7XlbJdlJ0UL6yERIbddBr+KUOER 2M22wj0mbHkJqmsD5hQhUXmtRBZn5hB7S6BD3i/phk3vN/wmN2l7W5Hqb 0FJJ6JglCB61zc5rX129ki9AJzNYAFSUTaeDBrJaY0BR0vqERqUKufHQh i6R8/Qc12xx4OpxfUQSruPFrUr30fCuxEntCWlsloodcsFZOd9n4/wR14 w==; X-IronPort-AV: E=McAfee;i="6600,9927,10850"; a="372960722" X-IronPort-AV: E=Sophos;i="6.03,194,1694761200"; d="scan'208";a="372960722" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Oct 2023 02:49:41 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10850"; a="754005604" X-IronPort-AV: E=Sophos;i="6.03,194,1694761200"; d="scan'208";a="754005604" Received: from aanantha-mobl.gar.corp.intel.com (HELO localhost) ([10.251.221.191]) by fmsmga007-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Oct 2023 02:49:37 -0700 From: =?utf-8?q?Ilpo_J=C3=A4rvinen?= To: linux-kselftest@vger.kernel.org, Shuah Khan , Reinette Chatre , =?utf-8?q?Maciej_Wiecz=C3=B3r-?= =?utf-8?q?Retman?= , Shaopeng Tan Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, =?utf-8?q?Ilpo_J?= =?utf-8?q?=C3=A4rvinen?= Subject: [PATCH v4 7/7] selftests/resctrl: Reduce failures due to outliers in MBA/MBM tests Date: Mon, 2 Oct 2023 12:48:13 +0300 Message-Id: <20231002094813.6633-8-ilpo.jarvinen@linux.intel.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20231002094813.6633-1-ilpo.jarvinen@linux.intel.com> References: <20231002094813.6633-1-ilpo.jarvinen@linux.intel.com> MIME-Version: 1.0 X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Mon, 02 Oct 2023 02:50:00 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1778650636001466064 X-GMAIL-MSGID: 1778650636001466064 The initial value of 5% chosen for the maximum allowed percentage difference between resctrl mbm value and IMC mbm value in commit 06bd03a57f8c ("selftests/resctrl: Fix MBA/MBM results reporting format") was "randomly chosen value" (as admitted by the changelog). When running tests in our lab across a large number platforms, 5% difference upper bound for success seems a bit on the low side for the MBA and MBM tests. Some platforms produce outliers that are slightly above that, typically 6-7%, which leads MBA/MBM test frequently failing. Replace the "randomly chosen value" with a success bound that is based on those measurements across large number of platforms by relaxing the MBA/MBM success bound to 8%. The relaxed bound removes the failures due the frequent outliers. Fixes: 06bd03a57f8c ("selftests/resctrl: Fix MBA/MBM results reporting format") Signed-off-by: Ilpo Järvinen Tested-by: Shaopeng Tan Reviewed-by: Reinette Chatre Reviewed-by: Shaopeng Tan Cc: --- tools/testing/selftests/resctrl/mba_test.c | 2 +- tools/testing/selftests/resctrl/mbm_test.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/testing/selftests/resctrl/mba_test.c b/tools/testing/selftests/resctrl/mba_test.c index cf8284dadcb2..d3bf4368341e 100644 --- a/tools/testing/selftests/resctrl/mba_test.c +++ b/tools/testing/selftests/resctrl/mba_test.c @@ -12,7 +12,7 @@ #define RESULT_FILE_NAME "result_mba" #define NUM_OF_RUNS 5 -#define MAX_DIFF_PERCENT 5 +#define MAX_DIFF_PERCENT 8 #define ALLOCATION_MAX 100 #define ALLOCATION_MIN 10 #define ALLOCATION_STEP 10 diff --git a/tools/testing/selftests/resctrl/mbm_test.c b/tools/testing/selftests/resctrl/mbm_test.c index 1ae131a2e246..d3c0d30c676a 100644 --- a/tools/testing/selftests/resctrl/mbm_test.c +++ b/tools/testing/selftests/resctrl/mbm_test.c @@ -11,7 +11,7 @@ #include "resctrl.h" #define RESULT_FILE_NAME "result_mbm" -#define MAX_DIFF_PERCENT 5 +#define MAX_DIFF_PERCENT 8 #define NUM_OF_RUNS 5 static int