From patchwork Mon Oct 2 09:48:10 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Ilpo_J=C3=A4rvinen?= X-Patchwork-Id: 147227 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:612c:2a8e:b0:403:3b70:6f57 with SMTP id in14csp1310536vqb; Mon, 2 Oct 2023 02:51:45 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEKgNmeaMpjNzcHabrsRWwwwdLqK6axK5XbhE4r43tzw8o8R4Ovl/yAM0KD3M1vBDYIU8xr X-Received: by 2002:a05:6870:40c8:b0:1be:c87d:c670 with SMTP id l8-20020a05687040c800b001bec87dc670mr15258467oal.47.1696240304798; Mon, 02 Oct 2023 02:51:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696240304; cv=none; d=google.com; s=arc-20160816; b=up9VwXL6AlBHciYyQKCpQsWE8OtgKYiCK2yQtaWlYViRyFEpGKzCO8/lCDG2pUfTl9 AbGa4vY3seW1R8+ub2nINwkxqyzdDxYQ9v+ExI0j+Qv1/OeO0cqiseO3MuQSqZN2LJn0 nba8f/1SvUFUlVL76lIKfu9ztgBUw1jMgki6PL3gfSgLpVplkaotJURBK+fu0C8TOckl hp4YMeZ7uRnXsZesUuK1g1/LE36bfT4A8urbxD3PNhOYoymrsKRwaBGFk+FpOTD5StMq 0k6MlIESD/mcYAPheRAtGGJXwO+RPdwFugIbaCZ8T0XzNtF7xIqB9wg1SJDjURd1Fp+5 vsqw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=GnO/lvc/kh/QYffXPKp9m3qqkSWAxHDrd542m6ZW9x0=; fh=0zBAjxShfumhVJgCQ7/PrZqZq2D8mhtAJK1GC38L6Jc=; b=hwUCaEQyTw41P8IblPyAMy6z1XAk9m8bjye60s/jBCRBMNsMfm4A/KwAZ0swuUeD8L QH9TSSALyeqlx810ePN0b71Yw7lb6bXNlASP4VG5EWMamEhDQKN/wyAyqUP2ZjFuuzSr Tw7B0Mxb/mZ02cRCFopQM86AqN/DPnRb8dnvZAf/5LAySggl9tQ/Ivt+2ezyyz9eoifs SmA5YI1Pk5lKW5JDKsmMZwe0f3yYUjJiTrrsBYerbbGinL+mmHQZYsuzyytKAmJgNMxQ F9Frhq2qTje0ffK0u7i+pK91c/qS2sw+ExAINzifQwYJLggHFR0T4mfrzDp80RXnAI4I BqpA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b="dvpec/0H"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from groat.vger.email (groat.vger.email. [2620:137:e000::3:5]) by mx.google.com with ESMTPS id v3-20020a655c43000000b00565e386ff44si27396500pgr.702.2023.10.02.02.51.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Oct 2023 02:51:44 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b="dvpec/0H"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id 4AA8F80B79F8; Mon, 2 Oct 2023 02:49:22 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236220AbjJBJtK (ORCPT + 16 others); Mon, 2 Oct 2023 05:49:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42808 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236208AbjJBJtG (ORCPT ); Mon, 2 Oct 2023 05:49:06 -0400 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.120]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DB0808E; Mon, 2 Oct 2023 02:49:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1696240143; x=1727776143; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=h2w4jLDwnHjcUapV1jkntv5pgIa6zmfErB3TZ/IGgk8=; b=dvpec/0Hl2zo6uRGNXfo2EJOZpQCk1NpFhuG/O+7kFxR+p3D+bgPI/G2 yyLRU63/rmyjEwlOWmO3A7pTYMQScDllXrb3c8ikYqlPl8fFyToyqn27n 9LBibQQ2l7zu+jaAKMPJRhDJZ4ytK+wjsBB/CmYWqUUitOjDyfohx+aqI e1klEH1Xg3LueA29bm19oWYVU0rMne3K9iGUxCUnVdonUutgY+RPrQiz9 2Q5Ug6KgRNpoaZ5XGq7+xLHU0cOemf16mNUEPpQs+RfB/UJh9X6MyT0KM Vq2jlDyo58c6A9zpRg4PefyJH6QontK1yMZoP06oAlOYHCN91Fcc1HgOB g==; X-IronPort-AV: E=McAfee;i="6600,9927,10850"; a="381495416" X-IronPort-AV: E=Sophos;i="6.03,194,1694761200"; d="scan'208";a="381495416" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Oct 2023 02:49:03 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10850"; a="820840348" X-IronPort-AV: E=Sophos;i="6.03,194,1694761200"; d="scan'208";a="820840348" Received: from aanantha-mobl.gar.corp.intel.com (HELO localhost) ([10.251.221.191]) by fmsmga004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Oct 2023 02:48:59 -0700 From: =?utf-8?q?Ilpo_J=C3=A4rvinen?= To: linux-kselftest@vger.kernel.org, Shuah Khan , Reinette Chatre , =?utf-8?q?Maciej_Wiecz=C3=B3r-?= =?utf-8?q?Retman?= , Shaopeng Tan Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, =?utf-8?q?Ilpo_J?= =?utf-8?q?=C3=A4rvinen?= Subject: [PATCH v4 4/7] selftests/resctrl: Move _GNU_SOURCE define into Makefile Date: Mon, 2 Oct 2023 12:48:10 +0300 Message-Id: <20231002094813.6633-5-ilpo.jarvinen@linux.intel.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20231002094813.6633-1-ilpo.jarvinen@linux.intel.com> References: <20231002094813.6633-1-ilpo.jarvinen@linux.intel.com> MIME-Version: 1.0 X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Mon, 02 Oct 2023 02:49:22 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1778636873762835164 X-GMAIL-MSGID: 1778636873762835164 _GNU_SOURCE is defined in resctrl.h. Defining _GNU_SOURCE has a large impact on what gets defined when including headers either before or after it. This can result in compile failures if .c file decides to include a standard header file before resctrl.h. It is safer to define _GNU_SOURCE in Makefile so it is always defined regardless of in which order includes are done. Signed-off-by: Ilpo Järvinen Tested-by: Shaopeng Tan Reviewed-by: Reinette Chatre Reviewed-by: Shaopeng Tan Cc: --- tools/testing/selftests/resctrl/Makefile | 2 +- tools/testing/selftests/resctrl/resctrl.h | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/tools/testing/selftests/resctrl/Makefile b/tools/testing/selftests/resctrl/Makefile index 5073dbc96125..2deac2031de9 100644 --- a/tools/testing/selftests/resctrl/Makefile +++ b/tools/testing/selftests/resctrl/Makefile @@ -1,6 +1,6 @@ # SPDX-License-Identifier: GPL-2.0 -CFLAGS = -g -Wall -O2 -D_FORTIFY_SOURCE=2 +CFLAGS = -g -Wall -O2 -D_FORTIFY_SOURCE=2 -D_GNU_SOURCE CFLAGS += $(KHDR_INCLUDES) TEST_GEN_PROGS := resctrl_tests diff --git a/tools/testing/selftests/resctrl/resctrl.h b/tools/testing/selftests/resctrl/resctrl.h index dd07463cdf48..d9b5df95849d 100644 --- a/tools/testing/selftests/resctrl/resctrl.h +++ b/tools/testing/selftests/resctrl/resctrl.h @@ -1,5 +1,4 @@ /* SPDX-License-Identifier: GPL-2.0 */ -#define _GNU_SOURCE #ifndef RESCTRL_H #define RESCTRL_H #include