From patchwork Mon Oct 2 16:45:30 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Doug Anderson X-Patchwork-Id: 147537 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:612c:2a8e:b0:403:3b70:6f57 with SMTP id in14csp1727223vqb; Mon, 2 Oct 2023 15:30:28 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEuraktdYm3PptpYvDbQ88644Z1myxUtEQJT09aoL5ehTaflwZKOJf1dGUzKjCUjmgFZ55/ X-Received: by 2002:a05:6a21:99a0:b0:140:253b:b658 with SMTP id ve32-20020a056a2199a000b00140253bb658mr13202189pzb.57.1696285828586; Mon, 02 Oct 2023 15:30:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696285828; cv=none; d=google.com; s=arc-20160816; b=r3zurhkl0ggqftiZ4+J1F8wAlgciDtYoNJyeMLWA+nB1Sm9CUc142PnXb3mrIStLsF fgKJyq9P/qzitFGBVsqTtJ/FPpOpR0xUOnsfzvp4nAbUO/4/2k3jhVM66AruMW3wVwbu O39yu67Uvt9+43vR2IYRhk4xSRlLnj7U+GjyXjBrhqm5sTBLc1nXAx6PYqnT4CVD3d3o y8qckGjq9LlaD0kCAtRn/DUcl1exKwLYCKuwO3EGTOYyc8wrbzayLBpAkbiT+C3DHu5u epRAMTgzp9vmfp+++8mkQPLzNnVgk1TKSLgY8E8elgpH1nxlA4OpOWLHVI1nmWO89Rq0 7hSQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=+OYydoz0zgcPlyOphP3bRXT7u9ruoeqId11POu4ytwI=; fh=pZ9UizG2yMvstUfFfsYp5su8tDMJIiAtJ6XUlL6trFY=; b=xi8HTAV4jLZSbkP+D+ZnrjS6FAU8kIVJmDLLrtO+rVJZ5KUkoloVDBKOAW4VVNHIWE atrZL0gi0PW22B/SCH5Cg1DBivao/ScUJSs0vS3pBsyceIP+bV0CfGXoGWmsIXPcOL49 gPyt6lebCc2dWr5n9X0hrwoIWF9NL+ZbCDDpcZikdRRAGUh/bJ2RsM0oXj/GZ9ZDQZCQ es9OtPWVUMTQyEdUK/4uDkf3Ukwa5yTihzEtKjNbQThn4JvuAwPxVzf0Jop/aJeERaO2 +o+1OdJ7qzEHLWiclixR8Zp2ne/59GmaZB936DjhXQI4J3q/fxmoKQV1khSb017+rb+6 3mDA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=A0PpqRnW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: from howler.vger.email (howler.vger.email. [23.128.96.34]) by mx.google.com with ESMTPS id ca16-20020a056a00419000b0069342aef90bsi12794048pfb.3.2023.10.02.15.30.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Oct 2023 15:30:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=A0PpqRnW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by howler.vger.email (Postfix) with ESMTP id 098F380A30AC; Mon, 2 Oct 2023 09:46:35 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at howler.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238313AbjJBQqU (ORCPT + 18 others); Mon, 2 Oct 2023 12:46:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57868 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238118AbjJBQqS (ORCPT ); Mon, 2 Oct 2023 12:46:18 -0400 Received: from mail-pg1-x536.google.com (mail-pg1-x536.google.com [IPv6:2607:f8b0:4864:20::536]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 57A229B for ; Mon, 2 Oct 2023 09:46:16 -0700 (PDT) Received: by mail-pg1-x536.google.com with SMTP id 41be03b00d2f7-577e62e2adfso11189385a12.2 for ; Mon, 02 Oct 2023 09:46:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1696265176; x=1696869976; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=+OYydoz0zgcPlyOphP3bRXT7u9ruoeqId11POu4ytwI=; b=A0PpqRnWe9hxuBSn9hu2LQiXhYaWfLEJZuOpcvD2rQxNrISuxbpapn8UDC5+fEg5LS jM8MTn1mCpyflrtIU6ZjbfReR0SkbUlu38t5f9aRir7YeaJgu34QkQijqkeTdKjKw/bT Pu5gZwMgSq07KXhaq/hOH+1T4o8nVkSoItn90= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696265176; x=1696869976; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+OYydoz0zgcPlyOphP3bRXT7u9ruoeqId11POu4ytwI=; b=so+yJrdHUxzp+Trxs0s4pxdAV84+rFlg/eKQ9VQnVTLsmQ00fOv6JWIgcb+vE+cdaG d4mIDYMF51yuFwohT7L26vKtRY8Jzxl5TYdbnxZ7TDY9lm2CnH/AZNFMcydmd0iN9Er4 21V5s1Gfyoxl5n0XCa6KiNN4njUo20BqGza/RGlKbm0h/uZit6yAaq1kxgyZXl+R+t0a TR9w1Ms5xzsj9gmBepaSazBoTYMCKY73hQgGwosa3Y2KbS7yBHIt0ZHjahFAhkCU4kE2 N1bSNCSeDXYKX+79vfb0Xcu3EJsPUyP2oJOHKJ8ZDin+rbg6fqVN4LNHIQ++VdKBjOn8 fh1w== X-Gm-Message-State: AOJu0YwyCY/OLFb3w+fCD3wCjtame+ZCkrGJj7giAYrwwuWOzV0yeUJY GGMu+h/q8w/NH0e8MjXF5248Ag== X-Received: by 2002:a05:6a21:47cb:b0:163:e1a1:5a16 with SMTP id as11-20020a056a2147cb00b00163e1a15a16mr4527290pzc.31.1696265175774; Mon, 02 Oct 2023 09:46:15 -0700 (PDT) Received: from tictac2.mtv.corp.google.com ([2620:15c:9d:2:bb:b2b6:1831:5edd]) by smtp.gmail.com with ESMTPSA id n3-20020a170902d2c300b001c737950e4dsm8455904plc.2.2023.10.02.09.46.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Oct 2023 09:46:15 -0700 (PDT) From: Douglas Anderson To: Catalin Marinas , Will Deacon , Mark Rutland , Marc Zyngier Cc: Stephen Boyd , Valentin Schneider , Chen-Yu Tsai , Douglas Anderson , D Scott Phillips , Josh Poimboeuf , Peter Zijlstra , Sumit Garg , Thomas Gleixner , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 2/2] arm64: smp: Don't directly call arch_smp_send_reschedule() for wakeup Date: Mon, 2 Oct 2023 09:45:30 -0700 Message-ID: <20231002094526.2.I2e6d22fc42ccbf6b26465a28a10e36e05ccf3075@changeid> X-Mailer: git-send-email 2.42.0.582.g8ccd20d70d-goog In-Reply-To: <20231002094526.1.Ie8f760213053e3d11592f892b30912dbac6b8b48@changeid> References: <20231002094526.1.Ie8f760213053e3d11592f892b30912dbac6b8b48@changeid> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Mon, 02 Oct 2023 09:46:35 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1778666102876575552 X-GMAIL-MSGID: 1778684608742374675 In commit 2b2d0a7a96ab ("arm64: smp: Remove dedicated wakeup IPI") we started using a scheduler IPI to avoid a dedicated reschedule. When we did this, we used arch_smp_send_reschedule() directly rather than calling smp_send_reschedule(). The only difference is that calling arch_smp_send_reschedule() directly avoids tracing. Presumably we _don't_ want to avoid tracing here, so switch to smp_send_reschedule(). Fixes: 2b2d0a7a96ab ("arm64: smp: Remove dedicated wakeup IPI") Signed-off-by: Douglas Anderson --- I don't 100% know if this is correct and I don't have any hardware that uses the "ACPI parking protocol", but I think it's right. My main incentive for this is that it makes it easier to backport pseudo-NMI to kernels that don't have arch_smp_send_reschedule(), but I think it's also more correct. If for some reason we truly did want to avoid tracing here, please shout and we can drop this patch. arch/arm64/kernel/smp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/kernel/smp.c b/arch/arm64/kernel/smp.c index 0a6002243a8c..b530d8ef9c1d 100644 --- a/arch/arm64/kernel/smp.c +++ b/arch/arm64/kernel/smp.c @@ -1063,7 +1063,7 @@ void arch_send_wakeup_ipi(unsigned int cpu) * We use a scheduler IPI to wake the CPU as this avoids the need for a * dedicated IPI and we can safely handle spurious scheduler IPIs. */ - arch_smp_send_reschedule(cpu); + smp_send_reschedule(cpu); } #endif