diff mbox series

gpio: pca953x: Convert to use maple tree register cache

Message ID 20230929-gpio-pca953x-maple-v1-1-d7960eac3d07@kernel.org
State New
Headers
Series gpio: pca953x: Convert to use maple tree register cache |

Commit Message

Mark Brown Sept. 29, 2023, 12:24 p.m. UTC 
  The maple tree register cache is based on a much more modern data structure
than the rbtree cache and makes optimisation choices which are probably
more appropriate for modern systems than those made by the rbtree cache.

Signed-off-by: Mark Brown <broonie@kernel.org>
---
 drivers/gpio/gpio-pca953x.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)


---
base-commit: 6465e260f48790807eef06b583b38ca9789b6072
change-id: 20230929-gpio-pca953x-maple-b39b99cd90db

Best regards,

Comments

andy@kernel.org Oct. 1, 2023, 9:24 a.m. UTC | #1 
On Fri, Sep 29, 2023 at 02:24:13PM +0200, Mark Brown wrote:
> The maple tree register cache is based on a much more modern data structure
> than the rbtree cache and makes optimisation choices which are probably
> more appropriate for modern systems than those made by the rbtree cache.

Reviewed-by: Andy Shevchenko <andy@kernel.org>
Bartosz Golaszewski Oct. 2, 2023, 6:58 a.m. UTC | #2 
On Fri, Sep 29, 2023 at 2:24 PM Mark Brown <broonie@kernel.org> wrote:
>
> The maple tree register cache is based on a much more modern data structure
> than the rbtree cache and makes optimisation choices which are probably
> more appropriate for modern systems than those made by the rbtree cache.
>
> Signed-off-by: Mark Brown <broonie@kernel.org>
> ---
>  drivers/gpio/gpio-pca953x.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpio/gpio-pca953x.c b/drivers/gpio/gpio-pca953x.c
> index bdd50a78e414..528ccb59b52a 100644
> --- a/drivers/gpio/gpio-pca953x.c
> +++ b/drivers/gpio/gpio-pca953x.c
> @@ -414,7 +414,7 @@ static const struct regmap_config pca953x_i2c_regmap = {
>         .volatile_reg = pca953x_volatile_register,
>
>         .disable_locking = true,
> -       .cache_type = REGCACHE_RBTREE,
> +       .cache_type = REGCACHE_MAPLE,
>         .max_register = 0x7f,
>  };
>
> @@ -430,7 +430,7 @@ static const struct regmap_config pca953x_ai_i2c_regmap = {
>         .volatile_reg = pca953x_volatile_register,
>
>         .disable_locking = true,
> -       .cache_type = REGCACHE_RBTREE,
> +       .cache_type = REGCACHE_MAPLE,
>         .max_register = 0x7f,
>  };
>
>
> ---
> base-commit: 6465e260f48790807eef06b583b38ca9789b6072
> change-id: 20230929-gpio-pca953x-maple-b39b99cd90db
>
> Best regards,
> --
> Mark Brown <broonie@kernel.org>
>

Applied, thanks!

Bart
diff mbox series

Patch

diff --git a/drivers/gpio/gpio-pca953x.c b/drivers/gpio/gpio-pca953x.c
index bdd50a78e414..528ccb59b52a 100644
--- a/drivers/gpio/gpio-pca953x.c
+++ b/drivers/gpio/gpio-pca953x.c
@@ -414,7 +414,7 @@  static const struct regmap_config pca953x_i2c_regmap = {
 	.volatile_reg = pca953x_volatile_register,
 
 	.disable_locking = true,
-	.cache_type = REGCACHE_RBTREE,
+	.cache_type = REGCACHE_MAPLE,
 	.max_register = 0x7f,
 };
 
@@ -430,7 +430,7 @@  static const struct regmap_config pca953x_ai_i2c_regmap = {
 	.volatile_reg = pca953x_volatile_register,
 
 	.disable_locking = true,
-	.cache_type = REGCACHE_RBTREE,
+	.cache_type = REGCACHE_MAPLE,
 	.max_register = 0x7f,
 };