From patchwork Thu Sep 28 11:02:20 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jeff Layton X-Patchwork-Id: 146003 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:cae8:0:b0:403:3b70:6f57 with SMTP id r8csp3234656vqu; Thu, 28 Sep 2023 04:21:52 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHO4l4JWn0Zjy5rHf0QxCXVC+QMLqj3pkw8qHVR6MJpi+h3hKd3F1b4a/LmodqSRhuHNPTX X-Received: by 2002:a54:470f:0:b0:3ae:4cae:8803 with SMTP id k15-20020a54470f000000b003ae4cae8803mr889329oik.16.1695900112194; Thu, 28 Sep 2023 04:21:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695900112; cv=none; d=google.com; s=arc-20160816; b=UpZRGbLYXin1hNpRAj5lwDkiDVzXj1OPZrE36EimYk6VHJuy+CKQR+xYaKZc4zfls5 c171a0qXd508PMpfVCeAaMdox0lK7eUbSvLsBQdD793a/HohAvKh0/EdgD0K51tH3ImZ oEfzK4vcE4WPx8iXJc3jTQwiGR2cZmHz4qTwItgSJMHwfAf6w25NAjhEUVzWx0QiQYb3 a67EjDbMG31If1y4RGhsPggTkV9FsZSxgXu4uUlctPje7gQD+Eh0sJgCGVOgkLdPPOiS n5J1Y3WzlNw+rPZePuq/FUukQ6GOkZrq/CMZEuYcU5OccWVEQ08iWYY/uwRYp0SkFPgQ R6dQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=GKXANnYgStHpijT524HZ637Y170/CJsMU8YYLb5oiq8=; fh=xIe+y0AIA/13BB/Cht5aiJtIw4tu3ICDozyOO0XAK3c=; b=z9mqvEXHTb7rLDGER8DoE2cp8S9L3KZwFlKkI3DL6iGz7W+LstLgN5VtlT3cWcwiJl eWLxp+5MwuZOGb6aIrh7MrYITphnYZmt0W/KNyw9gCvIjGARPHW7aM2PUDInEo7QD0BK 5yX2zbk4yZV/r4ooS+lv06HmMxL5i3A9yzx7aDvL2gZolqnbUDb1K3N2iP/vJ1O5jNOd ck2w0d+mR9QoKbw/H0v82AsmEATfZQcBoeCtPtsonDtYXIlKb/zr2N9StkFh6aWKtZpV JdDnoiaV23hblQ3PyngA4pDJaaVcDoYgVz9+1CRibpDKK0tOW5Iv8weAZ4/ImortDTNR 349g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Hdz1GGMD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from snail.vger.email (snail.vger.email. [2620:137:e000::3:7]) by mx.google.com with ESMTPS id i184-20020a6387c1000000b0057d7cff25b5si15686262pge.258.2023.09.28.04.21.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Sep 2023 04:21:52 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Hdz1GGMD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 3A80082F27D7; Thu, 28 Sep 2023 04:05:30 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232248AbjI1LFM (ORCPT + 21 others); Thu, 28 Sep 2023 07:05:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56778 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232045AbjI1LEb (ORCPT ); Thu, 28 Sep 2023 07:04:31 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6F2C2CFC; Thu, 28 Sep 2023 04:04:25 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8E37FC433C7; Thu, 28 Sep 2023 11:04:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1695899065; bh=cXvhQkkGpOgsc0ELKlchqmSPWWV4/XY2qNHuw52SmqU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Hdz1GGMD7Vkz1trWmZe+MAIrycsD6w+ykdbjJl/6qtBpgAOWCWWYLP0E5KCgjLLyN 6F6GyR/ODAdFEaO5JLfy/5T2ugxoaQXBU8QZKMkrOnws+vYgO+mdSTvRW+1GweRS7G 4f6BG2PzRVr0NamMXpGuUQWR9mh0UkecaEZyb2NP8YGjopQGKnPba0T612ARuYvF5R quDWh15wjMATCYdswtWOt7ChygA1/6S30LJaY2MSAnZSshTisF/jvz9hTrwpH0gKiC +v6pB8bOuOEwDn73gQ1XFqCJYho2w4WD1hAQhjrIicBHXYuyjIEMoR+1zy85k1XYyt /IpwnIC7DQl5w== From: Jeff Layton To: Alexander Viro , Christian Brauner , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Cc: linux-serial@vger.kernel.org Subject: [PATCH 11/87] drivers/tty: convert to new inode {a,m}time accessors Date: Thu, 28 Sep 2023 07:02:20 -0400 Message-ID: <20230928110413.33032-10-jlayton@kernel.org> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230928110413.33032-1-jlayton@kernel.org> References: <20230928110300.32891-1-jlayton@kernel.org> <20230928110413.33032-1-jlayton@kernel.org> MIME-Version: 1.0 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Thu, 28 Sep 2023 04:05:30 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1778280156159064044 X-GMAIL-MSGID: 1778280156159064044 Signed-off-by: Jeff Layton --- drivers/tty/tty_io.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/drivers/tty/tty_io.c b/drivers/tty/tty_io.c index 8a94e5a43c6d..d13d2f2e76c7 100644 --- a/drivers/tty/tty_io.c +++ b/drivers/tty/tty_io.c @@ -818,7 +818,7 @@ static void tty_update_time(struct tty_struct *tty, bool mtime) spin_lock(&tty->files_lock); list_for_each_entry(priv, &tty->tty_files, list) { struct inode *inode = file_inode(priv->file); - struct timespec64 *time = mtime ? &inode->i_mtime : &inode->i_atime; + struct timespec64 time = mtime ? inode_get_mtime(inode) : inode_get_atime(inode); /* * We only care if the two values differ in anything other than the @@ -826,8 +826,12 @@ static void tty_update_time(struct tty_struct *tty, bool mtime) * the time of the tty device, otherwise it could be construded as a * security leak to let userspace know the exact timing of the tty. */ - if ((sec ^ time->tv_sec) & ~7) - time->tv_sec = sec; + if ((sec ^ time.tv_sec) & ~7) { + if (mtime) + inode_set_mtime(inode, sec, 0); + else + inode_set_atime(inode, sec, 0); + } } spin_unlock(&tty->files_lock); }