From patchwork Thu Sep 28 07:06:21 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Herve Codina X-Patchwork-Id: 146222 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:cae8:0:b0:403:3b70:6f57 with SMTP id r8csp3467317vqu; Thu, 28 Sep 2023 10:10:09 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEBUiWtHxyKF50OSxGiSAQnj47gtHgoYKWFGdhvdWMgTJyfoGmGqSYt9+g5EminbR5mYlfw X-Received: by 2002:a05:6a21:614:b0:13d:17cc:5bca with SMTP id ll20-20020a056a21061400b0013d17cc5bcamr1429934pzb.18.1695921009533; Thu, 28 Sep 2023 10:10:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695921009; cv=none; d=google.com; s=arc-20160816; b=DmOSOF6+nKlqOCzBqhYp/U0lE/4jyTkO2iNKXJQt/+wI+1NG5S0Kf0ATM1LlrqT8bk nygnQcAlxemnYniODlrhwg3RNDlFzx01broKAoVntsFnH8lwC1xCp6bLMBu7yvH4nmsf XnOTn/bh9fVeC+xuj16zqO24HP1FBte9ncaQy/oaDv80Wkszph/FwUrxpk20NhnKBGjo Uvum0FF871tbe9E3sRf5fgU5u+jZa35YfiqQbUQQNA/hq40tChxg0EOGBAPBKnBsVjG1 DFKpdCDZZAS5l7K2ngGZl0CVokD5WXC/Nw1twieiVNhTtKsWtbDQtqP8zNBbNMCkXHCe FpSQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=Vsq3fcsRQ92trwLtB4WXIyAHgTZzHeLSP3hrA+1+hQo=; fh=8Kc64rxAF0/ep7JtUzveSO6N9QMBWtHyiJ9nqNn2Uww=; b=s0yWPT/+zML2SwrA+9uzgyLnvBxduaRpm15vBfRV3wOQtvM+pm+Wlf42sMQ8+Qx5eu 15wTQv3WZpPHa7IVYYCrWgnLjenpH//cSuPlACRpJ41T/P1zW9Glf+KXr7bLZkQ7keoX 0+yb9vggRFim5m6zt2PKZAlqbEaNMhZu5/rFWuucnrIB+BmxZAKI8kjB4VbwdjoC1JJg FcUIrzFnXxTxfdVIBAW2XFYsqXqXtJBfCAMIkKmb9zAwUXYJhBxHVCC114BE+019rUV4 v+q8LtbCnR5l0OSvwow2Uvzds43goUdmGjlHIH13ZbqtomidUUI6zIRDM+c0Zv6QGcGy aJ4w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@bootlin.com header.s=gm1 header.b=n3T18kcC; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=bootlin.com Received: from agentk.vger.email (agentk.vger.email. [23.128.96.32]) by mx.google.com with ESMTPS id o7-20020a17090ab88700b002791e9b60f9si972460pjr.48.2023.09.28.10.10.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Sep 2023 10:10:09 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32; Authentication-Results: mx.google.com; dkim=pass header.i=@bootlin.com header.s=gm1 header.b=n3T18kcC; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=bootlin.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id 50CB4805ED0D; Thu, 28 Sep 2023 00:08:24 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231474AbjI1HID (ORCPT + 20 others); Thu, 28 Sep 2023 03:08:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33812 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231144AbjI1HHV (ORCPT ); Thu, 28 Sep 2023 03:07:21 -0400 Received: from relay7-d.mail.gandi.net (relay7-d.mail.gandi.net [217.70.183.200]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F0AA6CCF; Thu, 28 Sep 2023 00:07:16 -0700 (PDT) Received: by mail.gandi.net (Postfix) with ESMTPA id 1654A20008; Thu, 28 Sep 2023 07:07:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1695884835; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Vsq3fcsRQ92trwLtB4WXIyAHgTZzHeLSP3hrA+1+hQo=; b=n3T18kcCISxek/R3VhYZWIoJH2e9PChOnLVmExmd8R3u/Qt911xTDLpETy0D77k1EXiVzS HbzxHrLquzaNMHDZ7W/NRHBOMiuuyMPQU5Lg8JII/FAqoPqWPmX1Hf1wr1TPs8o6Aa5Ebp HKvJELhogSf4BM/8sBw2fQeqAW8FMCq+Xs1D6i0Q7+OPW/l5YVXEVzQ8/TtwZuziSJ61yh ow9ESlLrMK3hw7fYiuZLe4APkHHpVbYN9MgGcE9wIyFswTwH8P4Zvtivzub3xB4lh/dTNi TwACeNuJHz0znnM42Q+kSqIOo/h8BSxpywKaOlAcMuDGKCYtO/rnrMHvUc5rcA== From: Herve Codina To: Herve Codina , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Andrew Lunn , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Linus Walleij , Qiang Zhao , Li Yang , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Shengjiu Wang , Xiubo Li , Fabio Estevam , Nicolin Chen , Christophe Leroy , Randy Dunlap Cc: netdev@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, alsa-devel@alsa-project.org, Simon Horman , Christophe JAILLET , Thomas Petazzoni Subject: [PATCH v7 03/30] soc: fsl: cpm1: qmc: Fix rx channel reset Date: Thu, 28 Sep 2023 09:06:21 +0200 Message-ID: <20230928070652.330429-4-herve.codina@bootlin.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230928070652.330429-1-herve.codina@bootlin.com> References: <20230928070652.330429-1-herve.codina@bootlin.com> MIME-Version: 1.0 X-GND-Sasl: herve.codina@bootlin.com X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Thu, 28 Sep 2023 00:08:24 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1778302068607436931 X-GMAIL-MSGID: 1778302068607436931 The qmc_chan_reset_rx() set the is_rx_stopped flag. This leads to an inconsistent state in the following sequence. qmc_chan_stop() qmc_chan_reset() Indeed, after the qmc_chan_reset() call, the channel must still be stopped. Only a qmc_chan_start() call can move the channel from stopped state to started state. Fix the issue removing the is_rx_stopped flag setting from qmc_chan_reset() Fixes: 3178d58e0b97 ("soc: fsl: cpm1: Add support for QMC") Signed-off-by: Herve Codina Reviewed-by: Christophe Leroy --- drivers/soc/fsl/qe/qmc.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/soc/fsl/qe/qmc.c b/drivers/soc/fsl/qe/qmc.c index 7ad0d77f1740..8dc73cc1a83b 100644 --- a/drivers/soc/fsl/qe/qmc.c +++ b/drivers/soc/fsl/qe/qmc.c @@ -685,7 +685,6 @@ static void qmc_chan_reset_rx(struct qmc_chan *chan) qmc_read16(chan->s_param + QMC_SPE_RBASE)); chan->rx_pending = 0; - chan->is_rx_stopped = false; spin_unlock_irqrestore(&chan->rx_lock, flags); }