From patchwork Thu Sep 28 07:06:39 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Herve Codina X-Patchwork-Id: 146396 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:cae8:0:b0:403:3b70:6f57 with SMTP id r8csp3731479vqu; Thu, 28 Sep 2023 19:18:04 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFdNxn6E+ptPGtbE8qMA6fnOiwyrOEByzax3orHg1B8ldxhXgRWbgEY+TomwTlXz/ZDWDqO X-Received: by 2002:a05:6a20:734c:b0:11f:4707:7365 with SMTP id v12-20020a056a20734c00b0011f47077365mr3175588pzc.38.1695953883760; Thu, 28 Sep 2023 19:18:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695953883; cv=none; d=google.com; s=arc-20160816; b=DGM5BqQPSwhA8Jg1Ji+RroAs/hhO3OUA9usjPVgxO9IZEa3Fcx5o7OIvECpifwqHOU VAf5tlVOvCUQiT+oR7WWdb1kbTgqR8RMxxeA3XDEy7uM5Y7mv7OT5VaZ4K40DY0M4N72 7lqFblsl05KqKhpsmF4nxQ7hqzGwGgBai5fw4dernAhpw7PGgZVH1dICO3+jE0BowS7Q 0gNaMXjAMY5aOevEAX35tD/LaJaUglsQfZxmpFiaqj2tDZJuO1P7Tv7k96OmrLf43tCH gUOaDfxSpGtrhXxABrmm6gELCpA56BwbvjUki5qHvjD68fIS3fqYm7Hd7We72SiTYlye lFkw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=6uqdKgSiDG4ViV4ixZAwBWMC5+BSFyshQvmKaykUU3o=; fh=8Kc64rxAF0/ep7JtUzveSO6N9QMBWtHyiJ9nqNn2Uww=; b=xZXH7v8y7DmWIdkvko47HNiIs/s6qneXydwepl4uPJxnXHHuS5IPndvHc+7vuivKLm 7z+KwA0/aEI09HMg9vQaPcfl1WNLb0b9nE1TVKaCJ92b7dNfzNAepc4Kcw4BVG8JB34C xoNp/Tp6snrrp3G2llJPBqIMAKZHOz9yzgPlnk2FCCcbf5ZwO8N8ddJzuIvbsZj57hrM MgWF8Kwzl7zrnrFmpIkK4cKbyyQdy8LKan4IHKWpcWH1hecx6NNQL8ZTJ9V73lafMzLg s3ct08Bd6bhabfTuprcgarmgKkCVkX9FkOhuvBGo6Or8yZNRhY8wSYFtvf2cQBcT31hG 32Dw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@bootlin.com header.s=gm1 header.b=YfnAlbFY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=bootlin.com Received: from howler.vger.email (howler.vger.email. [23.128.96.34]) by mx.google.com with ESMTPS id j4-20020a170902da8400b001c5de4a5b4esi6685457plx.597.2023.09.28.19.18.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Sep 2023 19:18:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34; Authentication-Results: mx.google.com; dkim=pass header.i=@bootlin.com header.s=gm1 header.b=YfnAlbFY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=bootlin.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by howler.vger.email (Postfix) with ESMTP id 2E71A83B008F; Thu, 28 Sep 2023 00:22:05 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at howler.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231272AbjI1HVy (ORCPT + 20 others); Thu, 28 Sep 2023 03:21:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59312 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231163AbjI1HVl (ORCPT ); Thu, 28 Sep 2023 03:21:41 -0400 Received: from relay7-d.mail.gandi.net (relay7-d.mail.gandi.net [IPv6:2001:4b98:dc4:8::227]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A28B0273F; Thu, 28 Sep 2023 00:08:24 -0700 (PDT) Received: by mail.gandi.net (Postfix) with ESMTPA id 1533920011; Thu, 28 Sep 2023 07:08:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1695884901; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6uqdKgSiDG4ViV4ixZAwBWMC5+BSFyshQvmKaykUU3o=; b=YfnAlbFYBXcbt+SYdv+w+EIKQhMpVWtoVAfztjsbzwHHVWs7fLj32pvHY6MCqVaoo4c9XJ 9wOOHa4LLYZK0vY/JGyoW/+C5NjNZMR6UC6LqYIm8+XVMDorg/syksrqfeMV0yIyH19gx+ zfVXO1ObSvRGoCj552V+tCkGBZbicshVavUJEItPsvaI6sJsndc32R2P4ff3mFPy+2rfnu 8hNNaDjfE5dOY7LuLw9Hvn+0wE4d7GyJrOqaYC4XEak00qGZUgr0LyY/aMhI70a6s+d671 anb+klMvfdhxEwQChtG0+fjmltFty/cnlH13WoMDiCZXpIyru90M68+ji9dGzQ== From: Herve Codina To: Herve Codina , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Andrew Lunn , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Linus Walleij , Qiang Zhao , Li Yang , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Shengjiu Wang , Xiubo Li , Fabio Estevam , Nicolin Chen , Christophe Leroy , Randy Dunlap Cc: netdev@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, alsa-devel@alsa-project.org, Simon Horman , Christophe JAILLET , Thomas Petazzoni Subject: [PATCH v7 21/30] soc: fsl: cpm1: qmc: Remove timeslots handling from setup_chan() Date: Thu, 28 Sep 2023 09:06:39 +0200 Message-ID: <20230928070652.330429-22-herve.codina@bootlin.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230928070652.330429-1-herve.codina@bootlin.com> References: <20230928070652.330429-1-herve.codina@bootlin.com> MIME-Version: 1.0 X-GND-Sasl: herve.codina@bootlin.com X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Thu, 28 Sep 2023 00:22:05 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1778336539999471932 X-GMAIL-MSGID: 1778336539999471932 Timeslots setting is done at channel start() and stop(). There is no more need to do that during setup_chan(). Simply remove timeslot setting from setup_chan(). Signed-off-by: Herve Codina Reviewed-by: Christophe Leroy --- drivers/soc/fsl/qe/qmc.c | 28 ---------------------------- 1 file changed, 28 deletions(-) diff --git a/drivers/soc/fsl/qe/qmc.c b/drivers/soc/fsl/qe/qmc.c index 185e6e87a83f..b63b54ec0a3a 100644 --- a/drivers/soc/fsl/qe/qmc.c +++ b/drivers/soc/fsl/qe/qmc.c @@ -723,30 +723,6 @@ static int qmc_chan_setup_tsa_rx(struct qmc_chan *chan, bool enable) return qmc_chan_setup_tsa_32rx(chan, &info, enable); } -static int qmc_chan_setup_tsa(struct qmc_chan *chan, bool enable) -{ - struct tsa_serial_info info; - int ret; - - /* Retrieve info from the TSA related serial */ - ret = tsa_serial_get_info(chan->qmc->tsa_serial, &info); - if (ret) - return ret; - - /* - * Setup one common 64 entries table or two 32 entries (one for Tx - * and one for Tx) according to assigned TS numbers. - */ - if (chan->qmc->is_tsa_64rxtx) - return qmc_chan_setup_tsa_64rxtx(chan, &info, enable); - - ret = qmc_chan_setup_tsa_32rx(chan, &info, enable); - if (ret) - return ret; - - return qmc_chan_setup_tsa_32tx(chan, &info, enable); -} - static int qmc_chan_command(struct qmc_chan *chan, u8 qmc_opcode) { return cpm_command(chan->id << 2, (qmc_opcode << 4) | 0x0E); @@ -1323,10 +1299,6 @@ static int qmc_setup_chan(struct qmc *qmc, struct qmc_chan *chan) chan->qmc = qmc; - ret = qmc_chan_setup_tsa(chan, true); - if (ret) - return ret; - /* Set channel specific parameter base address */ chan->s_param = qmc->dpram + (chan->id * 64); /* 16 bd per channel (8 rx and 8 tx) */