From patchwork Wed Sep 27 08:10:21 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 145242 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:cae8:0:b0:403:3b70:6f57 with SMTP id r8csp2472142vqu; Wed, 27 Sep 2023 01:24:12 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGTImpVP8RaYrTjkb9bf1Cemn+UaRyf5dwiAdO7T2OW0j5AIcrqmwWIC76pMGg2W1UtK1eD X-Received: by 2002:a67:f783:0:b0:44d:453c:a838 with SMTP id j3-20020a67f783000000b0044d453ca838mr1401352vso.5.1695803052439; Wed, 27 Sep 2023 01:24:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695803052; cv=none; d=google.com; s=arc-20160816; b=jueilyR13K2AeH63wg/GmAFmJQu8mbTbEc/Knog9Yf5ZVcQRUoALqxdHmM2kSrbi04 aOrWeZNFJx5/CVJZBxlCnxRV7lPqstOJYxBkYpVBv8dY2qEuv8+LCdEDs4aJQdTNXV2v YAhCF5ZSM0I4r5lZ1HCA9R8VtXfvykhMKDPPqyeLSWu9eIEoyIeTTM23uAVX1EiPeDCa fSkpcR+7tI4asoaieD2eDrQENSu/v4O00JjLkw8JQrM3z6lp0DFBD4uHm1awN8pFRsGR zDh0z0nDmZ9kG/AMtG4DBFE8Gj6o53MIg/uEU8HkZ9iOuOmNzfvcahHlT1RTSkVsFIVf IOow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=R1Q4yW38+5NUAiukHDnUA71Hs+qAnyhwjQsKeJWNH9o=; fh=tvpsHzPvtm0gh7120bvi7gWj2SOVstdyYP1UyHOkWL0=; b=diucQfTwH3hStiiJq0nyXqUEGPnRWfxTm+d6s1wJLxjF+CQdmt6pPwhARQ3Apj33FN Y825OtKIesvdnuNaB5d8GFu3hj3Ysbsxy8f2zAFHcKEsZmToBHJqQs5IItQOzr47JW5I gDSMUEZYoEpjCJVEkNpKFpBIKCIXOTdvLWY3WomwOJ73/VaJz4aBQP6uLxiK9wJase1S BWD/+msPAHYfO0Edu4ggqnH+GmyanqPIMLCpR7j5wyNIJ4ECKWbn6x7+LRHSN1wZoVXR jFNIemqi9ewAvXRoc4XBixF/o7WcndEA0PU6ZmlQpzFnNpImKSIjElPw3NkEjcilEjBP nSNg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from agentk.vger.email (agentk.vger.email. [23.128.96.32]) by mx.google.com with ESMTPS id e23-20020a63db17000000b00578d026e2eesi14220848pgg.283.2023.09.27.01.24.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Sep 2023 01:24:12 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id 62E60801D59A; Wed, 27 Sep 2023 01:12:14 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230225AbjI0ILo (ORCPT + 23 others); Wed, 27 Sep 2023 04:11:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33124 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230174AbjI0ILA (ORCPT ); Wed, 27 Sep 2023 04:11:00 -0400 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [IPv6:2a0a:edc0:2:b01:1d::104]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F0115CC0 for ; Wed, 27 Sep 2023 01:10:55 -0700 (PDT) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qlPd9-0007wR-W6; Wed, 27 Sep 2023 10:10:48 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qlPd9-009I7H-HW; Wed, 27 Sep 2023 10:10:47 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1qlPd9-005BQY-8S; Wed, 27 Sep 2023 10:10:47 +0200 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Benson Leung , Tzung-Bi Shih Cc: chrome-platform@lists.linux.dev, linux-kernel@vger.kernel.org, kernel@pengutronix.de Subject: [PATCH 08/27] platform/chrome: cros_usbpd_logger: Convert to platform remove callback returning void Date: Wed, 27 Sep 2023 10:10:21 +0200 Message-Id: <20230927081040.2198742-9-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20230927081040.2198742-1-u.kleine-koenig@pengutronix.de> References: <20230927081040.2198742-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1915; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=OR3i3JXD2RroVrhEaYXFvH7Zyx63QW9KL3sGpWCOSHI=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBlE+NmcnjMJd1YF7F9Gmo1cKEwJETNMDNXQ8MpI +/rkZ4CkG2JATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZRPjZgAKCRCPgPtYfRL+ TsedCACLo1awQfxrjnzfeCY8rAFtLXItTZBOhX68W7MhGBIue8KMiomkwzPEc4QO2EGPuHyBJgc LEP/AZ56sPA9AGaWsxnQcswD0DN2d0rKTQZrMONwkPrnf2ba5avG+mhOLWbVs3FN4aAbx9gj8Sj M7ZbJnExojsGA6df6k1o5sZtaYh1vaOftfre8XIn7A1c2Tw0fv4BzUsrYYpA6Su2qhGNtvZrTi+ zEQ+8DaALtH/U6mOIGuLgjEBNwBVdzanKp9WBp+yamwv2JRQxcg7ZnwYEfIlCHT2TYtg69YwJfE rgkWghOhE7zWiSQg1zZPqW4RspRoLL2GDNfOtf9gFNq5Wciu X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Wed, 27 Sep 2023 01:12:14 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1778178381240170962 X-GMAIL-MSGID: 1778178381240170962 The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/platform/chrome/cros_usbpd_logger.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/platform/chrome/cros_usbpd_logger.c b/drivers/platform/chrome/cros_usbpd_logger.c index d16931203d82..f618757f8b32 100644 --- a/drivers/platform/chrome/cros_usbpd_logger.c +++ b/drivers/platform/chrome/cros_usbpd_logger.c @@ -219,14 +219,12 @@ static int cros_usbpd_logger_probe(struct platform_device *pd) return 0; } -static int cros_usbpd_logger_remove(struct platform_device *pd) +static void cros_usbpd_logger_remove(struct platform_device *pd) { struct logger_data *logger = platform_get_drvdata(pd); cancel_delayed_work_sync(&logger->log_work); destroy_workqueue(logger->log_workqueue); - - return 0; } static int __maybe_unused cros_usbpd_logger_resume(struct device *dev) @@ -257,7 +255,7 @@ static struct platform_driver cros_usbpd_logger_driver = { .pm = &cros_usbpd_logger_pm_ops, }, .probe = cros_usbpd_logger_probe, - .remove = cros_usbpd_logger_remove, + .remove_new = cros_usbpd_logger_remove, }; module_platform_driver(cros_usbpd_logger_driver);