From patchwork Wed Sep 27 08:10:40 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 145260 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:cae8:0:b0:403:3b70:6f57 with SMTP id r8csp2478664vqu; Wed, 27 Sep 2023 01:39:41 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEcuDhMINDWP3K1XB8wZwMRnarn4Bz6Rrb4Xt1lliAsNYC5s5SCVMVLys4XLnVZIkcIqg3o X-Received: by 2002:a17:90b:344:b0:268:4485:c868 with SMTP id fh4-20020a17090b034400b002684485c868mr908128pjb.49.1695803981103; Wed, 27 Sep 2023 01:39:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695803981; cv=none; d=google.com; s=arc-20160816; b=dUGNNgx6U1Iic/SuBNH6N0wqr2+JBv1O2YbezyNzZrsP+Wlc4l0oVenj/vyW84KGdP zrrZPZRy662QjvrK2XA9vB8vxcD7FSPpCr1yWP+CqvObkMYLXNh7eKrJSMZTdIEkGq5g ttQCp9XKbcVgLHiJhrhN/7nYGnMCyfiRBa951z/8YHg/3bFsv84LkRx9Xp1TbtMcSHir 5mPcsqN48tmhnd3Tuy7/pKj8KnjKZKyXr0CaKqxPxFqOwHs4ht+2YzbkyrX3SyMznerh ofwmwrPIw/X7haTQLa9DQyAjRwN52r7HeaTu54+k62/2MrWUeqigSCg2cTw45CzVBguI eazQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=ehdgxq0iitXhdtMbA2sqDJ8hG3IitTOYEZDcKtNW0RU=; fh=2kkSTK4+HYKWTRWQ+Em0Wq821f+qWrh0O+CnTS97Wu4=; b=aP1CEDralZRJ0jwvNgW8n3xHF0fyMQ9q9O8jT8fhQEG4CBE+X/dn59q5wugnmlEsa1 LtZ1hEAqjQTc7aIRvYU6oTW+zCSknGjbt4b6Jf57gbEN5espyIpXdXdVbdWL57IxH3Qq WBKEhgCZluA4Z53yqQJArWsCttXtd/LrGXR40gqlxr2lgtEm58UsR4TKK/PgHqH3Td2r JPrr4Mq9WokhvRHVMfTtZqYhUlZnTDM/QwcQuBHDsPjSP3wIsnbvBY+J1L+a5CTDkuvh YYsQh+jPyWZ4GVv2hFMQDVqNBqtL+8hOpoKTX4h2TYklFHD+AWYlIlfrBZt99Jhmo0r9 IzFw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from howler.vger.email (howler.vger.email. [23.128.96.34]) by mx.google.com with ESMTPS id i16-20020a17090acf9000b00274a22e6364si7272077pju.92.2023.09.27.01.39.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Sep 2023 01:39:41 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by howler.vger.email (Postfix) with ESMTP id D95C3832D719; Wed, 27 Sep 2023 01:22:57 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at howler.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230205AbjI0IWl (ORCPT + 23 others); Wed, 27 Sep 2023 04:22:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33306 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230248AbjI0ILE (ORCPT ); Wed, 27 Sep 2023 04:11:04 -0400 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [IPv6:2a0a:edc0:2:b01:1d::104]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2E32FCEA for ; Wed, 27 Sep 2023 01:11:00 -0700 (PDT) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qlPdE-0008Bd-8B; Wed, 27 Sep 2023 10:10:52 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qlPdD-009I8V-Kp; Wed, 27 Sep 2023 10:10:51 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1qlPdD-005BRm-BW; Wed, 27 Sep 2023 10:10:51 +0200 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Gerd Haeussler , Xing Tong Wu , Tobias Schaffner , Hans de Goede , =?utf-8?q?Ilpo_J=C3=A4rvinen?= , Mark Gross Cc: platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@pengutronix.de Subject: [PATCH 27/27] platform/x86/siemens: simatic-ipc-batt-f7188x: Convert to platform remove callback returning void Date: Wed, 27 Sep 2023 10:10:40 +0200 Message-Id: <20230927081040.2198742-28-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20230927081040.2198742-1-u.kleine-koenig@pengutronix.de> References: <20230927081040.2198742-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1921; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=ppuhwm0gU6+2BGzuuvFr4fZQMjeNK1Hrm/CuJZG8tv4=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBlE+N8ZBf0B8Ls8/0BGKt+T6Vq2yd6huAyrsjPr JIXMiX14lWJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZRPjfAAKCRCPgPtYfRL+ ThqLB/47y3ScJPN+FC65DzwCmtW7dqtILGPC5gzujTdltNJLOSqjhrG2ilqZlNjGAeZNAPYiPSq E2aRJ9nl/904GtO23D7r0F8XaE7e6XD5MtVVbxz+XTjE4tHefbuMwqjDW16t6OeLBHbrwpzdAV5 QCF5QrBAQr29dqLc8RpHhy2367CgLq1tqEf6h4P6u0YzD+dQWgNuvU4SiGeahSnDKSmw5bp4dPO gfFcncvsg29Sw4PSK7LcmCX+uApEiNOuih/OvcydlOti8FfI6APMwtNqKbNxKJsA7WjhbKEFD3W SyfvGzFAMQPrjKdGwzQbwbVLgdKWUhHyzFx664mOG9N0TR9T X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Wed, 27 Sep 2023 01:22:58 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1778179355143584895 X-GMAIL-MSGID: 1778179355143584895 The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/platform/x86/siemens/simatic-ipc-batt-f7188x.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/platform/x86/siemens/simatic-ipc-batt-f7188x.c b/drivers/platform/x86/siemens/simatic-ipc-batt-f7188x.c index 19c302a68911..5e77e05fdb5d 100644 --- a/drivers/platform/x86/siemens/simatic-ipc-batt-f7188x.c +++ b/drivers/platform/x86/siemens/simatic-ipc-batt-f7188x.c @@ -45,11 +45,9 @@ static struct gpiod_lookup_table simatic_ipc_batt_gpio_table_bx_59a = { } }; -static int simatic_ipc_batt_f7188x_remove(struct platform_device *pdev) +static void simatic_ipc_batt_f7188x_remove(struct platform_device *pdev) { simatic_ipc_batt_remove(pdev, batt_lookup_table); - - return 0; } static int simatic_ipc_batt_f7188x_probe(struct platform_device *pdev) @@ -75,7 +73,7 @@ static int simatic_ipc_batt_f7188x_probe(struct platform_device *pdev) static struct platform_driver simatic_ipc_batt_driver = { .probe = simatic_ipc_batt_f7188x_probe, - .remove = simatic_ipc_batt_f7188x_remove, + .remove_new = simatic_ipc_batt_f7188x_remove, .driver = { .name = KBUILD_MODNAME, },