From patchwork Wed Sep 27 08:10:31 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 145251 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:cae8:0:b0:403:3b70:6f57 with SMTP id r8csp2473220vqu; Wed, 27 Sep 2023 01:26:55 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHVKG2GmcLGPwx/CX7k685QWX0R3C/elUaohuD72XpM4SQYBbRMQObSQRyg+lVTRwTzrpcX X-Received: by 2002:a05:6a20:5b0a:b0:15d:66f2:f4f0 with SMTP id kl10-20020a056a205b0a00b0015d66f2f4f0mr929785pzb.29.1695803215654; Wed, 27 Sep 2023 01:26:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695803215; cv=none; d=google.com; s=arc-20160816; b=T9gS0OyojxZbxzcuOTaXBoU+w2RNBBgfewGEcAHYNIQ0/UydQ4tz3CJzLF80InT1mN przmJvY57k0sh9ge0d3sVdBtlvEA5hzAM9Ew0VPIDZrafAiBvUi/gQPw69V18RoOKYCT AAKH1Fm5At7KFAzeSDigiskDMaMb4xaq02IeaqarG9At/MVOmhCTsKNI2i6xcwPWAr82 Z4PiijDMzkmrsdtQH+Fm2QMCV6DfZQEVHGFfc2RAP6kYtOkmC6eetb1w8XOSNxWyDBfC 785XuR1jmdOlmj5mmjs/UsoQD0xlNbBFRX25gBeLDgLHcphXKUS7bF6f75qCEjbfZCbA 9PlQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=2yeY2Jy8CdK4JCANsMTFrx1MWAvniA60WcIcnHihRUU=; fh=Dlo1odEjcRtH1BJ+R8/KYHyn3hjJitJ8wbI0kHiiB+U=; b=eIDPGKMxQYLBRdAIGFwtqXlChnqcBzCNXj4o4ZLRG8lr0p25f3LVTDIhjOLaALgKsC Fi3gVYcUTEPSgtaIiLRcH8tN2t+hFdRWn4Z8U6D9CL0pG3BDjkduxGYlRtF5wCMUcV0i H7tPOzB+p+4Lnv7ratzMImWBERNuHRi7aniHDWOBP5qPHMM3yTSLaolbnq6z6xyq8VdU Ppnn9LLg1Zgtiuk/ECw4MU5+LOXwOV5nZysh5JwXMNXcuqmBrLcdgtxTK3cwd+IRbm7h 7VcEOQPrZbaK5ecPRqctI9VBLYcuiNl6bJL75T2FlBbsWWfAQa5lcV/vXLMTU6lB7O38 jTiA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id v3-20020a655c43000000b00565e386ff44si15406518pgr.702.2023.09.27.01.26.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Sep 2023 01:26:55 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id E7DB281D0C4B; Wed, 27 Sep 2023 01:12:26 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230419AbjI0IMR (ORCPT + 23 others); Wed, 27 Sep 2023 04:12:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33284 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230243AbjI0ILE (ORCPT ); Wed, 27 Sep 2023 04:11:04 -0400 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [IPv6:2a0a:edc0:2:b01:1d::104]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B8D3819F for ; Wed, 27 Sep 2023 01:11:00 -0700 (PDT) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qlPdC-00086H-Ct; Wed, 27 Sep 2023 10:10:50 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qlPdB-009I7u-Jh; Wed, 27 Sep 2023 10:10:49 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1qlPdB-005BRC-AM; Wed, 27 Sep 2023 10:10:49 +0200 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Hans de Goede , =?utf-8?q?Ilpo_J=C3=A4rvinen?= , Mark Gross , Vadim Pasternak Cc: platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@pengutronix.de Subject: [PATCH 18/27] platform/mellanox: mlxreg-lc: Convert to platform remove callback returning void Date: Wed, 27 Sep 2023 10:10:31 +0200 Message-Id: <20230927081040.2198742-19-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20230927081040.2198742-1-u.kleine-koenig@pengutronix.de> References: <20230927081040.2198742-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=2109; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=OgebHyJ1o+cakI4Sj28nDr13s9jhvV2dMgyHvpitWxQ=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBlE+NyGqwa6XJjBwLMBt7Pdf+hattOnrde7yDsd 71DtewBv0+JATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZRPjcgAKCRCPgPtYfRL+ Tp3SB/4jwksQ8EhV3Nuh3lkJZhSyHogXAPjwyPD1wGV7NPFab/t2cFXfYdlwFQt9SOHaQDXlbp0 0Y2o8ZOFaCG+oI87zAc9896w+T/BtGClnvhp43y8Cr5UY7+KNTyPZTypTbAitzAiZYs1r0FaArt f9VyJMWxxgEdlsNn1xPLwL6kVKBe1WEpWkVq2t+Ic/ciDZoDki34aSKZOMqHHykz6tcPQWubMtJ donb5xxPfH2aUfQ/ADU2x2iaxjWpnpAmnftznwesz3rDr1Jy01VYd4szC3TgcJQ66nsE0ELAfgF tnCsrHtc4PgmbF7tgenjfqda1H4xSoMhyhiksDXXXbvgHhbd X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Wed, 27 Sep 2023 01:12:27 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1778178552425413417 X-GMAIL-MSGID: 1778178552425413417 The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/platform/mellanox/mlxreg-lc.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/platform/mellanox/mlxreg-lc.c b/drivers/platform/mellanox/mlxreg-lc.c index 8d833836a6d3..43d119e3a473 100644 --- a/drivers/platform/mellanox/mlxreg-lc.c +++ b/drivers/platform/mellanox/mlxreg-lc.c @@ -907,7 +907,7 @@ static int mlxreg_lc_probe(struct platform_device *pdev) return err; } -static int mlxreg_lc_remove(struct platform_device *pdev) +static void mlxreg_lc_remove(struct platform_device *pdev) { struct mlxreg_core_data *data = dev_get_platdata(&pdev->dev); struct mlxreg_lc *mlxreg_lc = platform_get_drvdata(pdev); @@ -921,7 +921,7 @@ static int mlxreg_lc_remove(struct platform_device *pdev) * is nothing to remove. */ if (!data->notifier || !data->notifier->handle) - return 0; + return; /* Clear event notification callback and handle. */ data->notifier->user_handler = NULL; @@ -940,13 +940,11 @@ static int mlxreg_lc_remove(struct platform_device *pdev) i2c_put_adapter(data->hpdev.adapter); data->hpdev.adapter = NULL; } - - return 0; } static struct platform_driver mlxreg_lc_driver = { .probe = mlxreg_lc_probe, - .remove = mlxreg_lc_remove, + .remove_new = mlxreg_lc_remove, .driver = { .name = "mlxreg-lc", },