From patchwork Wed Sep 27 08:10:30 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 145247 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:cae8:0:b0:403:3b70:6f57 with SMTP id r8csp2472586vqu; Wed, 27 Sep 2023 01:25:25 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFdY2ZUBESUGx1vYYxIdvnFlgO3OMHR75t3tkqLS1NiGlCFU6HPZZ85QV6RqxtdjhSdTuu5 X-Received: by 2002:ac8:5796:0:b0:418:cd5:ac9d with SMTP id v22-20020ac85796000000b004180cd5ac9dmr1395959qta.64.1695803125025; Wed, 27 Sep 2023 01:25:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695803124; cv=none; d=google.com; s=arc-20160816; b=gU6Z38BOy18GoJtW9I/IDRrglTnpP21wqoOVqnNAL6K4mFDor1Zy+SLjJq2SO/5AVs tGonI8RU2V0SwXnymcHi8pc4k9qDuf++wQAwdPKh4O34DseZUf8RIWoXfgPVNjwqFGHi 3KcL9edWGFoDwMIhsCuApcE7dZRIp5WGr7NqSHQPm/upBWAPEjdBAzKay23bHJdJDjaS h0SRmd46JTeeBT1uru87WyLAioukiwbBzY0MRIFxjk8VASjqgyebmgcKGzpDCZE2jhTr GCBtMPIbSPMnsKikGMKMng3kvNfSyrqsOxqs+/1cAXGPxGkYFiEeZC3w9iFRB4C05ykx 4iHg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=LIbzdiRsYLvzc4JHKfb7D9CFgzY80lexQ58iT8qfEH8=; fh=Dlo1odEjcRtH1BJ+R8/KYHyn3hjJitJ8wbI0kHiiB+U=; b=MV7ScMEy8cHnSNT/6N+rm9Ue29R7un2zQKZ+vX2kVMa0aXH4wqvmKh2VWhJIKU7Li7 4bYgMZwvg6iai0of6QgE3ROEMnttkFRvNBgoilB4IW+iEk0lHcXI8NfJkN9RfWoU2BZz gK4R+TZf9T5TpG3VMg9AZmon4omm6wgxw45dhKju9af384WVAdNXoes01zapDEr51Z00 pzzRRKuhQwZoF1ixOwNsEB3mirOagjAGEdzGkEhnAEZCV1bQ/1Yr25+781rM4tFgYw47 TWlO1T9SuikD6T7ijGkKHiXHFfKRbiK8WA9qzHntFkrTEXksWkd1uX36TP3pmOUpCVs+ 8CdQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from agentk.vger.email (agentk.vger.email. [23.128.96.32]) by mx.google.com with ESMTPS id w1-20020a63c101000000b005653316de6fsi15309206pgf.271.2023.09.27.01.25.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Sep 2023 01:25:24 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id F19E7801B67C; Wed, 27 Sep 2023 01:13:55 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230254AbjI0IM0 (ORCPT + 23 others); Wed, 27 Sep 2023 04:12:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35238 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230238AbjI0ILE (ORCPT ); Wed, 27 Sep 2023 04:11:04 -0400 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [IPv6:2a0a:edc0:2:b01:1d::104]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 985641A8 for ; Wed, 27 Sep 2023 01:11:01 -0700 (PDT) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qlPdC-00085h-5f; Wed, 27 Sep 2023 10:10:50 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qlPdB-009I7p-DJ; Wed, 27 Sep 2023 10:10:49 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1qlPdB-005BR8-40; Wed, 27 Sep 2023 10:10:49 +0200 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Hans de Goede , =?utf-8?q?Ilpo_J=C3=A4rvinen?= , Mark Gross , Vadim Pasternak Cc: platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@pengutronix.de Subject: [PATCH 17/27] platform/mellanox: mlxreg-io: Convert to platform remove callback returning void Date: Wed, 27 Sep 2023 10:10:30 +0200 Message-Id: <20230927081040.2198742-18-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20230927081040.2198742-1-u.kleine-koenig@pengutronix.de> References: <20230927081040.2198742-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1748; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=W1A4okYNik1VMgJpJLoBZFEE+DlDZ2qN4h6QATaBCC4=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBlE+Nxthg5Ec1AQ5v355kFCMJJ81EwvWpNdy6Ea fI7RfQySLyJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZRPjcQAKCRCPgPtYfRL+ Tg/qB/wJX8G3HE0qqXOb9ERJi68xtzC2i1a+W9RDR+4APiDhliH6rE7GesPvO/MumZIkUOuoviU gPDp9kYrqTBTiseLDrlp4InyXLXouMtVlmgN4Cvuuj6FpVhiW22T0pYdODxXmcrNPSnvYrqGrLF mB6tqWZnfiB/pvKbja0YrVQhrfminKhUgBlKSF2jGjky2VLwgyqgw6E34Kwfuf7iIk8ghivGUh1 K3cxZmsZ5l1P2pNUtwFTJE92rejSB5ojYAyKsMwBOaJP/qm0oQvYIUz7/FajJTyfwbywO1jJ9nk oJqOUqu4ZT0UCZjzmjozuS9cW2VJyoBp7WiygWy4sIp/TquW X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Wed, 27 Sep 2023 01:13:56 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1778178457610580525 X-GMAIL-MSGID: 1778178457610580525 The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/platform/mellanox/mlxreg-io.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/platform/mellanox/mlxreg-io.c b/drivers/platform/mellanox/mlxreg-io.c index 83ba037408cd..ee7bd623ba44 100644 --- a/drivers/platform/mellanox/mlxreg-io.c +++ b/drivers/platform/mellanox/mlxreg-io.c @@ -263,13 +263,11 @@ static int mlxreg_io_probe(struct platform_device *pdev) return 0; } -static int mlxreg_io_remove(struct platform_device *pdev) +static void mlxreg_io_remove(struct platform_device *pdev) { struct mlxreg_io_priv_data *priv = dev_get_drvdata(&pdev->dev); mutex_destroy(&priv->io_lock); - - return 0; } static struct platform_driver mlxreg_io_driver = { @@ -277,7 +275,7 @@ static struct platform_driver mlxreg_io_driver = { .name = "mlxreg-io", }, .probe = mlxreg_io_probe, - .remove = mlxreg_io_remove, + .remove_new = mlxreg_io_remove, }; module_platform_driver(mlxreg_io_driver);